* Can't build Emacs on master branch
@ 2018-08-19 16:33 Federico
2018-08-19 17:08 ` Paul Eggert
0 siblings, 1 reply; 3+ messages in thread
From: Federico @ 2018-08-19 16:33 UTC (permalink / raw
To: emacs-devel
I having problems getting Emacs to build on commit 5c3dba24ef, after
cloning and running make, I get:
make[2]: Entering directory '/home/fede/Workspace/emacs/lisp'
ELC calc/calc-aent.elc
In toplevel form:
calc/calc-aent.el:28:1:Error: Arithmetic range error: "expt", 10, 9
Makefile:301: recipe for target 'calc/calc-aent.elc' failed
make[2]: *** [calc/calc-aent.elc] Error 1
make[2]: Leaving directory '/home/fede/Workspace/emacs/lisp'
Makefile:324: recipe for target 'compile-main' failed
make[1]: *** [compile-main] Error 2
make[1]: Leaving directory '/home/fede/Workspace/emacs/lisp'
Makefile:405: recipe for target 'lisp' failed
make: *** [lisp] Error 2
In case it matters, I'm on a x86-64 Celeron J4005 processor, using Ubuntu 18.04.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Can't build Emacs on master branch
2018-08-19 16:33 Can't build Emacs on master branch Federico
@ 2018-08-19 17:08 ` Paul Eggert
2018-08-19 18:02 ` Federico Tedin
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2018-08-19 17:08 UTC (permalink / raw
To: Federico, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
Federico wrote:
> calc/calc-aent.el:28:1:Error: Arithmetic range error: "expt", 10, 9
Thanks for reporting it, as it didn't happen on the platform I was testing with.
I installed the attached, which should fix it.
[-- Attachment #2: 0001-Fix-expt-signedness-bug-without-wide-int.patch --]
[-- Type: text/x-patch, Size: 1036 bytes --]
From ecd7a9407711ebe24d7e07d4402a2d66754ee693 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 19 Aug 2018 10:05:41 -0700
Subject: [PATCH] Fix expt signedness bug --without-wide-int
Problem reported by Federico in:
https://lists.gnu.org/r/emacs-devel/2018-08/msg00619.html
* src/floatfns.c (Fexpt): Use TYPE_RANGED_FIXNUMP, not
RANGED_FIXNUMP, to fix bug with unsigned comparison on
platforms built --without-wide-int.
---
src/floatfns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/floatfns.c b/src/floatfns.c
index 54d068c29e..7c52a0a9a2 100644
--- a/src/floatfns.c
+++ b/src/floatfns.c
@@ -212,7 +212,7 @@ DEFUN ("expt", Fexpt, Sexpt, 2, 2, 0,
if (INTEGERP (arg1) && NATNUMP (arg2))
{
unsigned long exp;
- if (RANGED_FIXNUMP (0, arg2, ULONG_MAX))
+ if (TYPE_RANGED_FIXNUMP (unsigned long, arg2))
exp = XFIXNUM (arg2);
else if (MOST_POSITIVE_FIXNUM < ULONG_MAX && BIGNUMP (arg2)
&& mpz_fits_ulong_p (XBIGNUM (arg2)->value))
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Can't build Emacs on master branch
2018-08-19 17:08 ` Paul Eggert
@ 2018-08-19 18:02 ` Federico Tedin
0 siblings, 0 replies; 3+ messages in thread
From: Federico Tedin @ 2018-08-19 18:02 UTC (permalink / raw
To: Paul Eggert; +Cc: emacs-devel
>> calc/calc-aent.el:28:1:Error: Arithmetic range error: "expt", 10, 9
>
>
> Thanks for reporting it, as it didn't happen on the platform I was testing
> with. I installed the attached, which should fix it.
Thanks Paul, the patch worked.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-19 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-19 16:33 Can't build Emacs on master branch Federico
2018-08-19 17:08 ` Paul Eggert
2018-08-19 18:02 ` Federico Tedin
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.