From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oleh Krehel <ohwoeowho@gmail.com>
Subject: Re: Could org-mode use `completing-read-function' instead of
 `org-icompleting-read'?
Date: Thu, 16 Apr 2015 17:30:44 +0200
Message-ID: <CAA01p3r=347vt8-ZZ26VSYGCFE=K4A9zfH7R3yLEPjoGu8WVVg@mail.gmail.com>
References: <CAA01p3q3bKhvc4j4uXWj7MMO=sStjeYiFcZ9U6m1mQh=uH_Z8A@mail.gmail.com>
	<87egnk17wg.fsf@gmx.us>
	<CAA01p3r4TB8mEwAZS+z4eb_0LWo1PRHSHQ+G8V_6Ht-75Wc77w@mail.gmail.com>
	<87egnkt7yv.fsf@gmx.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1Yilke-000245-Rx
	for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 11:30:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1Yilkb-000833-S8
	for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 11:30:48 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:35603)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1Yilkb-00082Z-Dw
	for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 11:30:45 -0400
Received: by wgyo15 with SMTP id o15so85070870wgy.2
	for <emacs-orgmode@gnu.org>; Thu, 16 Apr 2015 08:30:44 -0700 (PDT)
In-Reply-To: <87egnkt7yv.fsf@gmx.us>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org

On Thu, Apr 16, 2015 at 5:21 PM, Rasmus <rasmus@gmx.us> wrote:
> Hi Oleh,
>
> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>>>> I was just trying to customize the completion back end for refiling
>>>> (ido isn't
>>>> great for that, even with the ido-vertical upgrade).  And it's not
>>>> at all easy,
>>>> since ido seems to be hard-wired into org-mode's completion.  Could we just
>>>> change to use `completing-read-function' instead of `org-icompleting-read'?
>>>
>>> I think it's nicer to use existing features/variables, but comparability
>>> is also an issue.
>>
>> Alright, I've made so that if `completing-read-function' is
>> `completing-read-default', nothing changes.  But when it's set, it
>> used. So now, e.g. `helm-mode' or `ivy-mode' will automatically work.
>
> The change is no good IMO.  For the fix to work one needs to set
> org-completion-use-ido.  If this is non-nil it would be weird if ido is
> not used.
>

> I don't know how to use helm of ivy.  But I think the attached patch is
> better.  Would that work with helm and ivy?

I could live with it, but basically `org-completion-use-ido` says "I
don't care if you've temporarily disabled `ido-mode' or not, I'll use
ido anyway". This isn't a good approach, especially considering that
`ido-mode' is already a convenient minor mode.
Maybe `org-completion-use-ido' should be completely removed, and ido completion
should be used automatically when `ido-mode' is on.

Oleh