From: Oleh <ohwoeowho@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org.el (org-delete-property): Remove bogus properties
Date: Thu, 13 Mar 2014 21:57:50 +0100 [thread overview]
Message-ID: <CAA01p3qEM=s3RNTeMr0DaN758W7sYgb0v2xPYqa9LrF0BWbzmw@mail.gmail.com> (raw)
In-Reply-To: <878usfcm5q.fsf@bzg.ath.cx>
Hi Bastien,
I've pushed a bugfix related to the patch.
`org-entry-delete' was being called with 3 args, although it takes 2.
I hope I understood it correctly. Could you please check?
regards,
Oleh
On Wed, Mar 12, 2014 at 7:22 PM, Bastien <bzg@gnu.org> wrote:
> Hi Oleh,
>
> Oleh <ohwoeowho@gmail.com> writes:
>
>> Can someone have a look at this patch and check it in?
>
> I applied a different patch, things are a bit more complicate:
> (org-get-category) always returns a non-empty string (at least
> after `org-refresh-category-properties' as been called once),
> while (org-entry-get (point) "CATEGORY") is the real check we
> need to perform.
>
> Thanks for raising this!
>
> --
> Bastien
>
next prev parent reply other threads:[~2014-03-13 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 16:19 [PATCH] org.el (org-delete-property): Remove bogus properties Oleh
2014-03-12 18:22 ` Bastien
2014-03-13 20:57 ` Oleh [this message]
2014-03-13 22:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA01p3qEM=s3RNTeMr0DaN758W7sYgb0v2xPYqa9LrF0BWbzmw@mail.gmail.com' \
--to=ohwoeowho@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.