* Fixing namespace prefixes in outline.el
@ 2015-01-26 18:31 Oleh
2015-01-26 18:52 ` Stephen Leake
2015-01-28 11:47 ` Oleh Krehel
0 siblings, 2 replies; 3+ messages in thread
From: Oleh @ 2015-01-26 18:31 UTC (permalink / raw)
To: emacs-devel
Hi all,
As I was looking to improve the patch in
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19493, I've noticed that
outline.el has some really outdated stuff, like function names without
prefixes, and plain text instead of "\\{outline-mode-map}" in the mode
definition.
Is it OK to e.g.:
(defun outline-show-subtree ()
"Show everything after this heading at deeper levels."
(interactive)
(outline-flag-subtree nil))
(define-obsolete-function-alias
'show-subtree 'outline-show-subtree "25.1")
Also, what's the opinion on the indentation with tabs and spaces?
Encouraged / discouraged / don't care? I very much prefer spaces only.
regards,
Oleh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fixing namespace prefixes in outline.el
2015-01-26 18:31 Fixing namespace prefixes in outline.el Oleh
@ 2015-01-26 18:52 ` Stephen Leake
2015-01-28 11:47 ` Oleh Krehel
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Leake @ 2015-01-26 18:52 UTC (permalink / raw)
To: emacs-devel
Oleh <ohwoeowho@gmail.com> writes:
> Also, what's the opinion on the indentation with tabs and spaces?
> Encouraged / discouraged / don't care? I very much prefer spaces only.
If this was documented in /CONTRIBUTE, we would not have to keep
answering this question.
--
-- Stephe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fixing namespace prefixes in outline.el
2015-01-26 18:31 Fixing namespace prefixes in outline.el Oleh
2015-01-26 18:52 ` Stephen Leake
@ 2015-01-28 11:47 ` Oleh Krehel
1 sibling, 0 replies; 3+ messages in thread
From: Oleh Krehel @ 2015-01-28 11:47 UTC (permalink / raw)
To: emacs-devel
> Is it OK to e.g.:
>
> (defun outline-show-subtree ()
> "Show everything after this heading at deeper levels."
> (interactive)
> (outline-flag-subtree nil))
>
> (define-obsolete-function-alias
> 'show-subtree 'outline-show-subtree "25.1")
All namespace changes are now in origin/scratch/outline.
I also added/improved a bunch of docstrings in outline.el.
Could someone please revew and merge it?
Oleh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-28 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-26 18:31 Fixing namespace prefixes in outline.el Oleh
2015-01-26 18:52 ` Stephen Leake
2015-01-28 11:47 ` Oleh Krehel
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.