From: Oleh Krehel <ohwoeowho@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring
Date: Fri, 30 Jan 2015 09:58:50 +0100 [thread overview]
Message-ID: <CAA01p3peZbw=7iteH=c0PM-=VWznjg8TjdtWQUjEC_RzGXPV3g@mail.gmail.com> (raw)
In-Reply-To: <CAA01p3qJRAgSHeKUeG_0sNBLXTd66_Nk2BFPmpOc++UTfy6ysQ@mail.gmail.com>
On Fri, Jan 30, 2015 at 9:16 AM, Oleh Krehel <ohwoeowho@gmail.com> wrote:
> On Fri, Jan 30, 2015 at 7:20 AM, Stefan Monnier
> <monnier@iro.umontreal.ca> wrote:
>>>>>>> "Oleh" == Oleh Krehel <ohwoeowho@gmail.com> writes:
>>
>>> branch: scratch/outline
>>> commit 834612fd984029b72f5c172bf3573aa7607fbe48
>>> Author: Oleh Krehel <ohwoeowho@gmail.com>
>>> Commit: Oleh Krehel <ohwoeowho@gmail.com>
>>
>>> lisp/outline.el (outline-mode): Clean up docstring
>>
>>> * lisp/outline.el (font-lock-warning-face): Remove unused declare.
>>> (outline-mode-prefix-map): Remove obsolete comment.
>>> (outline-font-lock-face): Remove obsolete comment.
>>
>> This patch seems to contain a lot of gratuitous re-indentation and other
>> whitespace changes. This are fine in the code you change, but
>> not elsewhere.
Just finished undoing the whitespace changes. It's pushed as
scratch/outline-nowhitespace. Lesson learned, sorry for the noise.
Oleh
prev parent reply other threads:[~2015-01-30 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150129162157.30895.36033@vcs.savannah.gnu.org>
[not found] ` <E1YGrqy-000842-B8@vcs.savannah.gnu.org>
2015-01-30 6:20 ` [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring Stefan Monnier
2015-01-30 8:16 ` Oleh Krehel
2015-01-30 8:58 ` Oleh Krehel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA01p3peZbw=7iteH=c0PM-=VWznjg8TjdtWQUjEC_RzGXPV3g@mail.gmail.com' \
--to=ohwoeowho@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.