From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dominique Quatravaux Newsgroups: gmane.emacs.bugs Subject: bug#68954: [PATCH] Crasher in treesit_traverse_get_predicate Date: Tue, 6 Feb 2024 18:08:18 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000aa4f4c0610b9a024" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26227"; mail-complaints-to="usenet@ciao.gmane.io" To: 68954@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 06 18:09:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXOwf-0006aV-QQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Feb 2024 18:09:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXOwF-00031i-Kr; Tue, 06 Feb 2024 12:08:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOwD-00031Z-AU for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:08:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXOwD-0002g1-2Y for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:08:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXOwQ-0005pV-9E for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dominique Quatravaux Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170723933522394 (code B ref -1); Tue, 06 Feb 2024 17:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Feb 2024 17:08:55 +0000 Original-Received: from localhost ([127.0.0.1]:55031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXOwJ-0005p6-I2 for submit@debbugs.gnu.org; Tue, 06 Feb 2024 12:08:55 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:52944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXOwH-0005oq-HN for submit@debbugs.gnu.org; Tue, 06 Feb 2024 12:08:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOvy-00030S-Qf for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:08:34 -0500 Original-Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXOvx-0002XJ-7Y for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:08:34 -0500 Original-Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-6002317a427so51191987b3.2 for ; Tue, 06 Feb 2024 09:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quatravaux-org.20230601.gappssmtp.com; s=20230601; t=1707239311; x=1707844111; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=IPCvNimqr7cAttpIkQIaIgIn+0NEfDTSpAv9xl7ZxcI=; b=Kq+k1Tb2MXc01H4z3jGRbVP2hA0lVuopREU95wU/ComDnta9+FMKfB/BZP/JShRIWf rxK6NASd3gRyEyxpHdu46kzdfZlV5LTUDF0Ee47wY0bdOasaaVatwNb76Ff+KgeQ+CYd e+hZLIKUfUl3IA4ZTvV+xpxYFKQPjJszkLvkZyNzbgLPuqmL8DSQpaiZif2cUKRvaBS0 7MrF4Chk65B5SKv7Qndd98+/TadWxdu2y9VpTgDsHwlTfV447T/ROcmArYFuby4eROpz ebnVTF361tAF0zBtr/cxhllaMpxvYzR0KldOqStUzveTgyz+Kl9PS5PSioNKCy+6OgSD xTxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707239311; x=1707844111; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IPCvNimqr7cAttpIkQIaIgIn+0NEfDTSpAv9xl7ZxcI=; b=Ob+oUeEi+oR2YojApAP6zaXEzKobfZ8DGQ1OZiQgFMJNRAa3i577piN6Zsm2ca1ygE CY14YcR8mhjcPtAJZGoDNCttlAv/I3FL9muAuA/YrzmrEaTTolbgEQX7LDMJNi6bYF+u c1UwYAybniddG46ITPVQY6DOy16bcmN3t3WE+fKeEGnXrO/xv57HWeFQQoJTRMEyRscM 0E/yK5+NPp5dKArz8ba9T9r52KEpXHGTIHYBxGZ3/U2f7SOaxaYEtpCADBca/mGDmGBZ qwknTfYaxIaiq5p+pxoR2FXcrbEa4o3xn5bJIu10MV14BHGXqdN8fBxzk+BXRc3ZJKQI PAhw== X-Gm-Message-State: AOJu0YyvWi5reongDuzB2kMZ9goPrS4cHqdE/H1dxwqlIacfxJht/rZu C4X43N4sEpk00OYhZzOGRg48jC+L2+lcSsfKw0GsHVcXNr/lmBB43BUTZBpCAZ+L7Aw+FQs9tG7 vPs3Q5j9xp2F2t6qtUPcc/0nwW5P4oB0P3ZeMO98u4OFgrsn6tQFFog== X-Google-Smtp-Source: AGHT+IFX2JtRrMgYcFuqcthFgRaHXBQD3Adw8OiyjwFK7YKWE4KdCnn4QVn32feTP6Py+DLYxk6NWib4JuYLa/GmCHY= X-Received: by 2002:a25:b81:0:b0:dc6:bafe:6a53 with SMTP id 123-20020a250b81000000b00dc6bafe6a53mr2102886ybl.4.1707239310752; Tue, 06 Feb 2024 09:08:30 -0800 (PST) Received-SPF: none client-ip=2607:f8b0:4864:20::1134; envelope-from=dominique@quatravaux.org; helo=mail-yw1-x1134.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279502 Archived-At: --000000000000aa4f4c0610b9a024 Content-Type: multipart/alternative; boundary="000000000000aa4f490610b9a022" --000000000000aa4f490610b9a022 Content-Type: text/plain; charset="UTF-8" Because nothing guarantees or enforces that either Vtreesit_thing_settings, or the cdrs of its elements, are cons cells, it is easy to construct values for `treesit-thing-settings' that make Emacs crash (e.g., when calling `prog-fill-reindent-defun' from any tree-sitter enabled mode). The attached patch fixes that. -- Dominique Quatravaux dominique@quatravaux.org --000000000000aa4f490610b9a022 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Because nothing guarantees or enforces that either Vt= reesit_thing_settings, or the cdrs of its elements, are cons cells, it is e= asy to construct values for `treesit-thing-settings' that make Emacs cr= ash (e.g., when calling `prog-fill-reindent-defun' from any tree-sitter= enabled mode).

The attached patch fixes that.

--
=C2=A0Dominique Quatravaux
=C2=A0dominique@quatravaux.org
--000000000000aa4f490610b9a022-- --000000000000aa4f4c0610b9a024 Content-Type: application/octet-stream; name="treesit.diff" Content-Disposition: attachment; filename="treesit.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsam6n700 LS0tIHRyZWVzaXQuYy5vcmlnCTIwMjQtMDItMDYgMTg6MDE6MjMKKysrIHRyZWVzaXQuYwkyMDI0 LTAyLTA2IDE4OjAxOjQxCkBAIC0zMjY4LDExICszMjY4LDExIEBACiBzdGF0aWMgTGlzcF9PYmpl Y3QKIHRyZWVzaXRfdHJhdmVyc2VfZ2V0X3ByZWRpY2F0ZSAoTGlzcF9PYmplY3QgdGhpbmcsIExp c3BfT2JqZWN0IGxhbmd1YWdlKQogewotICBMaXNwX09iamVjdCBjb25zID0gYXNzcV9ub19xdWl0 IChsYW5ndWFnZSwgVnRyZWVzaXRfdGhpbmdfc2V0dGluZ3MpOworICBMaXNwX09iamVjdCBjb25z ID0gYXNzcV9ub19zaWduYWwgKGxhbmd1YWdlLCBWdHJlZXNpdF90aGluZ19zZXR0aW5ncyk7CiAg IGlmIChOSUxQIChjb25zKSkKICAgICByZXR1cm4gUW5pbDsKICAgTGlzcF9PYmplY3QgZGVmaW5p dGlvbnMgPSBYQ0RSIChjb25zKTsKLSAgTGlzcF9PYmplY3QgZW50cnkgPSBhc3NxX25vX3F1aXQg KHRoaW5nLCBkZWZpbml0aW9ucyk7CisgIExpc3BfT2JqZWN0IGVudHJ5ID0gYXNzcV9ub19zaWdu YWwgKHRoaW5nLCBkZWZpbml0aW9ucyk7CiAgIGlmIChOSUxQIChlbnRyeSkpCiAgICAgcmV0dXJu IFFuaWw7CiAgIC8qIEVOVFJZIGxvb2tzIGxpa2UgKFRISU5HIFBSRUQpLiAgKi8K --000000000000aa4f4c0610b9a024--