bug#75194: Compilation of latest `scratch/igc' fails with `xwidget' on MacOS

bug#75194: Compilation of latest `scratch/igc' fails with `xwidget' on MacOS

[黄京]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Hi,

I'm encountering a compile-time error when building the latest Emacs igc
branch with the `--with-mps=yes' and `--with-xwidget' options:

*igc.c:2459:5: error: no member named 'gc_header' in 'struct xwidget_view';
did you mean 'header'?*

 2459 |     IGC_FIX12_HEADER (ss, &w->xv);

      | *    ^*

*igc.c:1144:61: note: *expanded from macro 'IGC_FIX12_HEADER'

 1144 |       igc_assert ((mps_addr_t) (*p) == (mps_addr_t) &
(*p)->gc_header); \

      | *                                                            ^*

*./xwidget.h:104:28: note: *'header' declared here

  104 |   struct vectorlike_header header;

      | *                           ^*


Please let me know if you need any additional information to investigate
this issue.


Thanks.

[-- Attachment #2: Type: text/html, Size: 5664 bytes --]

bug#75194: Compilation of latest `scratch/igc' fails with `xwidget' on MacOS

[Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors]

黄京 <radionoisee@gmail.com> writes:

> Hi,
>
> I'm encountering a compile-time error when building the latest Emacs igc branch with the `--with-mps=yes' and `--with-xwidget' options:

The good news it's easy to fix that particular error (add ".header");
the bad news is that no one reported this before, so you'd be the first
to test this combination.

It's probably best to look over the xwidgets code to make sure it
doesn't have any obvious problems before testing this combination.

I tried building with webkit on GNU/Linux, but it didn't work right
away.  Currently trying another distribution.

Pip

bug#75194: Compilation of latest `scratch/igc' fails with `xwidget' on MacOS

[Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Pip Cet <pipcet@protonmail.com> writes:

> 黄京 <radionoisee@gmail.com> writes:
>
>> Hi,
>>
>> I'm encountering a compile-time error when building the latest Emacs igc branch with the `--with-mps=yes' and `--with-xwidget' options:
>
> The good news it's easy to fix that particular error (add ".header");
> the bad news is that no one reported this before, so you'd be the first
> to test this combination.

> It's probably best to look over the xwidgets code to make sure it
> doesn't have any obvious problems before testing this combination.

I didn't read all of the file, but I checked the basic stuff, and it
seems to be fine.  It also built and didn't immediately crash Emacs, but
I don't think I know how to use xwidgets (I also had to fake a pkgconfig
file for some reason, and try three distros to get it to work at
all...)

No guarantees, but I pushed something.  I had to copy out of a docker
container so hopefully made the same changes on scratch/igc.

I'd be very interested to hear whether this survives some GC cycles (M-x
igc-stats; then hit "c" a few times) when xwidgets are in use.  If it
does, we can close this bug.

Pip

bug#75194: Compilation of latest `scratch/igc' fails with `xwidget' on MacOS

[黄京]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

> I'd be very interested to hear whether this survives some GC cycles (M-x
> igc-stats; then hit "c" a few times) when xwidgets are in use.  If it
> does, we can close this bug.

Thanks for the quick fix!

Emacs built successfully, and after manually cycling GC while rendering web
pages in xwidget, everything appears to work correctly without crashes.

I believe this resolves the issue, and the bug can be considered fixed and
closed.  Let me know if any further verification is needed.

Pip Cet <pipcet@protonmail.com> 於 2024年12月31日 週二 上午7:21寫道：

> Pip Cet <pipcet@protonmail.com> writes:
>
> > 黄京 <radionoisee@gmail.com> writes:
> >
> >> Hi,
> >>
> >> I'm encountering a compile-time error when building the latest Emacs
> igc branch with the `--with-mps=yes' and `--with-xwidget' options:
> >
> > The good news it's easy to fix that particular error (add ".header");
> > the bad news is that no one reported this before, so you'd be the first
> > to test this combination.
>
> > It's probably best to look over the xwidgets code to make sure it
> > doesn't have any obvious problems before testing this combination.
>
> I didn't read all of the file, but I checked the basic stuff, and it
> seems to be fine.  It also built and didn't immediately crash Emacs, but
> I don't think I know how to use xwidgets (I also had to fake a pkgconfig
> file for some reason, and try three distros to get it to work at
> all...)
>
> No guarantees, but I pushed something.  I had to copy out of a docker
> container so hopefully made the same changes on scratch/igc.
>
> I'd be very interested to hear whether this survives some GC cycles (M-x
> igc-stats; then hit "c" a few times) when xwidgets are in use.  If it
> does, we can close this bug.
>
> Pip
>
>

[-- Attachment #2: Type: text/html, Size: 2577 bytes --]

bug#75194: Compilation of latest `scratch/igc' fails with `xwidget' on MacOS

[Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors]

黄京 <radionoisee@gmail.com> writes:

>> I'd be very interested to hear whether this survives some GC cycles (M-x
>> igc-stats; then hit "c" a few times) when xwidgets are in use.  If it
>> does, we can close this bug.
>
> Thanks for the quick fix!
>
> Emacs built successfully, and after manually cycling GC while rendering web
> pages in xwidget, everything appears to work correctly without crashes.
>
> I believe this resolves the issue, and the bug can be considered fixed and
> closed.  Let me know if any further verification is needed.

Not on xwidgets specifically, but if you feel like it, sharing your
experiences with scratch/igc in general is always appreciated.

Closing this bug.  Thanks for the report!

Pip