From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Taegil Bae Newsgroups: gmane.emacs.bugs Subject: bug#35843: PNG warning: Interlace handling should be turned on when using png_read_image Date: Tue, 21 May 2019 22:01:38 +0900 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="208204"; mail-complaints-to="usenet@blaine.gmane.org" To: 35843@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 21 15:03:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT4QA-000s1E-BJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 May 2019 15:03:11 +0200 Original-Received: from localhost ([127.0.0.1]:53578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT4Q9-0002nS-9E for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 May 2019 09:03:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT4Q3-0002jO-HJ for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:03:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT4Q2-00013R-LD for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT4Q2-00013H-Hx for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hT4Q2-0002cy-Bu for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Taegil Bae Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 May 2019 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35843 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155844373010035 (code B ref -1); Tue, 21 May 2019 13:03:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 May 2019 13:02:10 +0000 Original-Received: from localhost ([127.0.0.1]:38933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4PB-0002bn-Lo for submit@debbugs.gnu.org; Tue, 21 May 2019 09:02:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4P9-0002bZ-PW for submit@debbugs.gnu.org; Tue, 21 May 2019 09:02:08 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35311) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hT4P4-0000a0-Ek for submit@debbugs.gnu.org; Tue, 21 May 2019 09:02:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT4P3-0002V0-Dy for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:02:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT4P1-0000Xp-23 for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:02:00 -0400 Original-Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:46650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT4P0-0000V6-Of for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:01:58 -0400 Original-Received: by mail-qt1-x82c.google.com with SMTP id z19so20238823qtz.13 for ; Tue, 21 May 2019 06:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=clIeuM3nu4hiZ4LiufZmFNxWAuX39+SBuGxqX9GbaCI=; b=eF5hw1kZXzHvrQI5uSaaYvDvvDWw+eHwsQyBio+Q/Hl/7P9dYAyK+PiGud0zJFKA3k rUU0xSmq0KqFAJLv2kjxog5AmDTv0zSK98HvCE2/nrHF+5s72mjE52Rts53RhTd9TDHD zZsion34xtcgnvVX2UK2YpMIgvLZnURGrrQnifHia9Kz77QtvcNnNG2lGxKXK08NfK3L N0Ymq6Y5lNvBrBuUgVR2Dq6CT68q3DgmoNkJuA0w8Xtt8+9gJv+ROzWC+a2PgJVZ28V4 BTTmuO4a5LGcYyqKYx9WPAGGZYgVPp1jVr0Th5RlsT47GgNgMC0USgYCJ5C9R4M+7xhs jnSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=clIeuM3nu4hiZ4LiufZmFNxWAuX39+SBuGxqX9GbaCI=; b=GkclKk/X85ISs0sGtcef9pUhqWGFW1oDGJRiDfjzkZ9sZ2wxuDv7HsdS0usaYI2zYE v7vI3YA2vWuuRXJR61ECHBmWbJE8pmKLS9zUubn8vNMXBoXfIjgK4pNHq45H95zi/0xu NfXgSW4vObwooS04Ui5dvIbiwxCxopT3XjtM8q3rlJquTD8DqiiQKbtP/jVMlrwQyfAr 27iyJ5Iz6TUHOHe0USupk1n1qp9r3FoZbhb+CGQ7cAYwp/8VHvdQlAAsx/s8kf8gxiyF oPBEX02e4+wzg97vfftdNYxapY3y/ustF4uoN2A4YaMeKSsta0hLBf+7+CMgyoA5V+TE ktCw== X-Gm-Message-State: APjAAAXCMosdOkEavi+eSNteNgowq3Isu7NJXLy1OWx/+abymkavFI/0 63giMz5WZic85XmVoO/dEXZrVrW6vrGHR9IEBqgIE+lGTpqPTA== X-Google-Smtp-Source: APXvYqxX5x2CZp+hjLt6Uzrbjwi5NTLHKMrGKGzv67+vJDpscgzOVrYcTHkGvyoZlKu5VFg7rAjQkPi+8QO/k3A7jvY= X-Received: by 2002:a0c:d251:: with SMTP id o17mr63711638qvh.181.1558443714945; Tue, 21 May 2019 06:01:54 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159611 Archived-At: Hi, I got the following warning in Messages buffer: PNG warning: Interlace handling should be turned on when using png_read_image This is caused by the spacemacs log, which is an interlaced png image. According to the libpng source code, a caller to png_read_update_info(), png_read_image() has to turn on interlace handling. After I patched emacs source code as below, the PNG waring disappeared: diff --git a/src/image.c b/src/image.c index 35ca3e2d66d..e0f6bbcc581 100644 --- a/src/image.c +++ b/src/image.c @@ -6214,6 +6214,8 @@ png_load_body (struct frame *f, struct image *img, struct png_load_context *c) } /* Update info structure. */ + if (png_get_interlace_type(png_ptr, info_ptr) != PNG_INTERLACE_NONE) + png_set_interlace_handling(png_ptr); png_read_update_info (png_ptr, info_ptr); /* Get number of channels. Valid values are 1 for grayscale images Best regards, Taegil