From: Scott Turner <srt19170@gmail.com>
To: 16117@debbugs.gnu.org
Subject: bug#16117: Patch for Emacsclient Unwanted Warning
Date: Fri, 13 Dec 2013 10:46:12 -0500 [thread overview]
Message-ID: <CA+fxJPSh8aG5Q6L63PfrTOkM5nqCfDjpnoAOrDJWaBDBq090bw@mail.gmail.com> (raw)
In-Reply-To: <CAD+dB9DbjPVoC71u_bVwhBcTbeFNHiw-ArjfFOH7bCUr-Qu1mQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2265 bytes --]
In emacsclient, if an existing Emacs server cannot be found and an
alternate editor is specified, the alternate editor is started. Along the
way, emacsclient generates a warning that the server cannot be found.
On Windows, this warning is a pop-up dialog box that must be dismissed by
the user. This is an unwanted interruption, and irrelevant, since the user
has already indicated by using the --alternated-editor option how to handle
this situation.
The patch below suppresses this warning when the user has specified both
the --quiet option and the --alternate-editor option. The reasoning is
that --quiet mutes all messages on success, and that because the
--alternate-editor has been specified, this message is not reporting an
error. It seems like a reasonable compromise that will allow users to see
this warning if they like (by not using --quiet) and allow users to avoid
it if they like (by using --quiet).
*** emacsclient.c Tue Jan 1 15:37:17 2013
--- emacsclient-nomsg.c Fri Dec 13 10:05:30 2013
***************
*** 1002,1015 ****
/* Open up an AF_INET socket. */
if ((s = socket (AF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0)
{
! sock_err_message ("socket");
return INVALID_SOCKET;
}
/* Set up the socket. */
if (connect (s, (struct sockaddr *) &server, sizeof server) < 0)
{
! sock_err_message ("connect");
return INVALID_SOCKET;
}
--- 1002,1027 ----
/* Open up an AF_INET socket. */
if ((s = socket (AF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0)
{
! /*
! * If we have an alternate editor specified, then a socket error
! * isn't really an "error" (because we'll end up invoking the
! * alternate editor) so if asked we'll be quiet about this error
! * message.
! *
! */
! if (!quiet || !alternate_editor) {
! sock_err_message ("socket");
! };
return INVALID_SOCKET;
}
/* Set up the socket. */
if (connect (s, (struct sockaddr *) &server, sizeof server) < 0)
{
! /* See comment above for rationale about showing/not showing err */
! if (!quiet || !alternate_editor) {
! sock_err_message ("connect");
! };
return INVALID_SOCKET;
}
[-- Attachment #2: Type: text/html, Size: 2581 bytes --]
next prev parent reply other threads:[~2013-12-13 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 2:47 bug#16117: 24.3; emacsclient -q enhancement request please also suppress gregrwm
2013-12-13 15:46 ` Scott Turner [this message]
2019-06-26 15:02 ` bug#16117: Patch for Emacsclient Unwanted Warning Lars Ingebrigtsen
2020-08-12 22:23 ` Stefan Kangas
2020-08-13 8:30 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fxJPSh8aG5Q6L63PfrTOkM5nqCfDjpnoAOrDJWaBDBq090bw@mail.gmail.com \
--to=srt19170@gmail.com \
--cc=16117@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.