From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=E5=BC=A0=E4=BA=91=E5=B3=B0?= Newsgroups: gmane.emacs.bugs Subject: bug#60163: 29.0.60; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #) Date: Thu, 22 Dec 2022 10:34:36 +0800 Message-ID: References: <3c9852b8-ba23-71d1-9b00-ff66b26465d3@gmx.at> <4fbc4bd2-898a-bd68-c8a5-c722da4a3e73@gmx.at> <34dfc125-25b2-d84c-356d-dedaabdced85@gmx.at> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000034230a05f06183b4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5565"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60163@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 22 03:35:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p8BQX-0001AL-BU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Dec 2022 03:35:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8BQG-0006wF-5V; Wed, 21 Dec 2022 21:35:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8BQE-0006w6-5i for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 21:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8BQD-00013d-SN for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 21:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p8BQD-0008KL-Ll for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 21:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=E5=BC=A0=E4=BA=91=E5=B3=B0?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Dec 2022 02:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60163 X-GNU-PR-Package: emacs Original-Received: via spool by 60163-submit@debbugs.gnu.org id=B60163.167167649531999 (code B ref 60163); Thu, 22 Dec 2022 02:35:01 +0000 Original-Received: (at 60163) by debbugs.gnu.org; 22 Dec 2022 02:34:55 +0000 Original-Received: from localhost ([127.0.0.1]:55376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8BQ7-0008K3-CH for submit@debbugs.gnu.org; Wed, 21 Dec 2022 21:34:55 -0500 Original-Received: from mail-qk1-f175.google.com ([209.85.222.175]:36694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8BQ4-0008Jx-Oh for 60163@debbugs.gnu.org; Wed, 21 Dec 2022 21:34:53 -0500 Original-Received: by mail-qk1-f175.google.com with SMTP id pj1so272876qkn.3 for <60163@debbugs.gnu.org>; Wed, 21 Dec 2022 18:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V0RxLXqWh5ECsVEBnPv3jzFeuP/Q3NkQXp2/5613QAs=; b=YrREes2WWnoZv7Gvp8y4imOBqWZeawA03W3CxzbdyQkO+38OOC+0sVHE5KEP0e8HQG ZFJ9W/DashyWMwsuOJB1tI9WxzDSGinDKFeIM+1VhIsePCGW0tu2JDfCpwW7xSsko2g4 iqFDtClf5Ky5tOa8i5Xpj+nfcb8ALHWc78+4NDTXVTBqcioTh7X1pWdZgcWSi+wP6Azf /PFq73B96dfdT91TRR/q2LR8IlOcOlfibYMZcU33Ia6XskEnoENtxFJzpipbhcnYEq3e ZmmdDBFk/qldJQMsP/Cudqz6j+YBwKnOTZmlLlAYt4S2oqEND9S80Vfh9KzT1GAqvtHe LExQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V0RxLXqWh5ECsVEBnPv3jzFeuP/Q3NkQXp2/5613QAs=; b=KiUO5ltF857sf1GGameQ/SW8wALyYX4Um514V8zv76EkoCJn0aEOoz1EprfogYW6Lt 0utVVfB4KqUo3UPhVWZVlJNWfu4J+0Zu2q/gDB+O9eFsghv00iX9crD0zZSzpk2GH5dd DLWCcKTl4XrKehfpe1CjrlMZ0tZaLaOt7ih+ujAk5uUVG8tKptI5FjcwTcZe4Xc7dqSI j5k/gKXpwpq6BcNhHBU30AUWFgQhhG1tmpALUPOhAKXT4GizLAFZuIZlQ5AGvaCpdYh2 E2vG3i6z1j8q52Gu7AEIi90k9X8cLAE/OyIQpi/tD8uDn729ebjLeZb4f3jpNv8h+CEe QeNA== X-Gm-Message-State: AFqh2kp2+qPYjTG1HUQl37cE0GJaMpR9teWdRoF2Q12838WPPRAEDRL1 NGxFcBxC6s3oCCRIG+r0z1Z0LtDa6KIZGEgt5e5UJ42mSM1J/lafWS8= X-Google-Smtp-Source: AMrXdXv5rE7lIh0TsGx2u2Td+4steyLgddTTn+KUuaaGIt1/YtVOvdGBoLGwqEqt1q2wUoY8aDrMLp3hazYlyUvmCl4= X-Received: by 2002:a05:620a:110c:b0:6fe:ff77:2f6 with SMTP id o12-20020a05620a110c00b006feff7702f6mr192742qkk.440.1671676487278; Wed, 21 Dec 2022 18:34:47 -0800 (PST) In-Reply-To: <34dfc125-25b2-d84c-356d-dedaabdced85@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251636 Archived-At: --00000000000034230a05f06183b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I tested your patch just now, unfortunately, it doesn't work=E3=80= =82 martin rudalics =E4=BA=8E2022=E5=B9=B412=E6=9C=8822=E6=97= =A5=E5=91=A8=E5=9B=9B 01:06=E5=86=99=E9=81=93=EF=BC=9A > > echo "Please make sure 'clangd' has installed!" > > Sorry, but I don't have clangd installed either. > > But let's try one thing first: IIUC 'winner-save-old-configurations' can > fail in the indicated way only if it tries to insert a dead frame. So > please try with the following trivial patch: > > diff --git a/lisp/winner.el b/lisp/winner.el > index c8354b18be..9fd86ae23f 100644 > --- a/lisp/winner.el > +++ b/lisp/winner.el > @@ -178,7 +178,8 @@ winner-save-old-configurations > (setq winner-last-frames nil) > (setq winner-last-command this-command)) > (dolist (frame winner-modified-list) > - (winner-insert-if-new frame)) > + (when (frame-live-p frame) > + (winner-insert-if-new frame))) > (setq winner-modified-list nil) > (winner-remember))) > > > I doubt it will help much but at least we can exclude one possible > source of troubles. > > martin > --00000000000034230a05f06183b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello, I tested your patch just now, unfortunately, it doe= sn't work=E3=80=82

martin rudalics <rudalics@gmx.at> =E4=BA=8E2022=E5=B9=B412=E6=9C=8822=E6=97=A5=E5= =91=A8=E5=9B=9B 01:06=E5=86=99=E9=81=93=EF=BC=9A
=C2=A0> echo "Please make sure = 9;clangd' has installed!"

Sorry, but I don't have clangd installed either.

But let's try one thing first: IIUC 'winner-save-old-configurations= ' can
fail in the indicated way only if it tries to insert a dead frame.=C2=A0 So=
please try with the following trivial patch:

diff --git a/lisp/winner.el b/lisp/winner.el
index c8354b18be..9fd86ae23f 100644
--- a/lisp/winner.el
+++ b/lisp/winner.el
@@ -178,7 +178,8 @@ winner-save-old-configurations
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq winner-last-frames nil)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq winner-last-command this-command))
=C2=A0 =C2=A0 =C2=A0 (dolist (frame winner-modified-list)
-=C2=A0 =C2=A0 =C2=A0 (winner-insert-if-new frame))
+=C2=A0 =C2=A0 =C2=A0 (when (frame-live-p frame)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (winner-insert-if-new frame)))
=C2=A0 =C2=A0 =C2=A0 (setq winner-modified-list nil)
=C2=A0 =C2=A0 =C2=A0 (winner-remember)))


I doubt it will help much but at least we can exclude one possible
source of troubles.

martin
--00000000000034230a05f06183b4--