From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noah Lavine Newsgroups: gmane.emacs.devel Subject: Re: ldap.el Problem and Solution Date: Mon, 29 Oct 2012 15:49:36 -0400 Message-ID: References: <87bofl5yua.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1351540184 17096 80.91.229.3 (29 Oct 2012 19:49:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2012 19:49:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 29 20:49:51 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TSvLJ-0007NC-Vu for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2012 20:49:50 +0100 Original-Received: from localhost ([::1]:43703 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSvLB-0005l0-P2 for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2012 15:49:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSvL9-0005kk-Hh for emacs-devel@gnu.org; Mon, 29 Oct 2012 15:49:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSvL8-0001W6-Ra for emacs-devel@gnu.org; Mon, 29 Oct 2012 15:49:39 -0400 Original-Received: from mail-ie0-f169.google.com ([209.85.223.169]:65438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSvL7-0001Vq-Hr; Mon, 29 Oct 2012 15:49:37 -0400 Original-Received: by mail-ie0-f169.google.com with SMTP id 10so8869285ied.0 for ; Mon, 29 Oct 2012 12:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=6Qozeaa+7NWr+3mpg5laRuwuj2T7dJcnsMb2Tnut1nk=; b=t4l0+74LgZHFgEqzCieqbtWFKGrray0JslFBfXbTE4cwOfbLK2bxbY03HP045uGJWa EDbmdBdVYVW2KMcDfF5CHW2aFeZ4duW93cQLUt7dAZ/yaWeDJv8VECy9VpwXr40FPaZS Ut4LSs+ZWg0wYu/uLG599eBJ3T/XqWjlA/h+XfoqGoXU73t0XrWO8BXJY5YjI9axb1AO r+JTzIMrqVtcryTx38vEBC0s7lyswoCDAzgpfysKFZy+TDUpHDXTUwnDa2SghAPqlwMs eKbSFKNHxk5X2FshTlBusa4JkHewCj2xodSqDSq1QwsxZkd4TN8oI2MdZOElZZIfGpP7 PgLg== Original-Received: by 10.50.33.232 with SMTP id u8mr10556770igi.39.1351540176988; Mon, 29 Oct 2012 12:49:36 -0700 (PDT) Original-Received: by 10.64.138.99 with HTTP; Mon, 29 Oct 2012 12:49:36 -0700 (PDT) In-Reply-To: <87bofl5yua.fsf@gnu.org> X-Google-Sender-Auth: k09Dm_FUCXvNyW2y5ypwM0GdVnI X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.223.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154574 Archived-At: You're right; line 579 makes no sense. Stefan already installed the fix at line 607 of ldap.el, where it belongs, so I don't think a patch would be useful here; but in the future I will try to make sure that I provide a patch against the trunk. Thanks, Noah On Mon, Oct 29, 2012 at 6:58 AM, Chong Yidong wrote: > Noah Lavine writes: > >> The solution is to insert this after line 579 of ldap.el: >> >> (if (looking-at "version:") >> (forward-line 1)) >> >> I have tested this, and it seems to work for me. > > Please send a patch, preferably against current trunk. Line 579 of > ldap.el, on trunk, doesn't seem to be the spot you intended.