From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?J=E9r=E9my_Compostella?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] window.el: Remove mark saving and restoring Date: Thu, 19 Jan 2012 15:37:35 +0100 Message-ID: References: <8739bbvlui.fsf@Apollo.jerryland.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8f6428e09eb17e04b6e2828b X-Trace: dough.gmane.org 1326983902 22741 80.91.229.12 (19 Jan 2012 14:38:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 19 Jan 2012 14:38:22 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 19 15:38:17 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rnt83-0002xT-Gj for ged-emacs-devel@m.gmane.org; Thu, 19 Jan 2012 15:38:15 +0100 Original-Received: from localhost ([::1]:49317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rnt81-0001nv-QU for ged-emacs-devel@m.gmane.org; Thu, 19 Jan 2012 09:38:13 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:36226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rnt7q-0001no-Sa for emacs-devel@gnu.org; Thu, 19 Jan 2012 09:38:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rnt7m-0000CM-3n for emacs-devel@gnu.org; Thu, 19 Jan 2012 09:38:02 -0500 Original-Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:42118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rnt7l-0000CC-J7 for emacs-devel@gnu.org; Thu, 19 Jan 2012 09:37:57 -0500 Original-Received: by obbta7 with SMTP id ta7so6925059obb.0 for ; Thu, 19 Jan 2012 06:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=CG8Cdgqdfz36EaZArNvdLxS16mjOjvkgyHTMK0O2U48=; b=XTBXD7pChm2F3htjLOiVnOgwxBa55j3OjJARMlt0J4MAMgwc3QYOXd0UkQtoSsQUhl uhXfPe0WNsaAmYwBDA7jNBehSvj4DcHtK/qKsvy6I3g6Kd7rNXvGhVq3hE8u24u70jzY oVkyRJO85rQxyaqZ9N4sOGBPhkP4jkK/jSjHM= Original-Received: by 10.182.179.70 with SMTP id de6mr23030672obc.22.1326983877144; Thu, 19 Jan 2012 06:37:57 -0800 (PST) Original-Received: by 10.60.49.103 with HTTP; Thu, 19 Jan 2012 06:37:35 -0800 (PST) In-Reply-To: <8739bbvlui.fsf@Apollo.jerryland.fr> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147730 Archived-At: --e89a8f6428e09eb17e04b6e2828b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sorry, but don't read this thread. I should look at it more carefully before ;) 2012/1/19 J=E9r=E9my Compostella > All, > > Working on the "desktop.el: Add frames and windows configuration > save&restore" thread I'm trying to use the `window-state-get' and > `window-state-put' functions. I got a bad behavior. Indeed when I > restore a window from its previous state, the mark is modified and > activated. As long as I know, mark is buffer related and not window > related so we don't have to save and restore it here. The author himself > commented this code part with : > > ;; I'm not sure whether we should set the mark here, but maybe > ;; it can be used. > > I propose the attached patch which removes the mark save&restore part. > > Regards, > > J=E9r=E9my > > --e89a8f6428e09eb17e04b6e2828b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sorry, but don't read this thread. I should look at it more carefully b= efore ;)

2012/1/19 J=E9r=E9my Compostella= <jere= my.compostella@gmail.com>
All,

Working on the "desktop.el: Add frames and windows configuration
save&restore" thread I'm trying to use the `window-state-get&#= 39; and
`window-state-put' functions. I got a bad behavior. Indeed when I
restore a window from its previous state, the mark is modified and
activated. As long as I know, mark is buffer related and not window
related so we don't have to save and restore it here. The author himsel= f
commented this code part with :

;; I'm not sure whether we should set the mark here, but maybe
;; it can be used.

I propose the attached patch which removes the mark save&restore part.<= br>
Regards,

J=E9r=E9my


--e89a8f6428e09eb17e04b6e2828b--