all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jérémy Compostella" <jeremy.compostella@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Sylvain Rousseau <thisirs@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation
Date: Sat, 21 Jan 2012 11:05:26 +0100	[thread overview]
Message-ID: <CA+TATJEsh=N8Pz=DStqixTQhH2D+054JRsmwUeeJfHQT7+06og@mail.gmail.com> (raw)
In-Reply-To: <CA+TATJFnL_G6j7ZOToKSndezWghqo9pfqtoLJgqvZR3D4KgOxA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 994 bytes --]

As we agreed about the solution, could you please merge this patch ?
This bug is really annoying to me and probably to many others.

Thanks.

Jérémy

2012/1/20 Jérémy Compostella <jeremy.compostella@gmail.com>

> 2012/1/20 martin rudalics <rudalics@gmx.at>
>
>> > Effectively the issue is only windmove.el related.
>>
>> So IIUC the issue is that `windmove-reference-loc'
>>
>>          (windmove-coord-add
>>             top-left
>>             (let ((col-row
>>                    (posn-col-row
>>                     (posn-at-point (window-point window) window))))
>>               (cons (- (car col-row) (window-hscroll window))
>>                     (cdr col-row)))))))))
>>
>> wrongly subtracts the value returned by `window-hscroll' from a column
>> value correctly calculated by `posn-at-point' (window_box_left_offset)?
>>
>> Yes, you're perfectly right that's my point and my patch remove this.
> Thanks.
>
>  It's time to friday beer evening now :)
>

[-- Attachment #2: Type: text/html, Size: 1652 bytes --]

  reply	other threads:[~2012-01-21 10:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 21:57 [PATCH] windmove.el: Fix windmove-reference-loc miscalculation Jérémy Compostella
2012-01-20 10:01 ` martin rudalics
2012-01-20 16:16   ` Sylvain Rousseau
2012-01-20 16:55     ` Jérémy Compostella
2012-01-20 18:07       ` martin rudalics
2012-01-20 18:14         ` Jérémy Compostella
2012-01-21 10:05           ` Jérémy Compostella [this message]
2012-01-21 10:13             ` martin rudalics
2012-01-20 18:07     ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+TATJEsh=N8Pz=DStqixTQhH2D+054JRsmwUeeJfHQT7+06og@mail.gmail.com' \
    --to=jeremy.compostella@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    --cc=thisirs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.