From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type Date: Fri, 22 Dec 2017 19:02:31 +0530 Message-ID: References: <20171220063930.19227-1-vibhavp@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1513949523 12473 195.159.176.226 (22 Dec 2017 13:32:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Dec 2017 13:32:03 +0000 (UTC) To: Philipp Stephani , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 22 14:31:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSNQX-0002X5-Gz for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2017 14:31:53 +0100 Original-Received: from localhost ([::1]:50649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSNSW-00083G-1a for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2017 08:33:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSNRa-00081k-46 for emacs-devel@gnu.org; Fri, 22 Dec 2017 08:32:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSNRW-0000l7-Ao for emacs-devel@gnu.org; Fri, 22 Dec 2017 08:32:58 -0500 Original-Received: from mail-yw0-x243.google.com ([2607:f8b0:4002:c05::243]:39036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eSNRW-0000kV-4q for emacs-devel@gnu.org; Fri, 22 Dec 2017 08:32:54 -0500 Original-Received: by mail-yw0-x243.google.com with SMTP id q26so4107931ywa.6 for ; Fri, 22 Dec 2017 05:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=kSwjJ0L+y94KTaI7o3Tyo8n9A6/3q0yLpyw/pdurkvw=; b=YLErrxPWdtOdsXWIiIk2BC1FE5hgAFyVmmkvYNcByGALpk6NGVZFoFgTNHQcIHijGY FE/q0YBXxTpT0peRMeTK07cAn5wJswrRk5ozm2KpRkK4iadN8ssSafipdrS6FOR4EW2K p/kc/pX/cLi3Yv8Gn16w0KMzxNySK4W5rg+iC7EI0J0F6DviLuBdyw98JVVrww2Ab6Q8 3iaCbP+7U60t/ry7y99rA9Zc9mo/Zne8vaWWB8JIiSRB2SbMDbmgmcroFHw3rYSGM72x piAguTbtV0JksM6G2jC+a3UuU2L14cjfbqSq7AUPa+JQGb/1oqfaESHVqH6AvlrNYv+b FMzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=kSwjJ0L+y94KTaI7o3Tyo8n9A6/3q0yLpyw/pdurkvw=; b=mbEC3IV8Ta/waWvvtMe1oZJwQzNY+R8PhFeM8gfkiKRPNBSHYmf7GSb8lUSKGTn4H0 anl5oMNM9v7fIcVgbKOAf0d3Ap4J76f4H4VCmHH+jV4UP9pDt9AcUIVVSdidg/CUT/GG pqLLSLFOMD9bj+T+cq26P/ZKGbOIftdZ4q6ZuL/G8Xtw/GKpbdMBV06k3RF30Pk+pu3v N9jd+PwJ8N0iOaetQGnMzETclrKRt80f/2MLcjJyWELqAwiZEbaP7yffIbtztgVCM+aQ gvrfhbWTWiwdy0A+Q2sWeuR2FDPzf8k6nTvJtg9EE5B4OJT42R02+8/D3/ymzhAX1IK+ azvA== X-Gm-Message-State: AKGB3mLtv1M/EGVqC/uOTIm11lPUW9RIwXBTCnSQuPst9KNzQdTiFktV OmEkjCTxKXT8xkCE/yffnfloEvmMJe7IFUw9kVs= X-Google-Smtp-Source: ACJfBosOWX1TRXjjaxCrCFR1/A2MqQKaddz79NhWLrel5h3y2EYvKd54CBcWbtINd76gEO2c3JrAmk3XM5Lt1Z1Ehog= X-Received: by 10.129.71.7 with SMTP id u7mr10235811ywa.145.1513949572426; Fri, 22 Dec 2017 05:32:52 -0800 (PST) Original-Received: by 10.129.153.84 with HTTP; Fri, 22 Dec 2017 05:32:31 -0800 (PST) In-Reply-To: <20171220063930.19227-1-vibhavp@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221333 Archived-At: On Wed, Dec 20, 2017 at 12:09 PM, Vibhav Pant wrote: > * src/fns.c (get_key_arg): Make function non-static. > > * src/lisp.h: Add extern declaration for get_key_arg. > > * src/json.c (json_parse_object_type): Use get_key_arg to get the > value of `:object-type'. Friendly ping, any feedback on this patch? I plan to submit another patch to json.c, which makes use of this one. -- Vibhav Pant vibhavp@gmail.com