From: Vibhav Pant <vibhavp@gmail.com>
To: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: [PATCH] unsafep: Add support for (funcall)
Date: Tue, 28 Feb 2017 00:23:00 +0530 [thread overview]
Message-ID: <CA+T2Sh0yh4BR-=vCpnjZ0s7GOkut_AMqros8R6ULRSZMU11+xg@mail.gmail.com> (raw)
The following patch makes (unsafep) check funcall forms. Right now,
it only works while calling side-effect-free functions like car and cdr.
In the future, I'd like to extend this to add support for looking up and
checking (symbol-function) for other functions too.
Would appreciate some feedback before I push this.
Thanks,
Vibhav
--
Vibhav Pant
vibhavp@gmail.com
diff --git a/lisp/emacs-lisp/unsafep.el b/lisp/emacs-lisp/unsafep.el
index 1ab65a044e..beba6895b8 100644
--- a/lisp/emacs-lisp/unsafep.el
+++ b/lisp/emacs-lisp/unsafep.el
@@ -205,6 +205,12 @@ unsafep
((eq fun '\`)
;; Backquoted form - safe if its expansion is.
(unsafep (cdr (backquote-process (cadr form)))))
+ ((eq fun 'funcall)
+ (let ((func (nth 1 form))
+ (args (nthcdr 2 form)))
+ (if (eq (car-safe func) 'quote)
+ (unsafep (cons (eval func) args) unsafep-vars)
+ (setq reason `(function ,func)))))
(t
;;First unsafep-function call above wasn't nil, no special case applies
reason)))))
next reply other threads:[~2017-02-27 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 18:53 Vibhav Pant [this message]
2017-02-27 20:56 ` [PATCH] unsafep: Add support for (funcall) Stefan Monnier
2017-02-28 15:40 ` Vibhav Pant
2017-02-28 16:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+T2Sh0yh4BR-=vCpnjZ0s7GOkut_AMqros8R6ULRSZMU11+xg@mail.gmail.com' \
--to=vibhavp@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.