bug#19327: 24.4.51; Wrong advice class reported

bug#19327: 24.4.51; Wrong advice class reported

[Ivan Andrus]

[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]

Starting from emacs -Q, evaluate the following:

(defadvice save-buffers-kill-emacs
    (before allow-elnode-to-die-when-quitting activate)
  (set-process-query-on-exit-flag
   (cdr-safe (assoc 8314 elnode-server-socket)) nil))

Then C-h f save-buffers-kill-emacs RET.  The results I get have the
following line:

    :around advice: `ad-Advice-save-buffers-kill-emacs'

Notice that the advice was defined as before advice (and errors if
`ad-do-it' is used), but is reported as :around advice.

-Ivan


Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Undo!
Quit
save-buffers-kill-emacs
<C-tab> is undefined [2 times]

s-\ is undefined
toggle-input-method: Recursive use of `toggle-input-method'
Quit
Undo!
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils help-mode easymenu advice help-fns time-date
tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list
newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp
files text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
cocoa ns multi-tty emacs)

Memory information:
((conses 16 74709 7163)
(symbols 48 18001 0)
(miscs 40 57 299)
(strings 32 10711 4417)
(string-bytes 1 288430)
(vectors 16 9505)
(vector-slots 8 387032 7040)
(floats 8 57 405)
(intervals 56 278 24)
(buffers 960 13))

[-- Attachment #2: Type: text/html, Size: 9165 bytes --]

bug#19327: 24.4.51; Wrong advice class reported

[Stefan Monnier]

tags 19327 notabug
thanks

> (defadvice save-buffers-kill-emacs
>     (before allow-elnode-to-die-when-quitting activate)
[...]
> Then C-h f save-buffers-kill-emacs RET.  The results I get have the
> following line:

>     :around advice: `ad-Advice-save-buffers-kill-emacs'

It doesn't talk about your `allow-elnode-to-die-when-quitting' advice.
Instead it talks about a general advice used to implement the interface
between old-style advice and new-style advice.  If you click on that
link it should give you the information about your particular advice.


        Stefan

bug#19327: Mark at #19327 as done since it's not a bug

[Ivan Andrus]

tag 19327 done
thanks

bug#19327: Mark at #19327 as done since it's not a bug

[Ivan Andrus]

close 19327 25.1
thanks