From: Robert Weiner <rsw@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Lifting all buffer restrictions in indentation functions
Date: Fri, 8 Dec 2017 12:38:33 -0500 [thread overview]
Message-ID: <CA+OMD9jk-M6N=DJ+tfrSuS8dRtCOtzTBSMgS20nQ=uOmAFUB5Q@mail.gmail.com> (raw)
In-Reply-To: <83wp1xupqs.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Fri, Dec 8, 2017 at 11:51 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> Hi, Emacs.
>
> The widen-less branch proposes to have indent-according-to-mode,
> indent-for-tab-command, and indent-region call 'widen' before calling
> indent-line-function. This call is unconditional,
You don't say in your message but I would assume that
a save-restriction is used automatically within these
tab commands so that after the indent command, the
restriction is restored and there is no need for callers
to wrap indent functions within a save-restriction.
So after these two calls:
>
>
>
> (narrow-to-region START END)
>
> (indent-for-tab-command)
the narrowed region would be nearly the same (except
for changes made by the tab command). Is that correct?
If that is the case, then this seems much less problematic
than if it is not and I would defer to Stefan's thinking.
Bob
[-- Attachment #2: Type: text/html, Size: 2927 bytes --]
next prev parent reply other threads:[~2017-12-08 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 16:51 Lifting all buffer restrictions in indentation functions Eli Zaretskii
2017-12-08 17:03 ` Stefan Monnier
2017-12-08 20:02 ` Eli Zaretskii
2017-12-08 20:47 ` Stefan Monnier
2017-12-09 8:24 ` Eli Zaretskii
2017-12-09 15:19 ` Stefan Monnier
2017-12-08 17:38 ` Robert Weiner [this message]
2017-12-08 17:50 ` Stefan Monnier
2017-12-08 22:40 ` Stephen Leake
2017-12-08 22:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+OMD9jk-M6N=DJ+tfrSuS8dRtCOtzTBSMgS20nQ=uOmAFUB5Q@mail.gmail.com' \
--to=rsw@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rswgnu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.