From: Robert Weiner <rsw@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Tom Tromey <tromey@redhat.com>,
23607@debbugs.gnu.org, Daniel Hackney <dan@haxney.org>
Subject: bug#23607: Please apply this patched function to package.el in Emacs 25.
Date: Thu, 21 Jul 2016 11:47:49 -0400 [thread overview]
Message-ID: <CA+OMD9jFNiCQo+UCho-BBRhdWCvdMa=iPQCypHFOfF3VfkHpJA@mail.gmail.com> (raw)
In-Reply-To: <jwv7fcf3fz3.fsf-monnier+bug#23607@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2195 bytes --]
On Wed, Jul 20, 2016 at 10:05 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
>> Replacing this function in package.el allows for correct generation of
the
>> <package>-autoloads.el file for packages that have .el files in multiple
>> subdirectories.
>
> FWIW, I think this will break the dash package which includes
> a dev/ert.el file with autoload cookies in it and those shouldn't be
> placed into the dash-autoloads.el file.
>
>
> Stefan
>
>
> PS: Please send it as a patch so we can see what changed without having
> to try and guess.
Here is the patch. -- Bob
*** package-orig.el 2016-05-17 12:16:33.000000000 -0400
--- package.el 2016-06-15 14:43:46.000000000 -0400
***************
*** 916,928 ****
(backup-inhibited t)
(version-control 'never))
(package-autoload-ensure-default-file generated-autoload-file)
! (update-directory-autoloads pkg-dir)
(let ((buf (find-buffer-visiting generated-autoload-file)))
(when buf (kill-buffer buf)))
auto-name))
(defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
"Generate autoloads, description file, etc.. for PKG-DESC installed at
PKG-DIR."
(package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
(let ((desc-file (expand-file-name (package--description-file pkg-dir)
pkg-dir)))
--- 913,929 ----
(backup-inhibited t)
(version-control 'never))
(package-autoload-ensure-default-file generated-autoload-file)
! (apply #'update-directory-autoloads pkg-dir
! (delq nil (mapcar (lambda (f) (and (file-directory-p f)
! (not (file-symlink-p f))
! f))
! (directory-files pkg-dir t "[a-zA-Z].*" nil))))
(let ((buf (find-buffer-visiting generated-autoload-file)))
(when buf (kill-buffer buf)))
auto-name))
(defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
"Generate autoloads, description file, etc.. for PKG-DESC installed at
PKG-DIR."
(package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
(let ((desc-file (expand-file-name (package--description-file pkg-dir)
pkg-dir)))
[-- Attachment #2: Type: text/html, Size: 2687 bytes --]
prev parent reply other threads:[~2016-07-21 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 23:11 Please apply this patched function to package.el in Emacs 25 Robert Weiner
2016-07-21 2:05 ` bug#23607: " Stefan Monnier
2016-07-21 3:50 ` Clément Pit--Claudel
2016-07-21 4:40 ` Stefan Monnier
2016-07-21 5:02 ` Clément Pit--Claudel
2016-07-24 15:58 ` Phillip Lord
2020-09-15 15:56 ` Lars Ingebrigtsen
2016-07-21 15:47 ` Robert Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+OMD9jFNiCQo+UCho-BBRhdWCvdMa=iPQCypHFOfF3VfkHpJA@mail.gmail.com' \
--to=rsw@gnu.org \
--cc=23607@debbugs.gnu.org \
--cc=dan@haxney.org \
--cc=monnier@iro.umontreal.ca \
--cc=rswgnu@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.