From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Weiner Newsgroups: gmane.emacs.bugs Subject: bug#23985: Emacs 25.0.94: FEATURE ADDITION: Texinfo environment movement commands Date: Thu, 14 Jul 2016 15:43:44 -0400 Message-ID: References: <83poqg6n8l.fsf@gnu.org> Reply-To: rswgnu@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1468525536 7146 80.91.229.3 (14 Jul 2016 19:45:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Jul 2016 19:45:36 +0000 (UTC) Cc: 23985@debbugs.gnu.org, bug-texinfo@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 14 21:45:24 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNmZV-0007jl-L9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jul 2016 21:45:21 +0200 Original-Received: from localhost ([::1]:56535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNmZU-0006AE-Px for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jul 2016 15:45:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNmZH-00067N-J9 for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2016 15:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNmZC-0002Vm-La for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2016 15:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNmZC-0002Vh-Is for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2016 15:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bNmZC-0004lt-Eg for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2016 15:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Weiner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2016 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23985-submit@debbugs.gnu.org id=B23985.146852546718282 (code B ref 23985); Thu, 14 Jul 2016 19:45:02 +0000 Original-Received: (at 23985) by debbugs.gnu.org; 14 Jul 2016 19:44:27 +0000 Original-Received: from localhost ([127.0.0.1]:51789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNmYd-0004kn-Fm for submit@debbugs.gnu.org; Thu, 14 Jul 2016 15:44:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNmYc-0004kb-H8 for 23985@debbugs.gnu.org; Thu, 14 Jul 2016 15:44:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNmYS-0002Ib-DP for 23985@debbugs.gnu.org; Thu, 14 Jul 2016 15:44:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNmYS-0002IO-9t for 23985@debbugs.gnu.org; Thu, 14 Jul 2016 15:44:16 -0400 Original-Received: from mail-oi0-f47.google.com ([209.85.218.47]:35759) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bNmYQ-0000qP-S9 for 23985@debbugs.gnu.org; Thu, 14 Jul 2016 15:44:14 -0400 Original-Received: by mail-oi0-f47.google.com with SMTP id r2so132741809oih.2 for <23985@debbugs.gnu.org>; Thu, 14 Jul 2016 12:44:14 -0700 (PDT) X-Gm-Message-State: ALyK8tJUuRMIpWez7rJ7NF6ga3MnYldbW27qgSwwk1a0dkJU/BAs2+nogGh+YdCrudZMiouDzmAaLRKRIb4PeA== X-Received: by 10.202.235.23 with SMTP id j23mr6230802oih.192.1468525453941; Thu, 14 Jul 2016 12:44:13 -0700 (PDT) Original-Received: by 10.202.199.143 with HTTP; Thu, 14 Jul 2016 12:43:44 -0700 (PDT) In-Reply-To: <83poqg6n8l.fsf@gnu.org> X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121092 Archived-At: On Thu, Jul 14, 2016 at 3:19 PM, Eli Zaretskii wrote: > Thanks. Allow me a few comments. Thanks for the feedback. > >> + ;;; Texinfo environment, e.g. @table, movement commands >> + ;; Author: Bob Weiner , Orig-Date: 7/14/2016 >> + ;; Copyright (C) 2016 Free Software Foundation, Inc. > > We don't put such comments into the code, the log entry and AUTHORS > serve this purpose. I just put that in there for the reference of whoever actually patches the Emacs sources, not to be kept in there. > >> + (defun texinfo-to-environment-bounds () >> + "If within a Texinfo environment with an @end, move point first to its starting line and then to its ending line. > > The first line of a doc string should not be wider than 67 characters, > certainly not more than 78, and it should still be a complete sentence > that summarizes what the function does. It is a sentence and I always make the first line of a doc string stand alone but often the complexity makes these first lines long. I then wrap further lines at 78 or less. I will keep this advice in mind but will no doubt find it hard to be clear and complete with in such a short space. > >> + Do nothing when outside of an environment; this does not handle nested environments." > > Other lines should also be broken at character 70. Is that really done throughout Emacs? With today's wider screens, I would think some relaxation would be permitted. > I think these additions should be also reflected in NEWS. Yes. Bob