all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Weiner <rsw@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23985@debbugs.gnu.org, bug-texinfo@gnu.org
Subject: bug#23985: Emacs 25.0.94: FEATURE ADDITION: Texinfo environment movement commands
Date: Thu, 14 Jul 2016 15:43:44 -0400	[thread overview]
Message-ID: <CA+OMD9j0WEkaNfJLUCVgRV-5EG=gG=3TXzJgnC57kd4KxfAn=A__40288.8725781397$1468525536$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <83poqg6n8l.fsf@gnu.org>

On Thu, Jul 14, 2016 at 3:19 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> Thanks.  Allow me a few comments.

Thanks for the feedback.

>
>> + ;;; Texinfo environment, e.g. @table, movement commands
>> + ;; Author: Bob Weiner <rsw@gnu.org>, Orig-Date: 7/14/2016
>> + ;; Copyright (C) 2016  Free Software Foundation, Inc.

>
> We don't put such comments into the code, the log entry and AUTHORS
> serve this purpose.

I just put that in there for the reference of whoever actually patches
the Emacs sources, not to be kept in there.

>
>> + (defun texinfo-to-environment-bounds ()
>> +   "If within a Texinfo environment with an @end, move point first to its starting line and then to its ending line.
>
> The first line of a doc string should not be wider than 67 characters,
> certainly not more than 78, and it should still be a complete sentence
> that summarizes what the function does.

It is a sentence and I always make the first line of a doc string
stand alone but often the complexity makes these first lines long.
I then wrap further lines at 78 or less.  I will keep this advice in
mind but will no doubt find it hard to be clear and complete with
in such a short space.

>
>> + Do nothing when outside of an environment; this does not handle nested environments."
>
> Other lines should also be broken at character 70.

Is that really done throughout Emacs?  With today's wider screens, I
would think some relaxation would be permitted.

> I think these additions should be also reflected in NEWS.

Yes.

Bob





  parent reply	other threads:[~2016-07-14 19:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 16:19 bug#23985: Emacs 25.0.94: FEATURE ADDITION: Texinfo environment movement commands Robert Weiner
2016-07-14 16:52 ` Clément Pit--Claudel
2016-07-14 19:19 ` Eli Zaretskii
     [not found] ` <83poqg6n8l.fsf@gnu.org>
2016-07-14 19:43   ` Robert Weiner [this message]
     [not found]   ` <CA+OMD9j0WEkaNfJLUCVgRV-5EG=gG=3TXzJgnC57kd4KxfAn=A@mail.gmail.com>
2016-07-14 20:15     ` Clément Pit--Claudel
2016-07-15  7:01     ` Eli Zaretskii
2020-08-11 14:38 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+OMD9j0WEkaNfJLUCVgRV-5EG=gG=3TXzJgnC57kd4KxfAn=A__40288.8725781397$1468525536$gmane$org@mail.gmail.com' \
    --to=rsw@gnu.org \
    --cc=23985@debbugs.gnu.org \
    --cc=bug-texinfo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=rswgnu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.