all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Weiner <rsw@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Richard Stallman <rms@gnu.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions
Date: Sat, 18 Jun 2016 13:50:23 -0400	[thread overview]
Message-ID: <CA+OMD9h3oQLj6-p2vWEsvg0QA3_QFWMMQAVXPNrHmqxmLtZUkQ@mail.gmail.com> (raw)
In-Reply-To: <83lh229ywc.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

On Sat, Jun 18, 2016 at 1:42 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> I see that you consider this a regression.  But the change you refer
> to was in Emacs 22.1, released 9 years ago, so we've lived with this
> long enough to consider your proposal a new feature.


Well, we just fixed a 20-year-old documentation bug on markers from some
prior discussion, but I see why you might want to view it that way.  If the
behavior is a bug, no matter how long-standing, it should certainly be
given some standing above a regular new feature request.  Maybe RMS could
comment on whether sort-lines by design should sort only visible lines,
e.g. when some are hidden in outlines, or should sort all lines regardless
of visibility.

  I also think
> that your proposed change goes farther than just restoring that old
> behavior, because outline and its derivatives are not the only modes
> that use invisible text.
>

Can you provide one example where this patch changes the behavior of line
sorting in a negative way?  That would help to understand your thinking.  I
have provided the example of where it improves it.

This should be simple to resolve by just getting to the bottom of what the
function is designed to do in the case of invisible lines.

Bob

[-- Attachment #2: Type: text/html, Size: 1796 bytes --]

  reply	other threads:[~2016-06-18 17:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-18 17:01 Emacs bug #23794; sort-line behavior regressed from prior Emacs versions Robert Weiner
2016-06-18 17:26 ` Eli Zaretskii
2016-06-18 17:42   ` Eli Zaretskii
2016-06-18 17:50     ` Robert Weiner [this message]
2016-06-18 18:15       ` Eli Zaretskii
2016-06-18 18:22         ` Stefan Monnier
2016-06-18 18:28           ` Eli Zaretskii
2016-06-18 18:37             ` Robert Weiner
2016-06-18 18:31         ` Robert Weiner
2016-06-18 21:28           ` Drew Adams
2016-06-18 22:41             ` Robert Weiner
2016-06-19  2:39             ` Eli Zaretskii
2016-06-19 13:31               ` Robert Weiner
2016-06-19 15:18                 ` Eli Zaretskii
2016-06-19 16:12                   ` Robert Weiner
2016-06-19 16:30                     ` Eli Zaretskii
2016-06-19 16:51                       ` bug#23794: " Robert Weiner
2016-06-19 16:55                         ` Eli Zaretskii
2016-06-19 17:03                           ` bug#23794: " Robert Weiner
2016-06-19 17:03                           ` Robert Weiner
2016-06-19 16:55                         ` bug#23794: " Eli Zaretskii
2016-06-19 20:59                         ` Drew Adams
2016-06-19 20:59                         ` bug#23794: " Drew Adams
2016-06-20  0:55                         ` Stefan Monnier
2016-06-19 18:16                       ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+OMD9h3oQLj6-p2vWEsvg0QA3_QFWMMQAVXPNrHmqxmLtZUkQ@mail.gmail.com \
    --to=rsw@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    --cc=rswgnu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.