From: Robert Weiner <rsw@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Richard Stallman <rms@gnu.org>,
Drew Adams <drew.adams@oracle.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions
Date: Sun, 19 Jun 2016 12:12:12 -0400 [thread overview]
Message-ID: <CA+OMD9gB=y6Uo3Sh3HCJNEhJ2jx-8Y8pE35KCPR=7FbEX-SGCA@mail.gmail.com> (raw)
In-Reply-To: <83vb158awq.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
On Sun, Jun 19, 2016 at 11:18 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> As I wrote, I'd very much prefer a solution that only affects
> outline-mode and its descendants. In those modes, ignoring invisible
> lines could be the default behavior. I think we should also provide a
> defcustom to make sort-lines behave in outline modes as it does today,
> because, although I agree that the current behavior makes less sense
> in those modes, it's nonetheless a valid use case that we should not
> disallow completely.
>
> As for modes that are not descendants of outline-mode, the default
> should IMO stay as it is now. Whether we want an option to make
> sort-lines disregard invisible text in those other modes is something
> I have no opinion about, and won't object if patches to that effect
> are submitted.
>
This is a much clearer statement of your thinking. Thanks, it is helpful.
It sounds like you are suggesting that sort-lines have an internal
conditional check for whether an outline mode is active in the buffer to be
sorted (rather than suggesting a separate outline-sort-lines function),
correct?
So I will try for a patch that leaves the default behavior of sort-lines
the same unless an outline-mode or descendant is active in which case the
default will be to group invisible lines with visible ones. There will be
a way to override the default behavior with the other behavior (not
grouping invisible lines with visible ones and treating them as separate
lines for sorting). How does that sound?
I have already fixed this issue for Hyperbole, so I hereby retract the
request that it be made a blocking issue for 25.1.
Bob
[-- Attachment #2: Type: text/html, Size: 2099 bytes --]
next prev parent reply other threads:[~2016-06-19 16:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 17:01 Emacs bug #23794; sort-line behavior regressed from prior Emacs versions Robert Weiner
2016-06-18 17:26 ` Eli Zaretskii
2016-06-18 17:42 ` Eli Zaretskii
2016-06-18 17:50 ` Robert Weiner
2016-06-18 18:15 ` Eli Zaretskii
2016-06-18 18:22 ` Stefan Monnier
2016-06-18 18:28 ` Eli Zaretskii
2016-06-18 18:37 ` Robert Weiner
2016-06-18 18:31 ` Robert Weiner
2016-06-18 21:28 ` Drew Adams
2016-06-18 22:41 ` Robert Weiner
2016-06-19 2:39 ` Eli Zaretskii
2016-06-19 13:31 ` Robert Weiner
2016-06-19 15:18 ` Eli Zaretskii
2016-06-19 16:12 ` Robert Weiner [this message]
2016-06-19 16:30 ` Eli Zaretskii
2016-06-19 16:51 ` bug#23794: " Robert Weiner
2016-06-19 16:55 ` Eli Zaretskii
2016-06-19 17:03 ` Robert Weiner
2016-06-19 17:03 ` bug#23794: " Robert Weiner
2016-06-19 16:55 ` Eli Zaretskii
2016-06-19 20:59 ` Drew Adams
2016-06-19 20:59 ` bug#23794: " Drew Adams
2016-06-20 0:55 ` Stefan Monnier
2016-06-19 18:16 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+OMD9gB=y6Uo3Sh3HCJNEhJ2jx-8Y8pE35KCPR=7FbEX-SGCA@mail.gmail.com' \
--to=rsw@gnu.org \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=rswgnu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.