From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Fri, 27 Jan 2023 01:19:46 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c61bfe05f338dac5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 27 07:20:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLI6K-0003KO-3g for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Jan 2023 07:20:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLI5i-0007MI-Bx; Fri, 27 Jan 2023 01:20:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLI5h-0007Le-Gf for emacs-devel@gnu.org; Fri, 27 Jan 2023 01:20:01 -0500 Original-Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLI5f-00071W-Bq for emacs-devel@gnu.org; Fri, 27 Jan 2023 01:20:00 -0500 Original-Received: by mail-yb1-xb2f.google.com with SMTP id x4so4844028ybp.1 for ; Thu, 26 Jan 2023 22:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=A5FP4gpAhSFwOb1hVQ5a8dSclTvtG/qy5bxGXA4+ZZ8=; b=HKa+mH1cZoxgmljTIHi1vjdbFjSCLmpKTLSbpU47psBbNpb0EAM1k4VPXT1xnf1u6S DCyEsaBWfzmg8r1KQ1qy+HNy2/J76gkBPdH3bYSOUoDIHTO/f8F51knQQ2CLdUgh+zuS gvLkCZynZfo+xwNGzZARTIIT5fZ/6uGWU2ps5wXvpW53VXWxCgA3LC3/kXzY8y6JttZq oUkdCEMdhosxwnFQIO9522A8CgZkzX8zCrVA+zu6WrZ4PaM6aCuRuW5/91NnZNN0n1Qr BFdCF8jqBTbglatm7gOEOhEDx+108veJEsyLMYGWDrfz4IALRfxkOar/wxuXQhYKhyHB A8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A5FP4gpAhSFwOb1hVQ5a8dSclTvtG/qy5bxGXA4+ZZ8=; b=HNFRXV2h7IVedWbgrb5EtooSRDNT0+xzpVQxOFf+GrKOR12BJDFpHrnoPZ7fmAkiKu G2Zt8HkHzX/hspjy7SLE98seknt76jciPdJodOm3/SaZB0qEhorKgITXKAwpp2+aYm69 V6A1XCv/7CFoW1xDuVIOxkYHyAZF8/yR3iwtGv/IaJe01QGRVcHkLyJZdBCc/p++hocL i7OimaM24Sp2lAdIKm1SqmpNH2a+kWDU4976dSNUtx/caQ3TQ3jP+1fDklrN+AFiVA9m UQ9b6DmBpNefwNHuu3kByC4qO47gSMqcMXn3SjUSe705FC7ctQ3MPfj/NZUTBU11c/7J AVtQ== X-Gm-Message-State: AFqh2kqZ3PymeA8qoKHdXwQPhV/cHQeMkeKSok4KthUU1zuQHN5zn+6Q B5LqsQZSr1S98hR3E3KE4PcXRg95lOgf26U/iUKS6dgcqxE= X-Google-Smtp-Source: AMrXdXtyom+sUxz1AzDiHJalkwn/kb0PTcyxtrdWY9mUhCBOAcfp+ltt+u6HaF9XifD2Mr2O8Y1LUJ9HcBkojBgxiJ0= X-Received: by 2002:a25:dd44:0:b0:797:1fb4:22c8 with SMTP id u65-20020a25dd44000000b007971fb422c8mr3439764ybg.62.1674800397667; Thu, 26 Jan 2023 22:19:57 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b2f; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302679 Archived-At: --000000000000c61bfe05f338dac5 Content-Type: text/plain; charset="UTF-8" Here is the corrected patch which uses display-buffer-pop-up-window instead of window--try-to-split-window. I tested the behavior of xemacs and as far as I can tell display-buffer-use-least-recent-window now matches. Best, Tom --000000000000c61bfe05f338dac5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-display-buffer-use-some-window-to-honor-reusable.patch" Content-Disposition: attachment; filename="0001-Fix-display-buffer-use-some-window-to-honor-reusable.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lde4cqdh0 RnJvbSBlMTEzMzFlZDcxNmM5N2Q3Y2IxMzA2MDM3YTYwYzMxYmMxODlhZjZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBUaHUsIDI2IEphbiAyMDIzIDIzOjQ3OjIyIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGRp c3BsYXktYnVmZmVyLXVzZS1zb21lLXdpbmRvdyB0byBob25vciByZXVzYWJsZS1mcmFtZXMKIHNl dHRpbmcuCgoqIGxpc3Avd2luZG93LmVsIChkaXNwbGF5LWJ1ZmZlci11c2Utc29tZS13aW5kb3cp OiBIb25vciB1c2VyIHN1cHBsaWVkCnJldXNhYmxlLWZyYW1lcyBzZXR0aW5nIGlmIGl0IGlzIHBy ZXNlbnQgaW4gdGhlIGFsaXN0LgoqIGxpc3Avd2luZG93LmVsIChkaXNwbGF5LWJ1ZmZlci11c2Ut bGVhc3QtcmVjZW50LXdpbmRvdyk6IFNldApyZXVzYWJsZS1mcmFtZXMgbmlsIHVubGVzcyBpdCBp cyBhbHJlYWR5IHByZXNlbnQgaW4gdGhlIGFsaXN0LgoKVGhlIGRvY3MgZm9yICdkaXNwbGF5LWJ1 ZmZlci11c2UtbGVhc3QtcmVjZW50LXdpbmRvdycgc3RhdGUgdGhhdCBpdAp3aWxsIHBpY2sgdGhl IGxlYXN0IHJlY2VudGx5IHVzZWQgd2luZG93IG9yIGFuZCBpZiB0aGVyZSBpcyBvbmx5IGEKc2lu Z2xlIHdpbmRvdyBpdCB3aWxsIHNwbGl0IHRoZSB3aW5kb3cuCgpQcmlvciB0byB0aGlzIGNvbW1p dCB0aGF0IGJlaGF2aW9yIHdhcyBpbXBvc3NpYmxlIHRvIGFjaGlldmUgYmVjYXVzZQonZGlzcGxh eS1idWZmZXItdXNlLXNvbWUtd2luZG93JyB3b3VsZCBhdHRlbXB0IHRvIGZpbmQgYSB2YWxpZCB3 aW5kb3cKaW4gb3RoZXIgZnJhbWVzLiAgVGhlIG9sZCBiZWhhdmlvciBpcyByZXRhaW5lZCB3aGVu IHJldXNhYmxlLWZyYW1lcyBpcwpub3QgZXhwbGljaXRseSBpbmNsdWRlZCBpbiB0aGUgYWxpc3Qu ICBXaGVuIHJldXNhYmxlLWZyYW1lcyBpcwpwcm92aWRlZCBpbiB0aGUgYWxpc3QgdGhlbiAnZGlz cGxheS1idWZmZXItdXNlLXNvbWUtd2luZG93JyBob25vcnMKdGhhdCBhbmQgd2lsbCBzcGxpdCB0 aGUgd2luZG93IGlmIHRoZSB2YWx1ZSBpcyAocmV1c2FibGUtZnJhbWVzIC4gbmlsKQpzaW5jZSB0 aGUgdXNlcidzIGludGVudGlvbiBpcyBjbGVhciwgdGhleSBkbyBub3Qgd2FudCB0byByZXVzZSBz b21lCm90aGVyIGZyYW1lLiAgJ2Rpc3BsYXktYnVmZmVyLXBvcC11cC13aW5kb3cnIGlzIHVzZWQg dG8gc3BsaXQgdGhlCndpbmRvdyBpbiB0aGlzIGNhc2Ugc28gdGhhdCBwZXJtZW5lbnQgY2hhbmdl cyBhcmUgbm90IG1hZGUgdG8gdGhlCndpbmRvdyBsYXlvdXQuCgpUaGlzIG1ha2VzIGl0IHBvc3Np YmxlIHRvIG9idGFpbiB0aGUgZG9jdW1lbnRlZCBiZWhhdmlvciBmb3IKJ2Rpc3BsYXktYnVmZmVy LXVzZS1sZWFzdC1yZWNlbnQtd2luZG93JyBieSBhZGRpbmcgcmV1c2FibGUtZnJhbWVzIG5pbAp0 byB0aGUgYWxpc3QgaWYgaXQgaXMgYWJzZW50LgoKSSdtIG5vdCBzdXJlIHRoYXQgdGhpcyBiZWhh dmlvciBpcyBleGFjdGx5IGNvcnJlY3QsIGJ1dCBpdCBwcmV2ZW50cwp0aGUgaW5zYW5pdHkgb2Yg aGF2aW5nIG11bHRpcGxlIHJhbmRvbSB3aW5kb3dzIGluIHJhbmRvbSBmcmFtZXMKY2hhbmdlZCB0 byB0aGUgYnVmZmVyIHRvIGJlIGRpc3BsYXllZCwgZGVzdHJveWluZyB3aGF0ZXZlciBzdGF0ZSB0 aGUKdXNlciB3YXMgbWFpbnRhaW5pbmcgaW4gdGhvc2Ugd2luZG93cy4KLS0tCiBsaXNwL3dpbmRv dy5lbCB8IDIyICsrKysrKysrKysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aW5kb3cuZWwgYi9s aXNwL3dpbmRvdy5lbAppbmRleCAwY2QzMDgyMmZmNi4uODZjMjZkM2EwODcgMTAwNjQ0Ci0tLSBh L2xpc3Avd2luZG93LmVsCisrKyBiL2xpc3Avd2luZG93LmVsCkBAIC04NTA5LDcgKzg1MDksMTEg QEAgZGlzcGxheS1idWZmZXItdXNlLWxlYXN0LXJlY2VudC13aW5kb3cKIHdoZW4gZGlzcGxheWlu ZyBidWZmZXJzIHJlcGVhdGVkbHksIGFuZCBpZiB0aGVyZSdzIG9ubHkgYSBzaW5nbGUKIHdpbmRv dywgaXQgd2lsbCBzcGxpdCB0aGUgd2luZG93LiIKICAgKHdoZW4tbGV0ICgod2luZG93IChkaXNw bGF5LWJ1ZmZlci11c2Utc29tZS13aW5kb3cKLSAgICAgICAgICAgICAgICAgICAgICBidWZmZXIg KGNvbnMgKGNvbnMgJ2luaGliaXQtc2FtZS13aW5kb3cgdCkgYWxpc3QpKSkpCisgICAgICAgICAg ICAgICAgICAgICAgYnVmZmVyCisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKGFsaXN0IChj b25zIChjb25zICdpbmhpYml0LXNhbWUtd2luZG93IHQpIGFsaXN0KSkpCisgICAgICAgICAgICAg ICAgICAgICAgICAoaWYgKGFzc3EgJ3JldXNhYmxlLWZyYW1lcyBhbGlzdCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICBhbGlzdAorICAgICAgICAgICAgICAgICAgICAgICAgICAoY29ucyAo Y29ucyAncmV1c2FibGUtZnJhbWVzIG5pbCkgYWxpc3QpKSkpKSkKICAgICAod2luZG93LWJ1bXAt dXNlLXRpbWUgd2luZG93KSkpCiAKIChkZWZ1biBkaXNwbGF5LWJ1ZmZlci11c2Utc29tZS13aW5k b3cgKGJ1ZmZlciBhbGlzdCkKQEAgLTg1MzAsMTEgKzg1MzQsMjcgQEAgZGlzcGxheS1idWZmZXIt dXNlLXNvbWUtd2luZG93CiBjYWxsZWQgb25seSBieSBgZGlzcGxheS1idWZmZXInIG9yIGEgZnVu Y3Rpb24gZGlyZWN0bHkgb3IKIGluZGlyZWN0bHkgY2FsbGVkIGJ5IHRoZSBsYXR0ZXIuIgogICAo bGV0KiAoKG5vdC10aGlzLXdpbmRvdyAoY2RyIChhc3NxICdpbmhpYml0LXNhbWUtd2luZG93IGFs aXN0KSkpCisgICAgICAgICAoZXhwbGljaXQtcmV1c2FibGUtZnJhbWVzIChhc3NxICdyZXVzYWJs ZS1mcmFtZXMgYWxpc3QpKQorICAgICAgICAgKHJldXNhYmxlLWZyYW1lcyAoY2RyIGV4cGxpY2l0 LXJldXNhYmxlLWZyYW1lcykpCiAJIChmcmFtZSAob3IgKHdpbmRvdy0tZnJhbWUtdXNhYmxlLXAg KHNlbGVjdGVkLWZyYW1lKSkKIAkJICAgICh3aW5kb3ctLWZyYW1lLXVzYWJsZS1wIChsYXN0LW5v bm1pbmlidWZmZXItZnJhbWUpKSkpCiAJICh3aW5kb3cKIAkgIDs7IFJldXNlIGFuIGV4aXN0aW5n IHdpbmRvdy4KIAkgIChvciAoZ2V0LWxydS13aW5kb3cgZnJhbWUgbmlsIG5vdC10aGlzLXdpbmRv dykKKyAgICAgICAgICAoYW5kCisgICAgICAgICAgIGV4cGxpY2l0LXJldXNhYmxlLWZyYW1lcwor ICAgICAgICAgICAob3IKKyAgICAgICAgICAgIChhbmQKKyAgICAgICAgICAgICAobm90IHJldXNh YmxlLWZyYW1lcykKKyAgICAgICAgICAgICAobGV0ICgod2luZG93IChkaXNwbGF5LWJ1ZmZlci1w b3AtdXAtd2luZG93IGJ1ZmZlciBhbGlzdCkpKQorICAgICAgICAgICAgICAgKHVubGVzcyAoYW5k IG5vdC10aGlzLXdpbmRvdworCQkJICAgICAgICAgICAgICAgIChlcSB3aW5kb3cgKHNlbGVjdGVk LXdpbmRvdykpKQorCQkgICAgICAgICB3aW5kb3cpKSkKKyAgICAgICAgICAgIChsZXQgKCh3aW5k b3cgKGdldC1idWZmZXItd2luZG93IGJ1ZmZlciByZXVzYWJsZS1mcmFtZXMpKSkKKwkJICAgICAg KHVubGVzcyAoYW5kIG5vdC10aGlzLXdpbmRvdworCQkJICAgICAgICAgICAgICAgKGVxIHdpbmRv dyAoc2VsZWN0ZWQtd2luZG93KSkpCisJCSAgICAgICAgd2luZG93KSkKKyAgICAgICAgICAgIChk aXNwbGF5LWJ1ZmZlci1uby13aW5kb3cgYnVmZmVyIGFsaXN0KSkpCiAJICAgICAgKGxldCAoKHdp bmRvdyAoZ2V0LWJ1ZmZlci13aW5kb3cgYnVmZmVyICd2aXNpYmxlKSkpCiAJCSh1bmxlc3MgKGFu ZCBub3QtdGhpcy13aW5kb3cKIAkJCSAgICAgKGVxIHdpbmRvdyAoc2VsZWN0ZWQtd2luZG93KSkp Ci0tIAoyLjM5LjEKCg== --000000000000c61bfe05f338dac5--