From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] hack-one-local-variable use lexical-binding Date: Wed, 25 Nov 2020 23:47:44 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000533fc305b4fb3f36" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31016"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 26 05:50:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki9Ew-0007yk-OX for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Nov 2020 05:50:42 +0100 Original-Received: from localhost ([::1]:34806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki9Ev-0006Ev-PP for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 23:50:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki9CP-00059d-Dt for emacs-devel@gnu.org; Wed, 25 Nov 2020 23:48:10 -0500 Original-Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:42508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki9CJ-0000Hf-JI for emacs-devel@gnu.org; Wed, 25 Nov 2020 23:48:03 -0500 Original-Received: by mail-wr1-x443.google.com with SMTP id l1so656726wrb.9 for ; Wed, 25 Nov 2020 20:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xnOpuHH2XZtnfE4L+PzqH8oG4c5xtIwitX0WA1gBZ0A=; b=JHaNSJXS67oOONvx1szDxfHE1Dqu+xbf8gkIm2p74WfN/tDHMRBx20hSJaQJKdPfHH JQjTxuY0rhmf/IR3FQKxgFqL/k2TA3FcoBVSFgSnMevEOQrfCQ4pEDBhILdlTakg9hK4 TGS9bNHhwZoe8wVk8C65nPwasAtPp+SgP0dLN6WHvTZI6YFQnR9S+sy8Gv3aOpqA/hTH ZqeH9tNBqoqMGoXBn44zOCkTvu/6qRHVBLkrdYgJYTnKguk4js0vAk+4ItzFel5sxv11 no9WC+LDC8/rFGeHra+JchJnFVgVlsFedX6VoQCBoZV8HkF6LjQGPoWR16yjv6djhbZP AU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xnOpuHH2XZtnfE4L+PzqH8oG4c5xtIwitX0WA1gBZ0A=; b=L/V2ED1HLD7qrt9ANTZaX4p6kXygqSZhYrVRPnMv2iiIDZBD8i0Qwjlxg9C+ADI3CB 1i5oqFY07wqQ9VsMTUjqh7lFQtoyunMyPCqfkOc+hkBYto0ooe01qb39iaQWq1tDtciy eQ6N1yiP4YVGM7PH35lwqSbu1BrCmtIeLsxVRrtBDEOsG72GPi70X/mX6V2zWlh5UH+q egz7M/9ENXmqpQJ9hx8VohmqxbzwBrlpnRgKXBV7f5oZTZUx0pJcRVpz4G6v/n6QCcrp 3dAqbZyLuEzBblCuTHKXsj1AE4eOhu19N/687Tlqc9FHWA06XY7ykG2r4g7Uap6dV5JU JZKQ== X-Gm-Message-State: AOAM532VSm6N3sztqaWt1xkGqMV1lgP6bOWzhidIDBlUvjhWbyJoUbrX YPVMKbc5dog9IhwQWZ7PRF2dtB6X5zBCqY2zIXA= X-Google-Smtp-Source: ABdhPJx4wvkGTh2xluxaNKZr4bxE/1yYLJRcMpI4eTZvUUu6AQp4h1o4Hqls3ttXu3xl9OF3OFlE576lzN3UhP1BQLg= X-Received: by 2002:adf:f783:: with SMTP id q3mr1389532wrp.88.1606366075753; Wed, 25 Nov 2020 20:47:55 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=tgbugs@gmail.com; helo=mail-wr1-x443.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259823 Archived-At: --000000000000533fc305b4fb3f36 Content-Type: text/plain; charset="UTF-8" > I think we should just always pass `t` to `eval` there, yes. > The other option is over-engineered. Agreed. Here is the updated patch. I'm guessing this will need a NEWS item? Best, Tom --000000000000533fc305b4fb3f36 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-hack-one-local-variable-eval-with-LEXICAL-t.patch" Content-Disposition: attachment; filename="0001-hack-one-local-variable-eval-with-LEXICAL-t.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_khycq1xz0 RnJvbSBkMWIyNjFmYWFlZDIyZjkyYTJjNjFjZTQzMjM2YTc3MjIxYjZjZTc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBXZWQsIDI1IE5vdiAyMDIwIDIzOjM3OjM2IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gaGFjay1v bmUtbG9jYWwtdmFyaWFibGUgZXZhbCB3aXRoIExFWElDQUwgdAoKKiBsaXNwL2ZpbGVzLmVsICho YWNrLW9uZS1sb2NhbC12YXJpYWJsZSk6IGNhbGwgZXZhbCB3aXRoIExFWElDQUwgdAoKQ2hhbmdl IHRoZSBiZWhhdmlvciBvZiBldmFsOiBsb2NhbCB2YXJpYWJsZXMgdG8gdXNlIGxleGljYWwgYmlu ZGluZy4KLS0tCiBsaXNwL2ZpbGVzLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3Av ZmlsZXMuZWwKaW5kZXggNDljOWU1ZDE4ZC4uZjZjMWM0NDcxOCAxMDA2NDQKLS0tIGEvbGlzcC9m aWxlcy5lbAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC0zOTg0LDcgKzM5ODQsNyBAQCBoYWNrLW9u ZS1sb2NhbC12YXJpYWJsZQogICAgICgnZXZhbAogICAgICAocGNhc2UgdmFsCiAgICAgICAgKGAo YWRkLWhvb2sgJyxob29rIC4gLF8pIChoYWNrLW9uZS1sb2NhbC12YXJpYWJsZS0tb2Jzb2xldGUg aG9vaykpKQotICAgICAoc2F2ZS1leGN1cnNpb24gKGV2YWwgdmFsKSkpCisgICAgIChzYXZlLWV4 Y3Vyc2lvbiAoZXZhbCB2YWwgdCkpKQogICAgIChfCiAgICAgIChoYWNrLW9uZS1sb2NhbC12YXJp YWJsZS0tb2Jzb2xldGUgdmFyKQogICAgICA7OyBNYWtlIHN1cmUgdGhlIHN0cmluZyBoYXMgbm8g dGV4dCBwcm9wZXJ0aWVzLgotLSAKMi4yNi4yCgo= --000000000000533fc305b4fb3f36--