From: Tom Gillespie <tgbugs@gmail.com>
To: "André A. Gomes" <andremegafone@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Rename headline to heading
Date: Sun, 8 Aug 2021 09:59:02 -0700 [thread overview]
Message-ID: <CA+G3_PPCC=wGz=rCTYJ9mO_8zZ6Yy50UKNX3vKrFM=KX2qSBeA@mail.gmail.com> (raw)
In-Reply-To: <871r786qfe.fsf@gmail.com>
Hi André,
Thanks for taking a first pass at this. I think that this patch is
difficult to review. Could you break it into two separate patches, one
for documentation (non-code, e.g. docstring and comment) changes and
one for code changes? That way we could more easily see where we may
need to mitigate the kind of issues Maxim noticed. Best!
Tom
next prev parent reply other threads:[~2021-08-08 17:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 12:12 [PATCH] Rename headline to heading André A. Gomes
2021-08-05 15:04 ` Maxim Nikulin
2021-08-14 22:54 ` Tim Cross
2021-08-15 16:22 ` No Wayman
2021-08-15 16:50 ` No Wayman
2021-08-15 22:32 ` Jim Porter
2021-08-15 23:17 ` Tim Cross
2021-08-16 0:38 ` Jim Porter
2021-08-16 1:18 ` Tim Cross
2021-08-08 16:59 ` Tom Gillespie [this message]
2021-08-14 23:19 ` Tim Cross
2021-09-19 11:06 ` Timothy
2021-09-30 12:08 ` André A. Gomes
2021-09-26 9:27 ` Bastien
2021-09-30 12:21 ` André A. Gomes
2021-10-01 8:38 ` Bastien
2021-10-15 8:52 ` André A. Gomes
2021-10-15 9:56 ` Timothy
2021-10-15 10:18 ` André A. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+G3_PPCC=wGz=rCTYJ9mO_8zZ6Yy50UKNX3vKrFM=KX2qSBeA@mail.gmail.com' \
--to=tgbugs@gmail.com \
--cc=andremegafone@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.