From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Date: Sun, 15 Aug 2021 15:39:09 -0700 Message-ID: References: <87o89ygyu8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12683"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 00:40:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFOnp-0003An-GZ for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 00:40:25 +0200 Original-Received: from localhost ([::1]:45520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFOno-0006Bo-3D for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Aug 2021 18:40:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFOmp-0005Vr-Qu for emacs-devel@gnu.org; Sun, 15 Aug 2021 18:39:23 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:44874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFOmo-00072y-CA for emacs-devel@gnu.org; Sun, 15 Aug 2021 18:39:23 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id l7-20020a1c2507000000b002e6be5d86b3so7037579wml.3 for ; Sun, 15 Aug 2021 15:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BG1Nq02xZZm1Hb+SAbzsnxN5LNA4OY91IRdKUqqHUZM=; b=PakT8mGcDrGXHTPuAI3NGWVkcXKKfVb0uKBYXQsMuego+MOCkIjidzky1w4rhf6eh4 /AjHinL8lB7zClU5qGfLLAqn85i6wdq7GVQEI8s2LhI4AIDNTLKThM1cCj7X5hWE0zjm YKuJJQd0j36tr0b1hKcRy8pk6dH2WsfItVDCQy+yoOhlg3o2sCs/5CK2oTC3Ql0PGUwp ayVBcQbY5ryXqALZwGt5obCNNGd89R6fSTrhlI/jTmuGtruNYwUXO96zv+F+9Ze2v5DT rzCEzU3vI+HnRL0OUATgoEIlLiAPHkoGLnqzSsbSwfw9wgygmFtuGSeHUW/l1s0Lciby b/RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BG1Nq02xZZm1Hb+SAbzsnxN5LNA4OY91IRdKUqqHUZM=; b=dz0eD4N7bJn1ybGxDslfGSq5UFUakxx8pS9O/xUvGzbWVSv3X9sVKMOr/VYAHIfoIq 2gdXD5XHS96VFbklyhNa9+eJlscxHEJOHwc77vlSNGS8asi04mObp78PCIDBw5E5qR1n 0NZ/e7u83MeggASlW8iYkdF99Pf4IsesWB6AXgKUyxISKhwii8VOS7x2MCl5Y5rrtR4d /9XT6e5QLcWaVvXxdAy7/PAoiuBQF850wUwqjLPHnNBDLgk7HOhsqJqE9bGPNYvAcVCL v1L3/Hg7WSNPsA1bCjbWmvk4M9PvpT3sl1D7Yzkia6u5F9EU97/2ag3vS4bC2FpxXtTS BsNA== X-Gm-Message-State: AOAM532wa5UbbxzXURJENyRjnCImna0GTowEFhLHwziAuLn0DRqa+0sW RVLFrQ5zJLBWCIJkwE1eikBzCwnLo/bl6I09lCA= X-Google-Smtp-Source: ABdhPJwAVxQinvGSW7JW+rXzC6yvoRaLoxvAjYIzgzPZvyTkoaeNd+NlBDoK8ivFCc+umWL9AJzfQcTgx86IEtnTyrI= X-Received: by 2002:a05:600c:19d4:: with SMTP id u20mr5740719wmq.45.1629067160401; Sun, 15 Aug 2021 15:39:20 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=tgbugs@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272417 Archived-At: > > > + (with-current-buffer (find-file-literally tempfile) > > > + (hack-local-variables))) > > > > Should probably be a `should' in here to make it work as a test, I think. > > I think that is right, it kind of works at the moment because the previous > behavior produces an error. Correction: hack-local-variables returns nil, so it is working as intended because the original behavior is an error. Wrapping in should will produce an incorrect test failure.