From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.bugs Subject: bug#55645: src/print.c; print_object changes make it impossible to compare elisp code across versions Date: Wed, 25 May 2022 16:12:02 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33881"; mail-complaints-to="usenet@ciao.gmane.io" To: 55645@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 26 01:13:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nu0Bk-0008f1-BD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 01:13:12 +0200 Original-Received: from localhost ([::1]:59590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nu0Bi-0002Rc-RG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 May 2022 19:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu0Ba-0002RJ-Gs for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 19:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nu0Ba-0003FF-8l for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 19:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nu0Ba-000348-21 for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 19:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Gillespie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 23:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55645 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Emacs Bug Report Original-Received: via spool by submit@debbugs.gnu.org id=B.165352033711718 (code B ref -1); Wed, 25 May 2022 23:13:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 May 2022 23:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:56604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nu0Ar-00032w-7q for submit@debbugs.gnu.org; Wed, 25 May 2022 19:12:17 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nu0Aq-00032o-2N for submit@debbugs.gnu.org; Wed, 25 May 2022 19:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu0Ap-0001sU-UW for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 19:12:15 -0400 Original-Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]:35601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nu0Ao-00039F-E7 for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 19:12:15 -0400 Original-Received: by mail-yb1-xb30.google.com with SMTP id v26so292801ybd.2 for ; Wed, 25 May 2022 16:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=7QkcxAyYwVeMW5JmNnj3K7lcu8BFWC10VHvKHO31NdY=; b=SM7oKL/PRHfO9l1DOko8fmE4XdluM3xWZfiWWmjXbBJuZ6vhfqAf5lO+XppDEycRxy yBh05YpMKYFx4zvP+HrdbcqWEhmhw3Cpl08Jk0A4iWdnTKbsyQ5WF/gGaY4hKXhar/wl pEwlD7nJFSEdBz+bLYe4dGiUQ6IdWbu9XrA9PTMh+mi9MWa9RcvjQXwY85z8xJFtryNC nosmhCwf0h1Iiv+8sByHZ78QQczSR9bZ/N3dSk1sisyXp2h9MRZ3lIFk4lT543luk6kL KJYTwujcLUwtlumlSb4j+bGrJBZ1x+X2MXUOJ+PFrZeEFG5Uv2WgFKx6Z+XOv+KZmxqn GLaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=7QkcxAyYwVeMW5JmNnj3K7lcu8BFWC10VHvKHO31NdY=; b=Wzsm4lPx1diAis/nJnQq97Rk52i75OzVMAawnrzMrfkXexRUBIUJd3JZ/+k14/y+iU IovOYCtSuO0XO0cHkkIynm/K/zKBmEu+NZCN3Z41jBc78EH4Qg6mxv6Y4ph6KFjUYWqt 4lAjykcRE7DBIrSgUGzN3vENWumA8wyk+ELT1NRR6VJ2OHNJ/KghQNJWqvWUUoh+Qsor YJWljWyZMdyKq6VkLy+qGgqf1FabUPnRprZ0cTZs+6j6/cJmQYn/Gi4IlvdtuKwFJquG nGbVOfupxgfLNhBWozaXS8oqVeqV9wisJaVHdNKTIxw5uxvad0uwWmtfk8zwyQuLHm+f ISLQ== X-Gm-Message-State: AOAM531MJZWdD9UTFnxkzNSOBkjn1KxbkFY9hh4qRiIiUQ4z0Z8kpRKC Ulh8S/VXX9UWaS/mKEGwEluyLj8gWSx+TBthksoOXnJzyys= X-Google-Smtp-Source: ABdhPJzGgosB5cWE4QZjn/C4knTDMgaZPOAYqNgq5qrTEm56NPe3uZlf3KJ+zNWcxAN+ZPN+daqhu9SnCpYJUm8qgqQ= X-Received: by 2002:a25:af4e:0:b0:655:c9a3:affb with SMTP id c14-20020a25af4e000000b00655c9a3affbmr4495807ybj.360.1653520333037; Wed, 25 May 2022 16:12:13 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233083 Archived-At: The changes made in 637dde4aba921435f78d0de769ad74c4f3230aa6 make it impossible to use prin1-to-string as the basis for hashing elisp code in a way that is independent of the emacs version. The change completely breaks my orgstrap library across the 28 -> 29 boundary because the checksum computed on <= 28's prin1-to-string and the checksum computed by 29's prin1-to-string no long match in cases where there is a . or a ? in a symbol. As implemented, there is no way to work around the issue, and I suspect that many other users will be surprised and rather upset by this change when they have the misfortune to encounter it. At the very least this change in behavior needs to be configurable so that the old behavior can be retained, preferably this change would be reverted entirely as it does not address the original bug (bug#23130) and is NOT low impact for users that actually use such functionality, whereas the change is completely invisible to those that do not use such functionality.