all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom Gillespie <tgbugs@gmail.com>
To: 55645@debbugs.gnu.org
Subject: bug#55645: src/print.c; print_object changes make it impossible to compare elisp code across versions
Date: Wed, 25 May 2022 16:12:02 -0700	[thread overview]
Message-ID: <CA+G3_PNrsSCwZM_C-0csv8ZJgYWwcgdbRoX_kuQK2UmThKN6+Q@mail.gmail.com> (raw)

The changes made in 637dde4aba921435f78d0de769ad74c4f3230aa6
make it impossible to use prin1-to-string as the basis for hashing elisp
code in a way that is independent of the emacs version.

The change completely breaks my orgstrap library across the 28 -> 29
boundary because the checksum computed on <= 28's prin1-to-string
and the checksum computed by 29's prin1-to-string no long match in
cases where there is a . or a ? in a symbol.

As implemented, there is no way to work around the issue, and I
suspect that many other users will be surprised and rather upset
by this change when they have the misfortune to encounter it.

At the very least this change in behavior needs to be configurable so that
the old behavior can be retained, preferably this change would be
reverted entirely as it does not address the original bug (bug#23130) and
is NOT low impact for users that actually use such functionality, whereas
the change is completely invisible to those that do not use such functionality.





             reply	other threads:[~2022-05-25 23:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 23:12 Tom Gillespie [this message]
2022-05-26 12:03 ` bug#55645: src/print.c; print_object changes make it impossible to compare elisp code across versions Lars Ingebrigtsen
2022-05-26 15:56   ` Tom Gillespie
2022-05-27 10:33     ` Lars Ingebrigtsen
2022-05-27 19:19       ` Tom Gillespie
2022-05-28 10:39         ` Lars Ingebrigtsen
2022-05-28 17:54           ` Tom Gillespie
2022-05-29 13:15             ` Lars Ingebrigtsen
2022-05-29 15:14               ` Eli Zaretskii
2022-05-29 21:03                 ` Tom Gillespie
2022-06-04  9:15                   ` Eli Zaretskii
2022-06-04 11:35                     ` Lars Ingebrigtsen
2022-06-04 11:53                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 12:09                         ` Lars Ingebrigtsen
2022-06-04 12:18                           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 13:14                             ` Lars Ingebrigtsen
2022-06-04 13:30                               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 13:35                                 ` Lars Ingebrigtsen
2022-06-04 13:47                                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-06 23:30                     ` Tom Gillespie
2022-06-07 16:35                       ` Eli Zaretskii
2022-07-11 11:22                         ` Lars Ingebrigtsen
2022-07-11 18:43                           ` Tom Gillespie
2022-07-12 12:44                             ` Lars Ingebrigtsen
2022-07-13 23:26                               ` Tom Gillespie
2022-07-14 17:22                                 ` Lars Ingebrigtsen
2022-07-14 21:36                                   ` Tom Gillespie
2022-07-18 18:13                                     ` Tom Gillespie
2022-07-12  3:04                           ` Richard Stallman
2022-07-12 12:45                             ` Lars Ingebrigtsen
2022-07-13  3:16                               ` Richard Stallman
2022-05-28 23:14         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+G3_PNrsSCwZM_C-0csv8ZJgYWwcgdbRoX_kuQK2UmThKN6+Q@mail.gmail.com \
    --to=tgbugs@gmail.com \
    --cc=55645@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.