From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Sat, 28 Jan 2023 15:01:42 -0500 Message-ID: References: <834jsccepb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000010620f05f3587464" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 28 21:02:50 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLrPU-0005hn-RT for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Jan 2023 21:02:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLrOj-0007x5-Nr; Sat, 28 Jan 2023 15:02:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLrOe-0007wZ-MQ for emacs-devel@gnu.org; Sat, 28 Jan 2023 15:01:59 -0500 Original-Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLrOd-0006nm-14; Sat, 28 Jan 2023 15:01:56 -0500 Original-Received: by mail-yb1-xb30.google.com with SMTP id 123so9832784ybv.6; Sat, 28 Jan 2023 12:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/H3FaS16yGJxO9DMaJDkWsRES2Kul8lhFJj7ufWCJsM=; b=UIXV6HMd3j7PLryqL15tXHvTgk0cXaWxs+dS6RWNG7GQNuXb5UON722g4zjMyG5HzP PsOG7KvsbKt3D5ibOB2OQZ6urnLS4/BgLQTCNBQvRusDS1I1DM+ep0Iyg2bs0dUCP67c sLylU/BoV+ojUqL3Qe1lww0rLzkkkAwjANYI/WSuqNW7lgAEr+HstBafQYDmfwP37plN cV4hdP6oOb7DVJRb9chwMjVWH/EzwJy8/0NEDUf/JdAPNTdnR3y5iRLIYX0Z0/weP6NN FrPFdkq2vfzkYxOpDJjQG8b5aCuIz5jUr6opiSarVfVMyHorXmoQ9ZnHl2lUCG9iNNzr T/FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/H3FaS16yGJxO9DMaJDkWsRES2Kul8lhFJj7ufWCJsM=; b=y2LglntkCw8bGrmMwHRQHryfjUZczcKlZ8TGyaFP3oEngQ2gAIDnJshERiV8DlCylM u25lo0UWnh3Uu0V+aNy+bMOHWtY+SYIj/5pDTF+smtQYSTE5cgOyWt9Wz2Oi3mNwNHCr fLFKaGtq9tU35qVFBOgKkiIU6wNQ9iJEcPTSNMcqtwy0MFgnTZ2nANE/CbgSouxqrVAn yVCqnVODoG3xDNCTvbaAInpKxK18LWXWlPvagoQINQ4tWAbqK86PJ404UoRlmmSI9pyM xObD5m9k/TSKiErE+aULADS6zGWCBySYHwk1B6xJy3C7R9R9sc0pUgW1cCRsAjU6Fp74 lsaw== X-Gm-Message-State: AFqh2kqqywZvx7QsoSIunHez/Y6mrczcyCsLfcOBs8RhprWhSCXw9j1O 029SjO2A6HTsJsF9HUu/xXTrpm0rkQYhxwyARSU= X-Google-Smtp-Source: AMrXdXt89HyaYR0aoUZloPmtAjJSafI9iL+r8nqjQE3QnKRpFzIu2Io0rlIYWKKT03AeTfI8USnmJt0Ge/ZV4n3jdsE= X-Received: by 2002:a25:4807:0:b0:7ca:63c4:e5c1 with SMTP id v7-20020a254807000000b007ca63c4e5c1mr4329896yba.301.1674936113434; Sat, 28 Jan 2023 12:01:53 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302730 Archived-At: --00000000000010620f05f3587464 Content-Type: text/plain; charset="UTF-8" Here is an updated patch which does not touch 'display-buffer-use-some-window' at all, and that corrects splitting behavior and return value for 'display-buffer-use-least-recent-window'. If a patch to 'display-buffer-use-some-window' to honor reusable-frames is desired, let's deal with it separately. Best! Tom --00000000000010620f05f3587464 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-display-buffer-use-least-recent-window-to-split-.patch" Content-Disposition: attachment; filename="0001-Fix-display-buffer-use-least-recent-window-to-split-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ldgdp1ml0 RnJvbSAyNzQ0OTNjY2IwZTE1YWVlYzg4YjA4ZmNmNzkxODA2MTZkZWFjZjZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBUaHUsIDI2IEphbiAyMDIzIDIzOjQ3OjIyIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGRp c3BsYXktYnVmZmVyLXVzZS1sZWFzdC1yZWNlbnQtd2luZG93IHRvIHNwbGl0LCByZXR1cm4KIHdp bmRvdy4KCiogbGlzcC93aW5kb3cuZWwgKGRpc3BsYXktYnVmZmVyLXVzZS1sZWFzdC1yZWNlbnQt d2luZG93KTogUmV0dXJuCndpbmRvdyBpbnN0ZWFkIG9mIG5pbCwgYW5kIGFjdHVhbGx5IHNwbGl0 IGluIHNpbmdsZSB3aW5kb3cgY2FzZS4KCidkaXNwbGF5LWJ1ZmZlci11c2UtbGVhc3QtcmVjZW50 LXdpbmRvdycgbm93IHJldHVybnMgd2luZG93IGlmIG9uZSBpcwpzZWxlY3RlZCB3aGljaCBwcmV2 ZW50cyB0aGUgcmF0aGVyIG5hc3R5IGJlaGF2aW9yIG9mIHNlbGVjdGluZyBhCndpbmRvdyBpbiB0 aGUgY3VycmVudCBmcmFtZSBhbmQgdGhlbiBhbHNvIHNlbGVjdGluZyBhIHdpbmRvdyBpbgphbm90 aGVyIHJhbmRvbSBmcmFtZSBhcyB3ZWxsIChxdWl0ZSBtYWRkZW5pbmcpLgoKVGhlIGRvY3MgZm9y ICdkaXNwbGF5LWJ1ZmZlci11c2UtbGVhc3QtcmVjZW50LXdpbmRvdycgc3RhdGUgdGhhdCBpdAp3 aWxsIHBpY2sgdGhlIGxlYXN0IHJlY2VudGx5IHVzZWQgd2luZG93IG9yIGFuZCBpZiB0aGVyZSBp cyBvbmx5IGEKc2luZ2xlIHdpbmRvdyBpdCB3aWxsIHNwbGl0IHRoZSB3aW5kb3cuCgpQcmlvciB0 byB0aGlzIGNvbW1pdCB0aGF0IGJlaGF2aW9yIHdhcyBpbXBvc3NpYmxlIHRvIGFjaGlldmUgYmVj YXVzZQonZGlzcGxheS1idWZmZXItdXNlLWxlYXN0LXJlY2VudC13aW5kb3cnIHJldXNlZCB0aGUg aW50ZXJuYWxzIG9mCidkaXNwbGF5LWJ1ZmZlci11c2Utc29tZS13aW5kb3cnIHdoaWNoIHdvdWxk IGF0dGVtcHQgdG8gZmluZCBhIHZhbGlkCndpbmRvdyBpbiBvdGhlciBmcmFtZXMgYW5kIG5ldmVy IHNwbGl0IHRoZSBjdXJyZW50IHdpbmRvdy4KCidkaXNwbGF5LWJ1ZmZlci11c2UtbGVhc3QtcmVj ZW50LXdpbmRvdycgbm8gbG9uZ2VyIGNhbGxzCidkaXNwbGF5LWJ1ZmZlci11c2Utc29tZS13aW5k b3cnIGFuZCBpbnN0ZWFkIGRpcmVjdGx5IGNhbGxzCidnZXQtbHJ1LXdpbmRvdycgZm9sbG93ZWQg YnkgJ2Rpc3BsYXktYnVmZmVyLXBvcC1wLXdpbmRvdycgd2hlbgpyZXVzYWJsZS1mcmFtZXMgaXMg bm90IHByb3ZpZGVkIG9yIG5pbCwgb3IgJ2dldC1idWZmZXItd2luZG93JyB3aGVuCnJldXNhYmxl LWZyYW1lcyBpcyBub24tbmlsLiAgT25jZSB0aGUgd2luZG93IGlzIHNlbGVjdGVkIGl0IHJ1bnMg Y29kZQp0aGF0IGhhcyBiZWVuIGR1cGxpY2F0ZWQgZnJvbSAnZGlzcGxheS1idWZmZXItdXNlLXNv bWUtd2luZG93Jy4KLS0tCiBsaXNwL3dpbmRvdy5lbCB8IDM5ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aW5kb3cuZWwgYi9saXNwL3dpbmRvdy5l bAppbmRleCAwY2QzMDgyMmZmNi4uNmRkNGZlZDFkZDMgMTAwNjQ0Ci0tLSBhL2xpc3Avd2luZG93 LmVsCisrKyBiL2xpc3Avd2luZG93LmVsCkBAIC04NTA3LDEwICs4NTA3LDQxIEBAIGRpc3BsYXkt YnVmZmVyLXVzZS1sZWFzdC1yZWNlbnQtd2luZG93CiBUaGlzIGBkaXNwbGF5LWJ1ZmZlcicgYWN0 aW9uIGZ1bmN0aW9uIGlzIGxpa2UKIGBkaXNwbGF5LWJ1ZmZlci11c2Utc29tZS13aW5kb3cnLCBi dXQgd2lsbCBjeWNsZSB0aHJvdWdoIHdpbmRvd3MKIHdoZW4gZGlzcGxheWluZyBidWZmZXJzIHJl cGVhdGVkbHksIGFuZCBpZiB0aGVyZSdzIG9ubHkgYSBzaW5nbGUKLXdpbmRvdywgaXQgd2lsbCBz cGxpdCB0aGUgd2luZG93LiIKLSAgKHdoZW4tbGV0ICgod2luZG93IChkaXNwbGF5LWJ1ZmZlci11 c2Utc29tZS13aW5kb3cKLSAgICAgICAgICAgICAgICAgICAgICBidWZmZXIgKGNvbnMgKGNvbnMg J2luaGliaXQtc2FtZS13aW5kb3cgdCkgYWxpc3QpKSkpCi0gICAgKHdpbmRvdy1idW1wLXVzZS10 aW1lIHdpbmRvdykpKQord2luZG93LCBpdCB3aWxsIHNwbGl0IHRoZSB3aW5kb3cuCisKK0lmIGBy ZXVzYWJsZS1mcmFtZXMnIGlzIHByb3ZpZGVkIGluIHRoZSBhbGlzdCB0aGVuCitgZGlzcGxheS1i dWZmZXItdXNlLWxlYXN0LXJlY2VudC13aW5kb3cnIHdpbGwgYXR0ZW1wdCB0byBmaW5kIGEKK3dp bmRvdyBpbiBvdGhlciBmcmFtZXMgYWNjb3JkaW5nbHkuIEJ5IGRlZmF1bHQgaXQgb25seSBzZWFy Y2hlcwordGhlIGN1cnJlbnQgZnJhbWUuIgorICAobGV0KiAoKG5vdC10aGlzLXdpbmRvdyB0KQor ICAgICAgICAgKHJldXNhYmxlLWZyYW1lcyAoYXNzcSAncmV1c2FibGUtZnJhbWVzIGFsaXN0KSkK KyAgICAgICAgIChmcmFtZSAob3IgKHdpbmRvdy0tZnJhbWUtdXNhYmxlLXAgKHNlbGVjdGVkLWZy YW1lKSkKKyAgICAgICAgICAgICAgICAgICAgKHdpbmRvdy0tZnJhbWUtdXNhYmxlLXAgKGxhc3Qt bm9ubWluaWJ1ZmZlci1mcmFtZSkpKSkKKyAgICAgICAgICh3aW5kb3cgKG9yIChnZXQtbHJ1LXdp bmRvdyBmcmFtZSBuaWwgbm90LXRoaXMtd2luZG93KQorICAgICAgICAgICAgICAgICAgICAgKGlm IChub3QgcmV1c2FibGUtZnJhbWVzKQorICAgICAgICAgICAgICAgICAgICAgICAgIChkaXNwbGF5 LWJ1ZmZlci1wb3AtdXAtd2luZG93IGJ1ZmZlciBhbGlzdCkKKyAgICAgICAgICAgICAgICAgICAg ICAgKHdpbmRvdyAoZ2V0LWJ1ZmZlci13aW5kb3cgYnVmZmVyIHJldXNhYmxlLWZyYW1lcykpKSkp CisgICAgICAgICAocXVpdC1yZXN0b3JlIChhbmQgKHdpbmRvdy1saXZlLXAgd2luZG93KQorCQkJ ICAgICh3aW5kb3ctcGFyYW1ldGVyIHdpbmRvdyAncXVpdC1yZXN0b3JlKSkpCisgICAgICAgICAo cXVhZCAobnRoIDEgcXVpdC1yZXN0b3JlKSkpCisgICAgKHVubGVzcyAoZXEgd2luZG93IChzZWxl Y3RlZC13aW5kb3cpKQorICAgICAgKHdoZW4gKHdpbmRvdy1saXZlLXAgd2luZG93KQorICAgICAg ICA7OyBJZiB0aGUgd2luZG93IHdhcyB1c2VkIGJ5IGBkaXNwbGF5LWJ1ZmZlcicgYmVmb3JlLCB0 cnkgdG8KKyAgICAgICAgOzsgcmVzaXplIGl0IHRvIGl0cyBvbGQgaGVpZ2h0IGJ1dCBkb24ndCBz aWduYWwgYW4gZXJyb3IuCisgICAgICAgICh3aGVuIChhbmQgKGxpc3RwIHF1YWQpCisgICAgICAg ICAgICAgICAgICAgKGludGVnZXJwIChudGggMyBxdWFkKSkKKyAgICAgICAgICAgICAgICAgICAo PiAobnRoIDMgcXVhZCkgKHdpbmRvdy10b3RhbC1oZWlnaHQgd2luZG93KSkpCisgICAgICAgICAg KGNvbmRpdGlvbi1jYXNlIG5pbAorICAgICAgICAgICAgICAod2luZG93LXJlc2l6ZSB3aW5kb3cg KC0gKG50aCAzIHF1YWQpICh3aW5kb3ctdG90YWwtaGVpZ2h0IHdpbmRvdykpKQorICAgICAgICAg ICAgKGVycm9yIG5pbCkpKQorICAgICAgICAocHJvZzEKKyAgICAgICAgICAgICh3aW5kb3ctLWRp c3BsYXktYnVmZmVyIGJ1ZmZlciB3aW5kb3cgJ3JldXNlIGFsaXN0KQorICAgICAgICAgICh3aW5k b3ctLWV2ZW4td2luZG93LXNpemVzIHdpbmRvdykKKyAgICAgICAgICAodW5sZXNzIChjZHIgKGFz c3EgJ2luaGliaXQtc3dpdGNoLWZyYW1lIGFsaXN0KSkKKyAgICAgICAgICAgICh3aW5kb3ctLW1h eWJlLXJhaXNlLWZyYW1lICh3aW5kb3ctZnJhbWUgd2luZG93KSkpKSkpCisgICAgKHdoZW4gd2lu ZG93CisgICAgICAod2luZG93LWJ1bXAtdXNlLXRpbWUgd2luZG93KQorICAgICAgd2luZG93KSkp CiAKIChkZWZ1biBkaXNwbGF5LWJ1ZmZlci11c2Utc29tZS13aW5kb3cgKGJ1ZmZlciBhbGlzdCkK ICAgIkRpc3BsYXkgQlVGRkVSIGluIGFuIGV4aXN0aW5nIHdpbmRvdy4KLS0gCjIuMzkuMQoK --00000000000010620f05f3587464--