From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Mon, 30 Jan 2023 12:43:57 -0500 Message-ID: References: <834jsccepb.fsf@gnu.org> <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8980"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 30 18:44:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMYD4-0002Dq-OS for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Jan 2023 18:44:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMYCT-0000RH-BJ; Mon, 30 Jan 2023 12:44:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMYCR-0000P4-U2 for emacs-devel@gnu.org; Mon, 30 Jan 2023 12:44:11 -0500 Original-Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMYCQ-0002i1-CH; Mon, 30 Jan 2023 12:44:11 -0500 Original-Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-4a263c4ddbaso170614317b3.0; Mon, 30 Jan 2023 09:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=id0s4ZF2XLrjcM7pD/i+utfYa/7gUhMCXvOx7cbIzVg=; b=PIC4LFTEmuo+JN+tA9dgFLD39yQwP2JVy197d1yuiwW/AARfKhfz6ySwY4B6uLge1j xl0x3o8G6UVAqbAvemsKcB12Bz/lZBbCC7W8pm5yKZ7dGJonmjo/hg2DzeX+f/er8gZs LrXamHc+W9lc28K8Et5nBGSOgCgNsTwrZEarRv03/psTiiLY83wxWCuZTIdSZo7NFCIO 8MX6sxaIrwuXg/Z6gDAaclqfO39RkJRMHiU9og7bAoFwcXmtoKEkljV9Rv7InzM25s2q aupx181KkoNNIQGHzykd1qei61gFXF7v9Dm9iG1lIpkFjm9CNu0bk9tMo1ck89BN1W5l cEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=id0s4ZF2XLrjcM7pD/i+utfYa/7gUhMCXvOx7cbIzVg=; b=QMPQlz2gmo8sIM49a73RS23u6d1sFibVhuwObt/waXRqzTERs5mlkjwQBd9OJtJXyZ O7grEeFIwiMdKmfZs6ZPJVB5KCpHXJfh/G7RkgJ/Abi4PaFqPgVo0sp15ZvzYjJF7hbo HNOLOjeaM7FPMqllNLTJnBFdHi2OWKvfO0pj5xKThtwweDtyjETnGI6RZCOABtxgwG6t ItvZNfIy1aSFpQ9yfPbaXW4RjY3xWJi6QFH+WoLHgmD60Upale6GexwmUfutjONoiZdX Jit4Q+ZcuVXK+QDLbgGh+idJ7MTio/ZSosSVG/LSiqYeiYiHXpTSbnDS8Kf/MYGk/Bmh GNlw== X-Gm-Message-State: AO0yUKVnwLr3KRgGPy1OqGQL6mzvKhmvuLmQpm72ay4bA4ZBdoH0Cdz4 t/LuHOukxACUw3NUypGAY0knfzgEBYcsRwOe9Ds= X-Google-Smtp-Source: AK7set+GB8/1LATLXG4Wfa04zkcVrftSzQpZATBM2eoVFbcPUCrSYLBtcL4HEF73gLvY0G1TBE5vciWC8gdX209SXZk= X-Received: by 2002:a05:690c:78d:b0:506:512a:a8dd with SMTP id bw13-20020a05690c078d00b00506512aa8ddmr2879462ywb.159.1675100648893; Mon, 30 Jan 2023 09:44:08 -0800 (PST) In-Reply-To: <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> Received-SPF: pass client-ip=2607:f8b0:4864:20::1134; envelope-from=tgbugs@gmail.com; helo=mail-yw1-x1134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302805 Archived-At: > is probably not what you really want. You're right. I missed the case where we first want to reuse an existing window if the buffer is already displayed in it. Working on a patch to add that back. > What speaks against > ... > (display-buffer-use-some-window buffer alist) > ... > or something the like? The main reason not to take that approach is that it requires changes to display-buffer-use-some-window like the ones I made in my first patch so that it will honor reusable-frames (though without the incorrect call to display-buffer-pop-up-window). It seems like it will be easier to reason about the impact of the changes for the patch if we only need to assess changes to display-buffer-use-least-recent-window.