From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tad Newsgroups: gmane.emacs.bugs Subject: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash Date: Mon, 16 Nov 2020 20:03:15 -0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27465"; mail-complaints-to="usenet@ciao.gmane.io" Cc: akrl@sdf.org To: 44701@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 17 05:25:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kesYI-00071R-Bl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Nov 2020 05:25:10 +0100 Original-Received: from localhost ([::1]:36606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kesYH-0001Yq-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 23:25:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kesYA-0001Yh-M5 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kesYA-0000VH-C6 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kesYA-000463-67 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tad Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 04:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44701 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160558707515708 (code B ref -1); Tue, 17 Nov 2020 04:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Nov 2020 04:24:35 +0000 Original-Received: from localhost ([127.0.0.1]:58025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kesXi-00045H-Pn for submit@debbugs.gnu.org; Mon, 16 Nov 2020 23:24:35 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:49382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kesDM-0003Yg-OS for submit@debbugs.gnu.org; Mon, 16 Nov 2020 23:03:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kesDM-0006wf-IW for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:03:32 -0500 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:39439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kesDJ-0001Nf-Pm for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:03:32 -0500 Original-Received: by mail-lj1-x22d.google.com with SMTP id o24so22706702ljj.6 for ; Mon, 16 Nov 2020 20:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=d5eplLEKAxP2soQU3A4I9YQZI12nbSjhQTTpPIo/Ong=; b=lRtq2I+U1dpWo3IZaIMW1+XpYYDGIJh+VlojvyOR9ZugL/7uOarekCV43c1ke0tA5J kvwAbTthaIWRaIl8Qmvqnaj9TAJpe5Feylofc/5lzATqCnZyzJ9eodHbDgTo5H2ZpDGE at5/NdcOWgnHm8VtWxEfuRjv0SJeHbdGH3a07QwPvesKbOd4/2BMVHhxuBYkrmEh8U/U QOME4UZBjMCcdBdEMfWzB22j24k19h6FFTOcYWxk9BG0WVzEl/vwfAgsWJgMzjMOJsAQ k+qi4wrtv7k0eEl1jC99m19+TfQmvnQdTWQzd8q6oj0STxHPIetqrCK6sg2MaGJLu6HR bpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=d5eplLEKAxP2soQU3A4I9YQZI12nbSjhQTTpPIo/Ong=; b=lHMxkVnN/mn3P0t0+WSJXswK0OIwfgWccvflSTIe6ltr4kqNI2CCZbH75QKF539wtj SU2tq26acgdAt1JgmxsjbrUIVaijbqwnT3BeGz+usRpr1Maau0dIs5hsZxCfkyrdgwYU GHqZFk626U2u+mvMJjd4BR/lOBJdIAvd/70C9NjilTRZThZndabtkSkYKRS2ra8mL1Qg Vw8q8Xx/f6uAjUQfjnlah8ErDV9AaVqZUgxBOxIq9ytxxB2fztnYzf3sy8nhxlMPK9pA x9cX9I//RWpWNw12SmYGei5mbpDNN4rfP6SHD36fdG2Fdu7DX7poCuMPrGM23sK8VUBP g3/w== X-Gm-Message-State: AOAM530EVR/zd8t8jkjp3PTiysruQewGq6v4CDIxYHCavYAW22yEYo1s Nd6qARXQt78eWEFaQBsclnSBRjeSh/FnvgSZjSqCpE+tpaU= X-Google-Smtp-Source: ABdhPJxmbzInN7SWBu1BaRfMAY+uXA9h7tl9JNRvoH/kkpQ6IEEhq4irK0dkNXR6wgYNRhbxOxp8/ypOXGKijbIMEfM= X-Received: by 2002:a2e:8007:: with SMTP id j7mr1063050ljg.56.1605585806673; Mon, 16 Nov 2020 20:03:26 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::22d; envelope-from=tadfisher@gmail.com; helo=mail-lj1-x22d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 16 Nov 2020 23:24:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193517 Archived-At: It appears that `comp-el-to-eln-filename` uses `expand-file-name` to determine the absolute filename to hash. When the filename is a symlink, this results in a cache miss depending on which path is loaded. `file-truename' would be the equivalent to `(expand-file-name name nil)`, except that it would resolve to a single canonical path (in the absence of hardlinks, which is pathological). If I may ask, what is the purpose behind the path component of the hash? I would think a content hash would suffice to disambiguate files in the .el<->.eln bijection. Thanks, Tad