From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.devel Subject: Re: viper-mode undo bug introduced between Nov 10 and Nov 14 Date: Fri, 13 May 2016 08:11:38 -0700 Message-ID: References: <838u0fe3u2.fsf@gnu.org> <83postav28.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1463152352 29175 80.91.229.3 (13 May 2016 15:12:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 May 2016 15:12:32 +0000 (UTC) Cc: Phillip Lord , emacs-devel To: Eli Zaretskii , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 13 17:12:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b1ElN-0005NY-Eq for ged-emacs-devel@m.gmane.org; Fri, 13 May 2016 17:12:25 +0200 Original-Received: from localhost ([::1]:34924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1ElM-0004S9-Om for ged-emacs-devel@m.gmane.org; Fri, 13 May 2016 11:12:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1El3-0004LD-0X for emacs-devel@gnu.org; Fri, 13 May 2016 11:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1Ekx-0003We-Gd for emacs-devel@gnu.org; Fri, 13 May 2016 11:12:03 -0400 Original-Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:33918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1Ekx-0003WS-AV; Fri, 13 May 2016 11:11:59 -0400 Original-Received: by mail-oi0-x22c.google.com with SMTP id k142so175218624oib.1; Fri, 13 May 2016 08:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3Szeljic2cSUdLuTBj0gsRvrDLl6kiPZPZpiiZJ1zjE=; b=DeLM+vHLDBzPyGwwrkcZ3aOUBed+yPNnqMTXxHxOGBe9FALLRyxxPAN5EAsLqPg5cy bk3jwubwb3pSZkhXfFHjair7+Wm2v/jrdoNZybc1UGZVZYCiRkq3/VGsilocnb2Ej+hP naDf3h57Ikt/KafVPEti5Z7jV+qyJ/Xxso6QiS+7byG54APtX7FgnA8KKmp66wJ6bKh7 JzKmf6Zcl3568lv/fhWKhjV/0v1YXLyG8aVNHQceZyC8USJS0/MIv/CnRDhiG8q6R5Ps UEmuW/vn/fR1C95ULYzPWFsTW2OtSEzu5G2QQCaHL3Try6vFqYaeK2VMkBjILhl5AZUg Jp/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3Szeljic2cSUdLuTBj0gsRvrDLl6kiPZPZpiiZJ1zjE=; b=Jx0jGH0JSUSxhEEP5NFJ/PzgyudXt7P81p0eLbuzyEDpXHdIbvnlRcxpGk3Fvg8Y5B xuZAm4yRD1CYRS2Orc19mGe6aAXZ2E4CXBnM60IsA23R1p6VIiVFsrw5WCppRWn3rrLD afkleKwlEBfM0A/034F7NRd7/zsfl6ofxVi0sSuf0F87hjcGaxUfDuqje7qAv1pYL2Ox 9318ewLufNKm5DwsOEi14G95Rqa7PQsiR+JvlD8/cLaBdqHSPl2A30IZC3bFwGws+dlk QosxUQiR61IV/uKDacQQ+IaHIYfNNcLnD9neH063yYWxaWhmtd/qgcce8eUnQEQXs5Av TWRQ== X-Gm-Message-State: AOPr4FVgxb5kEkm/lAZVRD/BRrdXIIf1qMzEuaXAggLGn5GWSFSBh0Mth7LNzt8E/Xa5f2P+Hi3iduBkcBl2uQ== X-Received: by 10.157.5.245 with SMTP id 108mr8102334otd.161.1463152318767; Fri, 13 May 2016 08:11:58 -0700 (PDT) Original-Received: by 10.202.175.193 with HTTP; Fri, 13 May 2016 08:11:38 -0700 (PDT) In-Reply-To: <83postav28.fsf@gnu.org> X-Google-Sender-Auth: mmb9rIiTI2E7SNkXZAKlEi0t6kE X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203826 Archived-At: On Wed, May 11, 2016 at 12:54 AM, Eli Zaretskii wrote: >> From: Jim Meyering >> Date: Tue, 10 May 2016 21:33:15 -0700 >> Cc: Phillip Lord , emacs-devel >> >> However, now there is an additional bug in viper mode: >> >> When I run e.g., "!!" to tell it to replace the text of the current >> line with the output of some shell command, I see the usual "!" prompt >> asking me for that command in the minibuffer. Let's say I type "cat" >> then enter. So far so good. >> >> However, if I type "!!" again, this time I see "!(default cat) ", and >> let's say I want to accept that default and hit return. Then emacs >> attempts to run the command "(default cat)". Oops. Even if I type >> something, it is only appended, so if I type "cat" again, emacs runs >> "(default cat) cat". >> >> This appears to have been introduced some time on or before May 6th. > > On which branch do you see this new problem? Does it happen on > emacs-25, the release branch? > > In any case, please file a separate bug report about that, as it > doesn't seem to be related to the undo problem (AFAIU). I traced the new problem to commit 088acab3831b45e0e0749705226b8680076df4b6, aka emacs-24.5-rc3-fixed-9210-g088acab. When I revert that change and rebuild from emacs.git's master branch, that particular problem (which also caused repeated "/"-based searching to mistakenly use the "(default ...)" prefix) goes away. If it is still necessary tomorrow, I'll create a separate bug report.