all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Phillip Lord <phillip.lord@russet.org.uk>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: viper-mode undo bug introduced between Nov 10 and Nov 14
Date: Fri, 13 May 2016 08:11:38 -0700	[thread overview]
Message-ID: <CA+8g5KHQUaox8kb_A_h7JPkHyKv2-6ywQ9413AJbj=5ja=LQmw@mail.gmail.com> (raw)
In-Reply-To: <83postav28.fsf@gnu.org>

On Wed, May 11, 2016 at 12:54 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jim Meyering <jim@meyering.net>
>> Date: Tue, 10 May 2016 21:33:15 -0700
>> Cc: Phillip Lord <phillip.lord@russet.org.uk>, emacs-devel <emacs-devel@gnu.org>
>>
>> However, now there is an additional bug in viper mode:
>>
>> When I run e.g., "!!" to tell it to replace the text of the current
>> line with the output of some shell command, I see the usual "!" prompt
>> asking me for that command in the minibuffer. Let's say I type "cat"
>> then enter. So far so good.
>>
>> However, if I type "!!" again, this time I see "!(default cat) ", and
>> let's say I want to accept that default and hit return. Then emacs
>> attempts to run the command "(default cat)". Oops. Even if I type
>> something, it is only appended, so if I type "cat" again, emacs runs
>> "(default cat) cat".
>>
>> This appears to have been introduced some time on or before May 6th.
>
> On which branch do you see this new problem?  Does it happen on
> emacs-25, the release branch?
>
> In any case, please file a separate bug report about that, as it
> doesn't seem to be related to the undo problem (AFAIU).

I traced the new problem to commit
088acab3831b45e0e0749705226b8680076df4b6, aka
emacs-24.5-rc3-fixed-9210-g088acab. When I revert that change and
rebuild from emacs.git's master branch, that particular problem (which
also caused repeated "/"-based searching to mistakenly use the
"(default ...)" prefix) goes away.

If it is still necessary tomorrow, I'll create a separate bug report.



      parent reply	other threads:[~2016-05-13 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 20:46 viper-mode undo bug introduced between Nov 10 and Nov 14 Jim Meyering
2016-04-15  7:19 ` Eli Zaretskii
2016-05-11  4:33   ` Jim Meyering
2016-05-11  7:54     ` Eli Zaretskii
2016-05-13  5:01       ` Jim Meyering
2016-05-13  7:23         ` Eli Zaretskii
2016-05-13 15:11       ` Jim Meyering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+8g5KHQUaox8kb_A_h7JPkHyKv2-6ywQ9413AJbj=5ja=LQmw@mail.gmail.com' \
    --to=jim@meyering.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.