From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.bugs Subject: bug#22295: viper-mode undo bug introduced between Nov 10 and Nov 14 Date: Wed, 18 May 2016 18:09:36 -0700 Message-ID: References: <83vb2h6lfq.fsf@gnu.org> <83r3d56jrg.fsf@gnu.org> <87poso7nf5.fsf@russet.org.uk> <878tzatbte.fsf@russet.org.uk> <87k2it5bgh.fsf@russet.org.uk> <87wpmrvia7.fsf@russet.org.uk> <8737pfavrn.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1463620283 3477 80.91.229.3 (19 May 2016 01:11:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 May 2016 01:11:23 +0000 (UTC) Cc: John Wiegley , 22295@debbugs.gnu.org To: Phillip Lord Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 19 03:11:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b3CUc-0005nQ-4V for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 May 2016 03:11:14 +0200 Original-Received: from localhost ([::1]:47618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3CUb-0004wC-7V for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 21:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3CUV-0004vo-VM for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3CUQ-0001jF-SU for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3CUQ-0001jB-Nw for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b3CUQ-0004tj-HJ for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 May 2016 01:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22295-submit@debbugs.gnu.org id=B22295.146362020418742 (code B ref 22295); Thu, 19 May 2016 01:11:02 +0000 Original-Received: (at 22295) by debbugs.gnu.org; 19 May 2016 01:10:04 +0000 Original-Received: from localhost ([127.0.0.1]:57446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3CTU-0004sE-Ft for submit@debbugs.gnu.org; Wed, 18 May 2016 21:10:04 -0400 Original-Received: from mail-oi0-f65.google.com ([209.85.218.65]:35078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3CTS-0004re-4B for 22295@debbugs.gnu.org; Wed, 18 May 2016 21:10:02 -0400 Original-Received: by mail-oi0-f65.google.com with SMTP id w198so13367464oiw.2 for <22295@debbugs.gnu.org>; Wed, 18 May 2016 18:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1L6YahdL79nxOTgj3qLCu0XIWiW0bKemmCUVyrP8h30=; b=Q6PlalTDL+ER496XhR042iPgStAqGD1gM6UsCQ/r4kvNjXob0rAd/ujA8nkxYLU+MM EZfDbwSaD/h3x3cV2auEeSdyueyy5Jwj/gt6W0Bqv0hCU73HV/YpVfVIQcrm108l6Xmb 2SNv0zBjyHgpmQ5sXAK8PUpCrgQRbGzdofP3rnbxdvygH0qrgSojMGGJ8Wde1pHA4MYV ScBo2UPvid0z399m6qY/ykPLc2R1yc05pXF3giRvrqYFfrmxmUcH+nqBYy4a2fbqEzEb YndnLNlyV+coFPOhmmiWL7fhbtosnTQ/HbzsxbqGyGp0PQZekYcxXV59pcN4y/WCRIXt ysCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1L6YahdL79nxOTgj3qLCu0XIWiW0bKemmCUVyrP8h30=; b=gHD2qz5ve3bLPbMqfMOSp1z/6rzeFNVyMNoAC0jf+HZLThPswcvFMd1/uA/yXVsZBH 54fSkwJsBTOLv8dHplacwmNazt/MUhl3UPt286RV81A5eyym3if6PfXJCWDRyN/Jv5Pp aJcystWIN981NyKXw8Qcyzvcaw24iiG1+uiNILKBs7JwzeROgYcgS5LNOlThX5U6f7XS zy27omiph9FMXjzqKGTKqgxojUOAzjMzq8EUUna1F8RF2jA+qAbvc/xKStuCgENs4Js5 +28+TOALz1DoUFJ8bYQIj2eTbicxT2WzZE803JRBPKmI2Q8kfEpyN+YMO2lblKuiw5tN zzTw== X-Gm-Message-State: AOPr4FVX4qMnwUMTfrtbBxIemg46V6dq8P9Xkn5DCRvjk2gXSwnlPpiYOcJb3LMuzRSmvCz0UamfTZN/pDGe1g== X-Received: by 10.202.102.36 with SMTP id a36mr5375518oic.122.1463620196684; Wed, 18 May 2016 18:09:56 -0700 (PDT) Original-Received: by 10.202.175.193 with HTTP; Wed, 18 May 2016 18:09:36 -0700 (PDT) In-Reply-To: <8737pfavrn.fsf@russet.org.uk> X-Google-Sender-Auth: Rui-ey-kgVyIL__ETXvwWKvw7zg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118434 Archived-At: On Wed, May 18, 2016 at 2:42 PM, Phillip Lord wrote: > Jim Meyering writes: > >> On Wed, May 18, 2016 at 2:15 AM, Phillip Lord >> wrote: >>> Yeah, I was adding two undo-boundaries to rather than just one. For no >>> readily apparent reason I was directly changing the buffer-undo-list, >>> rather than calling undo-boundary. >>> >>> Anyway, that should be fixed. >> >> Confirmed. >> Thanks again for fixing all of that. > > > Let me know if you find anything else. > > John, this is a reasonably extensive change now -- affecting both > simple.el, but also a big rework of viper undo. > > To Emacs-25 or not to Emacs-25 that is the question? Perspective of a viper-mode user: including this fix in Emacs-25 is a must: without it, any existing viper-mode user will very quickly notice how "undo" appears to destroy data, seemingly unrecoverably, since "redo" does not restore it -- they'd have to go look in emacs' yank buffer.