Two formerly internal libraries that are still being required but no longer exist

Two formerly internal libraries that are still being required but no longer exist

[Jonas Bernoulli]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

I've run into these two feature inconsistencies:

- The command ~org-protocol-create-for-org~ does ~(require 'org-publish)~,
but that should now be ~ox-publish~.

- The command ~org-capture-import-remember-templates~ does ~(require
'org-remember)~, which makes sense because its purpose is to convert from
the ~org-remember~ format into the ~org-capture-templates~ format. However
~org-remember~ has been removed, so this won't work.

These issues exist in both the ~master~ and ~maint~ branches.

  Warm regards,
  Jonas

[-- Attachment #2: Type: text/html, Size: 668 bytes --]

Re: Two formerly internal libraries that are still being required but no longer exist

[Nicolas Goaziou]

Hello,

Jonas Bernoulli <jonasbernoulli@gmail.com> writes:

> I've run into these two feature inconsistencies:
>
> - The command ~org-protocol-create-for-org~ does ~(require 'org-publish)~,
> but that should now be ~ox-publish~.

Fixed. Thank you.
>
> - The command ~org-capture-import-remember-templates~ does ~(require
> 'org-remember)~, which makes sense because its purpose is to convert from
> the ~org-remember~ format into the ~org-capture-templates~ format. However
> ~org-remember~ has been removed, so this won't work.

I don't think this is an issue. This function only makes sense if user
has an old `org-remember' library lying around. Otherwise, it raises an
error. This is the actual behaviour.

The other option is to remove the function altogether.

WDYT?

Regards,

-- 
Nicolas Goaziou

Re: Two formerly internal libraries that are still being required but no longer exist

[Jonas Bernoulli]

> I don't think this is an issue. This function only makes sense if user
> has an old `org-remember' library lying around. Otherwise, it raises an
> error. This is the actual behaviour.

Makes sense, and is more friendly than the alternative.

> The other option is to remove the function altogether.

On the other hand, users will still have to somehow get their hands on that
file. So maybe a wiki page which linked to the last `org-remember.el' and
also featured the definition of `org-capture-import-remember-templates'
would be the best option.

But just leaving it as-is, works for me too.