From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: Reporting Lisp errors in dynamic modules Date: Fri, 27 Nov 2015 13:49:39 +0100 Message-ID: References: <83egfbsnu2.fsf@gnu.org> <83d1uvsm0u.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1448628642 31941 80.91.229.3 (27 Nov 2015 12:50:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 12:50:42 +0000 (UTC) Cc: Ted Zlatanov , Daniel Colascione , Philipp Stephani , Emacs development discussions To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 27 13:50:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2ITJ-00037I-NQ for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 13:49:53 +0100 Original-Received: from localhost ([::1]:56389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2ITM-0002M9-AY for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 07:49:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2IT8-0002Ia-W0 for emacs-devel@gnu.org; Fri, 27 Nov 2015 07:49:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2IT8-0000ll-1J for emacs-devel@gnu.org; Fri, 27 Nov 2015 07:49:42 -0500 Original-Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]:36494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2IT6-0000lZ-Fq; Fri, 27 Nov 2015 07:49:40 -0500 Original-Received: by lfs39 with SMTP id 39so125767192lfs.3; Fri, 27 Nov 2015 04:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=VsXFXh4pWD5VsVUGdc5z6rbsjTXqHcdBk9j30CArEfQ=; b=zGqrNY0wlqjdfvs7uoAoPAjoxT0mxfUVejmoqgved4+MhNocTo9qNeXJos6udr5KcY TvjrrYFF3svTVbu4np7v6CSg1b28865IP0eguPOh9uOB6ox45DbXo75zTNRT5QuxF6z4 2Jl9vI2adFVBd//pHKwKkxVn38DzLuZXd8CYboyJ2GICFzwMQmvXg12w0DZPbF/N/Kpq jCPuPZL8EoV4psNeQVfBHBUhHmwwQHBnQGhkGVWNDVcr3F826qWVqU1rv8+51WcfTs5+ KkynAE+K+NyKU5L5mW+UhbGe4JflMomhXNoPoAOhppsvDLt+gkUXvMHoSfcgHoSTkCzH 4T+w== X-Received: by 10.112.14.1 with SMTP id l1mr19410286lbc.131.1448628579505; Fri, 27 Nov 2015 04:49:39 -0800 (PST) Original-Received: by 10.112.202.133 with HTTP; Fri, 27 Nov 2015 04:49:39 -0800 (PST) In-Reply-To: <83d1uvsm0u.fsf@gnu.org> X-Google-Sender-Auth: MppVB_ZY3M1NEhKQBQRIx8yfpcs X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195373 Archived-At: On Fri, Nov 27, 2015 at 12:46 PM, Eli Zaretskii wrote: >> It's an implementation detail and cannot be used safely by Lisp users. >> The danger of using it is it can make core Emacs crash. > > How can it cause Emacs to crash? Can you show a specific scenario? > We should be able to prevent that. You cannot allocate a valid struct module_fun_env embedded in a save_value from Lisp (first expected argument of 'module-call'). Therefore any call to 'module-call' from Lisp is invalid. It's an implementation detail and shouldn't be used directly by users. >> We also don't want the risk of someone overriding it. > How is that different from any other primitive? It's the same. >> Also, unrelated but can I be added to the savannah emacs group? My >> savannah account is aaptel. > Please apply, and please explain your interests. I already signed the copyright assignment papers few years ago. I've already contributed a few things here and there (underwave support) and finally I initiated and spent most of a year working on this dynamic module feature, along with Philip Stephani. Is there anything else I should do?