From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-dynamic-module in Emacs Git? Date: Thu, 27 Nov 2014 16:38:48 +0100 Message-ID: References: <87wq6tu5m5.fsf@kima.orebokech.com> <85h9xwhpy9.fsf@stephe-leake.org> <87k32sh50f.fsf@lifelogs.com> <85tx1rg64e.fsf_-_@stephe-leake.org> <87siha7r3b.fsf@lifelogs.com> <87lhmz4mtj.fsf@lifelogs.com> <87sih575rc.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1417102748 4608 80.91.229.3 (27 Nov 2014 15:39:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Nov 2014 15:39:08 +0000 (UTC) To: Emacs development discussions Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 27 16:39:02 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xu19p-0000D7-Cg for ged-emacs-devel@m.gmane.org; Thu, 27 Nov 2014 16:39:01 +0100 Original-Received: from localhost ([::1]:40295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu19o-0007rq-Vx for ged-emacs-devel@m.gmane.org; Thu, 27 Nov 2014 10:39:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu19k-0007rH-SL for emacs-devel@gnu.org; Thu, 27 Nov 2014 10:38:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xu19e-0007S0-2N for emacs-devel@gnu.org; Thu, 27 Nov 2014 10:38:56 -0500 Original-Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:38752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu19d-0007Ri-Nj for emacs-devel@gnu.org; Thu, 27 Nov 2014 10:38:49 -0500 Original-Received: by mail-lb0-f179.google.com with SMTP id z11so4294996lbi.38 for ; Thu, 27 Nov 2014 07:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=i5gy2xB4P9wMaiPaeHhry2xvdQn7w/jkM8uxa7Ao6bE=; b=tCcqwRxy9/6CW515d0Hi2q5BF8C4ZdqGCbY2d6G17HaByqnztAei/J8k+2IHewO8rn 6M2RIuGfYos1mDZ549CWKPzCDysaRteXB5y1Z4OCPNFksSJhQg2Zr6XCAmEjgb887spN hdxqnLtoEOJ00/3ojQ6WWx1E7xoRyni+4mkjOG7FTPpl1ZPoWiga4fcB8fc66FPOOJWS VNQWwxhpEalKmf2kn+21ZPn1j+R+U/hVB++mGpHAioZnAdChBkPEHqyJfkNaR65pkDJh 7J+W1x1dxdNSF1oQeNuZKPwaWtCndZ8U2PZLsliAnDBIbHKVoCuEv8fV3eY0XrsfYOQ5 KWVA== X-Received: by 10.112.8.69 with SMTP id p5mr18768941lba.97.1417102728855; Thu, 27 Nov 2014 07:38:48 -0800 (PST) Original-Received: by 10.114.77.131 with HTTP; Thu, 27 Nov 2014 07:38:48 -0800 (PST) In-Reply-To: <87sih575rc.fsf@lifelogs.com> X-Google-Sender-Auth: Fvg5LJICl6EI-UBGUyT6PbXfdtI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178355 Archived-At: On Thu, Nov 27, 2014 at 3:10 AM, Ted Zlatanov wrote: > On Wed, 26 Nov 2014 18:05:55 +0100 Aur=C3=A9lien Aptel wrote: > > AA> On Tue, Nov 25, 2014 at 11:05 AM, Ted Zlatanov wro= te: >>> Push it to your Github repo >>> https://github.com/aaptel/emacs-dynamic-module so it can be reviewed. = We >>> will try to get to it quickly and merge it with the necessary ifdefs, i= f >>> you don't have them. > > AA> I've force-pushed on my repo. The branch is "dynamic-modules". It > AA> should already be properly ifdef'd and turned off by default. You can > AA> turn it on via the configure script with --with-ltdl. > > I've pushed your dynamic-modules branch (rebased against today's master > branch) to the dynamic-modules branch on the Emacs repo for review and > testing. Please use that in your repo as well. Will do. > There are just a few issues, none major: > > * two XXX comments Well, it's still experimental code, what's bothering you? > * the ChangeLog entries need rewriting (I would squash to a single > commit anyway, if that's OK with you, which would make the above > rebasing note irrelevant) I didn't write any changelog entries. Are you talking about commit messages? Not everything in there is relevant to the ChangeLog file and some might be obsolete. > * no documentation (NEWS, ELisp manual, etc.) > > For me only the first one is a blocker. The documentation is also > important--at least mention how to use this new facility in a text file > please. We can try to write it if you're unable, but it would be good to > give us a first draft at least. Sure. Where should I write this documentation? I can reuse what I wrote in my announcement [1]. 1: https://lists.gnu.org/archive/html/emacs-devel/2014-10/msg00292.html