From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: [patch] add "underwave" face attribute Date: Thu, 2 Feb 2012 01:18:23 +0100 Message-ID: References: <037B3467A9FE4EC9B681DF3B1171A539@us.oracle.com> <87obtii1y4.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1328141914 20983 80.91.229.3 (2 Feb 2012 00:18:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Feb 2012 00:18:34 +0000 (UTC) Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 02 01:18:33 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RskNi-0007h2-2N for ged-emacs-devel@m.gmane.org; Thu, 02 Feb 2012 01:18:30 +0100 Original-Received: from localhost ([::1]:34085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RskNh-0007NM-EC for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2012 19:18:29 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:49603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RskNe-0007N0-Om for emacs-devel@gnu.org; Wed, 01 Feb 2012 19:18:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RskNd-0008Lc-CM for emacs-devel@gnu.org; Wed, 01 Feb 2012 19:18:26 -0500 Original-Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:52804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RskNd-0008LY-0U for emacs-devel@gnu.org; Wed, 01 Feb 2012 19:18:25 -0500 Original-Received: by obbta7 with SMTP id ta7so2577132obb.0 for ; Wed, 01 Feb 2012 16:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=rckVHK7CJd/frYQ/EnoJAW6mWdKTm0tIhUIpg/QpQtQ=; b=nZyR2OJCTMqRe85NTrMnOqC1L+kumb2DSgGY8Z2GKcz/enuBhxDTYg7rOzNLmQQGKD OQEIjrTC0x/Ghduf5rlWc2hF2bCiPQuuqwcD2BgkMy1mQzIUOyHFTvQKHu6x+cBP/izH DqCNWQLR5f7GYdPpJc0AOkPj9bXayLVbbRw48= Original-Received: by 10.182.231.100 with SMTP id tf4mr572565obc.56.1328141904011; Wed, 01 Feb 2012 16:18:24 -0800 (PST) Original-Received: by 10.182.165.40 with HTTP; Wed, 1 Feb 2012 16:18:23 -0800 (PST) In-Reply-To: <87obtii1y4.fsf@mail.jurta.org> X-Google-Sender-Auth: zsLQfjN_HwTzj8Wlhn8THBbwqOY X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148105 Archived-At: On Thu, Feb 2, 2012 at 12:11 AM, Juri Linkov wrote: > Very nice, we could use it for `flyspell', `flymake', `next-error' > to highlight errors, etc. Indeed :) > But what to do with platforms where it's not yet supported? On a tty frame underwave underlines. As for other platforms, I've tried to write some code in the patch, but I can't compile or test it. Someone who can build emacs on windows/mac osx needs to try it and report b= ack > There should be a way to detect its availability > and to fall back to other face attributes. > > Currently `:underline' can test its support with `(supports :underline t)= '. > > Maybe `underwave' should do this with something like: > > (defface underwave > =C2=A0'((((supports :underline wave)) > =C2=A0 =C2=A0 :underline (:style wave :color "red")) > =C2=A0 =C2=A0(t > =C2=A0 =C2=A0 :underline (:style line :color "red"))) > =C2=A0"Basic underwave face." > =C2=A0:group 'basic-faces) Maybe. I'm not too familiar with this face support hierarchy stuff. I'll have a look.