From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Introduce new misc type for module function Date: Sun, 23 Apr 2017 17:19:05 +0200 Message-ID: References: <20170422160553.63385-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1492960756 5586 195.159.176.226 (23 Apr 2017 15:19:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Apr 2017 15:19:16 +0000 (UTC) Cc: Philipp Stephani , Emacs development discussions To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 23 17:19:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2JI7-0001HH-MA for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 17:19:11 +0200 Original-Received: from localhost ([::1]:39549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2JIA-0006yK-Q1 for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 11:19:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2JI5-0006yF-4d for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:19:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2JI4-00089N-DD for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:19:09 -0400 Original-Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]:35367) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2JI4-00089B-7v for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:19:08 -0400 Original-Received: by mail-it0-x232.google.com with SMTP id 70so31837977ita.0 for ; Sun, 23 Apr 2017 08:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=elqOLZsXAZKTQ2MI+mQPICRqTsguE31XP/qgjJ314g8=; b=qbOrjQY4Z0q2/HCyVMn3M9/01KrYm9c5Q9PLISh9nE0RDK2Pz5D0tMQzYQfRZ6aWNV by50QBBR+MLcawz6Naj96tgmtrn2W2WNbdowimtU2su3/otXRf1ZfWnOWc/wRLtwieRb xbYY/gF910umQb5LBvPKxDTV4QBbsLacahEFCmSfaQlieN4YIseQJp6Ev7XxnnByMD68 b9Cs58HgrbytZE7mPP5UAR+Ei6f4/NRn27/RUCmAHm4LEIvaZ3rYr687CzkrgF+F0qM4 xAHUPrn9UDG3/YAmysd3AxSK8yOMHuGkMAJcMzbLIXXCdQf9H1WLDZ034WKLyJVkNSGA A0uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=elqOLZsXAZKTQ2MI+mQPICRqTsguE31XP/qgjJ314g8=; b=GALJeayuqHzUUL+Mczw0hJf5qFPOKzTznVKy/esAIXKAIMVfvuWol6l6bEqLvWqZ05 QcQr5OiiUPWSG3iW/99pLhMnh6wZ/7fbnWpDEBt7NA4Et5KjxeSPXlyjbI+VEu6iMAty grEDs1UQmMAHdnj77z6EmFk2v7pR9MMJur21qcCWDjF0Cb4SA0ABzf8ILpB6Ufc96LzN s33JTzRfoCd5EBnDVWbWUC8ZCEWe0roAI2asnoCHSHCxr3+NWmmEB1l7H9aPCquF/+cT RbNn9c3WJNqbsxsWuZ3V7yHxmF+iCNxnG/QsQQykmZkYAt+5VQhaaz0a9XbD3CyeLI7b Ciaw== X-Gm-Message-State: AN3rC/6WqubbrPZxL+SgLMEATHuh1e4DK5GZ4nUgerUDYZDune0CrHjw M+5QuLI8+KBHq0RvAaHkrxjDUhhKYg== X-Received: by 10.84.174.131 with SMTP id r3mr27154960plb.136.1492960745492; Sun, 23 Apr 2017 08:19:05 -0700 (PDT) Original-Received: by 10.100.187.69 with HTTP; Sun, 23 Apr 2017 08:19:05 -0700 (PDT) In-Reply-To: <20170422160553.63385-1-phst@google.com> X-Google-Sender-Auth: m9E9zNek_Nb7Pcc6XxZW5ccm03k X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214242 Archived-At: Hi Philipp, Nice to see you work on modules :) * Shouldn't we try to map module function to subr instead of adding another type? * Should we get rid of make_global_ref? It serves no purpose anymore IIUC since you can't reuse emacs_values between module function calls.