From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: emacs-module.c and signaling errors Date: Fri, 27 Nov 2015 13:25:26 +0100 Message-ID: References: <83k2p7xk13.fsf@gnu.org> <87wpt7p369.fsf@tromey.com> <83d1uzxgvw.fsf@gnu.org> <5654D7CF.90001@cs.ucla.edu> <87si3vox7j.fsf@tromey.com> <56555B52.3030703@cs.ucla.edu> <837fl6xa02.fsf@gnu.org> <5655F10D.9080805@cs.ucla.edu> <83vb8ovkc5.fsf@gnu.org> <83a8q0vgb9.fsf@gnu.org> <83si3stuzn.fsf@gnu.org> <83poywtsxl.fsf@gnu.org> <565777AE.6030204@cs.ucla.edu> <83poyvst6k.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1448627503 14617 80.91.229.3 (27 Nov 2015 12:31:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 12:31:43 +0000 (UTC) Cc: Paul Eggert , Stefan Monnier , Emacs development discussions To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 27 13:31:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2IBR-00007K-IO for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 13:31:25 +0100 Original-Received: from localhost ([::1]:56303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2IBU-0006uH-AB for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 07:31:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2I5i-0005lb-GL for emacs-devel@gnu.org; Fri, 27 Nov 2015 07:25:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2I5h-0002T2-Hk for emacs-devel@gnu.org; Fri, 27 Nov 2015 07:25:30 -0500 Original-Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:36434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2I5g-0002Oz-3e; Fri, 27 Nov 2015 07:25:28 -0500 Original-Received: by lfs39 with SMTP id 39so125087964lfs.3; Fri, 27 Nov 2015 04:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=skY8NY2LNOZ4YZGoMkVy9r+MUdBbDFi8+Jtn9uubgak=; b=IvrU/yeibACQQZN9BFLNyD/+d/nP9iz2jj1VdESM1vnp9yGktGOk79zF5mqvq3/25t hCgPN3bcmUpjTY8fOU9GanS2kjPKryUZmJbDUhq/j0NMqmuLLZcu9ZzBdvTMjcxQQSig +/6r93XF2L9IXPqrWxau+ibUYCdIiMmbmfCRFe1RuPANty6t5g0YhJhznJw7h0QVWidK kQgF0SSIBJGG9meBvIAf6tcT2yZddOFXzACEjrsAB6/VtdCzsOp64Ee+PVsAU8H56+6i zERPbUm3YLznyqV3EfmZJosN0nJov8WlNvFeChZI4tHYxADZUWNN8lO6D2X0gAZhvLY3 FyNA== X-Received: by 10.25.44.213 with SMTP id s204mr19269113lfs.37.1448627127050; Fri, 27 Nov 2015 04:25:27 -0800 (PST) Original-Received: by 10.112.202.133 with HTTP; Fri, 27 Nov 2015 04:25:26 -0800 (PST) In-Reply-To: <83poyvst6k.fsf@gnu.org> X-Google-Sender-Auth: cx7Q3n3Je2TuVbWerEKJh-gyP7c X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195372 Archived-At: As tedious as it sounds, checking for errors after every API call is the safest way to go. We have to remind ourselves we're extending an editor in C. Crashing/aborting can make someone loose work. As ignorant as it will sound, working on the dynamic modules feature made me realize how Emacs core might leak memory everytime a call signals in the middle a function if you're not careful. I find this very error-prone.