From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Sun, 25 Oct 2015 19:45:09 +0100 Message-ID: References: <83r3trulse.fsf@gnu.org> <54E0D7E0.305@87.69.4.28> <83h9unukbg.fsf@gnu.org> <54E0DEF8.7020901@dancol> <83egpruiyp.fsf@gnu.org> <54E0FF93.2000104@dancol.org> <5610ED13.1010406@dancol.org> <56117F37.9060808@dancol.org> <56259FDD.8040401@dancol.org> <87zizeme8k.fsf@tromey.com> <5625B166.3080104@dancol.org> <86zizdczhp.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1445798720 22555 80.91.229.3 (25 Oct 2015 18:45:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Oct 2015 18:45:20 +0000 (UTC) Cc: Eli Zaretskii , Daniel Colascione , Stephen Leake , Emacs development discussions , Tom Tromey To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 25 19:45:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZqQIA-0002CS-Pg for ged-emacs-devel@m.gmane.org; Sun, 25 Oct 2015 19:45:18 +0100 Original-Received: from localhost ([::1]:49134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqQIA-0005Ka-Bw for ged-emacs-devel@m.gmane.org; Sun, 25 Oct 2015 14:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqQI7-0005KR-26 for emacs-devel@gnu.org; Sun, 25 Oct 2015 14:45:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqQI6-000517-4L for emacs-devel@gnu.org; Sun, 25 Oct 2015 14:45:14 -0400 Original-Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:35598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqQI2-0004z8-J3; Sun, 25 Oct 2015 14:45:10 -0400 Original-Received: by lfbn126 with SMTP id n126so92055696lfb.2; Sun, 25 Oct 2015 11:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=XA28OgCQ0Kzn9ppfT1PznqMD4pW4nlDiChmC+rXwjzU=; b=zDx/1j8WjuPL25NYNQluLdg+TZ7Mmr6ATmjQsGUCT3Jnviir2ZX+6o7/aeOY2u/HNZ 3KrqNGgIYzhcBMc2dLrsSKDstQFjuspqInvvxGqmKwxoq3BxymtSKcCs3xomwhHCH6h7 iTA78b/xEuEgaxZvLTwp6ed3JTeiQ28/75oPaSomYBK8KjZTfNE/NJTp5LHZqi7/ACmd szZtk/hctQoYi06THFahG/Wmows0bei1+N8/X4XmUR+P1S/haAD0tVebu8JCdDtSODyD cz56gvU6T3e0Sq4xuq2fqSrJo6N5mvWaA4ayGIjFRoeKRPTUj8mp0q1e0fHwTOKKJ96R 4KnQ== X-Received: by 10.112.169.98 with SMTP id ad2mr14733585lbc.2.1445798709615; Sun, 25 Oct 2015 11:45:09 -0700 (PDT) Original-Received: by 10.112.167.73 with HTTP; Sun, 25 Oct 2015 11:45:09 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: o5reRud9npbIkdFSdlKU_WaxpC8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192611 Archived-At: On Sun, Oct 25, 2015 at 5:31 PM, Philipp Stephani wrote: > I mainly use Clang, which is almost, but not entirely compatible with GCC. > If the flag causes problems for you, just drop it, of course it's not > required. Sure, but it looks useful so I'd like to make it work. In any case I've merged you PR and I've finished the `load' integration, which makes `require' works now. `Fload' does a lot of stuff and I'm short-circuiting a lot of it for modules. I would like some review on this [1] specifically src/lread.c changes. Do we need to do things before the function returns? I'm guessing we should close the fd returned by `openp' but if you grep for openp usage in the emacs codebase you'll notice some occurence where they don't even store the fd... https://github.com/aaptel/emacs-dynamic-module/commit/dc5cc38a50ea31b0d64c6664352c3bce88121411