all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ryan Mulligan <ryan@ryantm.com>
To: emacs-devel@gnu.org
Subject: [PATCH] fix byte-recompile-directory bug
Date: Wed, 1 Jan 2014 20:57:34 -0800	[thread overview]
Message-ID: <CA+56x28xQRW0dXfrYY6nrLck9yLJ07UNL5UEuUzkh1G6rWiZLg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

Hello.

This patch fixes the bug I reported earlier today:

emacs -Q --eval "(byte-recompile-directory
\"/home/ryantm/projects/emacs/expand-region.el/\" 0)"

writes

Error: IO error reading /home/ryantm/projects/emacs/expand-region.el: Is a
directory

in the *Compile-Log* buffer and does not compile the files.

patch follows.

Regards
Ryan Mulligan

=== modified file 'lisp/emacs-lisp/bytecomp.el'
--- lisp/emacs-lisp/bytecomp.el 2014-01-01 07:43:34 +0000
+++ lisp/emacs-lisp/bytecomp.el 2014-01-02 04:53:00 +0000
@@ -1598,7 +1598,7 @@
        (while directories
         (setq directory (car directories))
         (message "Checking %s..." directory)
-         (dolist (file (directory-files directory))
+         (dolist (file (delete "." (delete ".." (directory-files
directory))))
            (let ((source (expand-file-name file directory)))
             (if (file-directory-p source)
                 (and (not (member file '("RCS" "CVS")))

[-- Attachment #2: Type: text/html, Size: 3420 bytes --]

             reply	other threads:[~2014-01-02  4:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-02  4:57 Ryan Mulligan [this message]
2014-01-02 19:31 ` [PATCH] fix byte-recompile-directory bug Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+56x28xQRW0dXfrYY6nrLck9yLJ07UNL5UEuUzkh1G6rWiZLg@mail.gmail.com \
    --to=ryan@ryantm.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.