From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: package.el strings Date: Thu, 26 Apr 2018 15:31:24 +0900 Message-ID: References: <83y3rpeubc.fsf@gnu.org> <07C02D08-66BB-4454-AA25-B512BFC39A2A@gmail.com> <83vamk965y.fsf@gnu.org> <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> <87lgdarcwi.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_778B3876-FDDD-41D8-A284-6C4AD13D9F4C" X-Trace: blaine.gmane.org 1524724222 31703 195.159.176.226 (26 Apr 2018 06:30:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Apr 2018 06:30:22 +0000 (UTC) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 26 08:30:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBaQ5-0008AH-Az for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 08:30:17 +0200 Original-Received: from localhost ([::1]:40548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBaSC-0007uS-5d for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 02:32:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBaRL-0007u5-BK for emacs-devel@gnu.org; Thu, 26 Apr 2018 02:31:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBaRG-0004QN-Aj for emacs-devel@gnu.org; Thu, 26 Apr 2018 02:31:35 -0400 Original-Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:41041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBaRG-0004Pa-0M for emacs-devel@gnu.org; Thu, 26 Apr 2018 02:31:30 -0400 Original-Received: by mail-pf0-x231.google.com with SMTP id v63so7840490pfk.8 for ; Wed, 25 Apr 2018 23:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=LjJ8FiBxWgqme9SVNRlYO5aiH0/v7pUA6Fa3qQndGHE=; b=h8D/QOXoB9ELEIDJfa2KHMJJsJZ1qaIshtvL8iwZVCIGgv78FL5gcy+P2Hr4ELltvm LLcZ8baNhFs1yTx420sTBKWDmrCij4Rwgwr1qK8M6pIsl11K4jVs+Mm/KG0PNybdN/GC renu2QzbnFiZssGzATQFVs7cN+1MCHAbDjprnMjOFDRddvxlZVZvkjQIh5rATi0NZAvC 6vOnm/lJOdMPaWVp9YodG/WPxTuOo8n0BUXZ5Kt0WgWThc5Bti4PdPtmGN3xf2b30CFl a6DLUI52oN0FpNnWeryMasj2W5Qfvrz2JWbmW3cbcClEWm2I8ar1Cx0Jmhh7d5kLqtQB ODlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=LjJ8FiBxWgqme9SVNRlYO5aiH0/v7pUA6Fa3qQndGHE=; b=TzbDgMfvMaDEjNSb3ry6srh81PWA8nk04H3JnUWODdne7RSU/E7Y7/uIOH2iRMW+1X TNOPM4kePyOf2avZFUjnnJBhudYnSU6nGXMUheiaTuqkMHVRoZCaJN78bEj9U8Oerw/l T3Ax0yirvs/5mtLfjXN1ZVSqhH7q2Bf9p7U6jCp+5W91VVZ1xs+/Xs7aGzY//ho2rNbJ mfvyQK57ppegfc4mpvtKJhfFu3IFXCepLtKUiUAA+Sv+Tj3xWjo8m+UxqWto/thrr9ia sq6LR+iLsYniJlKfMI5NHJMDYBrfNSO6SBg7IdZ5K06Mn6ZgFtSF5z1oI70FkjSt7Wx8 P/cA== X-Gm-Message-State: ALQs6tC/QluchR2dUXhEQv1TBeTVJM6kRJeE5y1DUx1cDZMhYWExo+d/ eawSqaHdAf4L3Oo3LxeEhU3gbg== X-Google-Smtp-Source: AIpwx48HbRqa4p5cEbJ7hrRMeXIi229x9a7lIKjfuTC/f+xKZkG6ovs3iy4R8VKyH9iKUOejb3Hbag== X-Received: by 2002:a17:902:694a:: with SMTP id k10-v6mr31414886plt.161.1524724288854; Wed, 25 Apr 2018 23:31:28 -0700 (PDT) Original-Received: from [192.168.1.7] (pl31219.ag0304.nttpc.ne.jp. [111.89.224.243]) by smtp.gmail.com with ESMTPSA id 125sm24636086pfc.145.2018.04.25.23.31.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 23:31:27 -0700 (PDT) In-Reply-To: <87lgdarcwi.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.6.18) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224899 Archived-At: --Apple-Mail=_778B3876-FDDD-41D8-A284-6C4AD13D9F4C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 26, 2018, at 10:10, Noam Postavsky wrote: >=20 >=20 >> Almost 9 months and nothing in master. Was there anything wrong with >> the code? >=20 > I think the problem is more a lack of people who "make changes in > package.el". Although there's enough that your patch no longer = applies > cleanly. I thought so, but thank you for getting back to me. > error: patch failed: lisp/emacs-lisp/package.el:3262 > error: lisp/emacs-lisp/package.el: patch does not apply I'll fix the issues and will resubmit. > Some minor comments below. >=20 >> +;; The terminating comment could be a generic string that is not in = English >> (unless (search-forward (concat ";;; " file-name ".el ends = here")) >> (error "Package lacks a terminating comment")) >=20 > Should that be a FIXME or TODO? If we consider l10n and the function of this string, there is no reason = this string should be in English (or in any native language for that = matter). I don't know what that makes it. I'd say FIXME. >> (defun package-menu--prompt-transaction-p (delete install upgrade) >=20 >> + (format "%s%s%s%s" >=20 > This kind of format call is that same as concat, right? I'm not sure I understand the question. This format call produces = messages that are semantically equivalent to the original concat calls = but the concat calls were not localizable so I changed them to something = that we'll eventually be able to properly extract and localize. There are probably ways to use concat to produce localizable strings = though. >> + (message "Operation finished. Packages that are no = longer needed: %d. Type `%s' to remove them" > ^ = ^ > Double spacing = Double spacing >=20 > This line is getting pretty long, perhaps it should be broken up? I guess you mean the line of code? Jean-Christophe Helary ----------------------------------------------- http://mac4translators.blogspot.com @brandelune --Apple-Mail=_778B3876-FDDD-41D8-A284-6C4AD13D9F4C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Apr 26, 2018, at 10:10, Noam Postavsky <npostavs@gmail.com> = wrote:


Almost 9 = months and nothing in master. Was there anything wrong with
the code?

I think = the problem is more a lack of people who "make changes in
package.el".  Although there's enough that your patch no = longer applies
cleanly.

I = thought so, but thank you for getting back to me.

   error: patch failed: = lisp/emacs-lisp/package.el:3262
   error: = lisp/emacs-lisp/package.el: patch does not apply

I'll = fix the issues and will resubmit.

Some minor = comments below.

+;; The terminating comment could be a generic string that is = not in English
    (unless = (search-forward (concat ";;; " file-name ".el ends here"))
=       (error "Package lacks a terminating = comment"))

Should that be a = FIXME or TODO?

If we consider l10n and the function of this = string, there is no reason this string should be in English (or in any = native language for that matter). I don't know what that makes it. I'd = say FIXME.

(defun package-menu--prompt-transaction-p (delete install = upgrade)

+   (format "%s%s%s%s"

This kind of format call is that = same as concat, right?

I'm not sure I understand the question. This = format call produces messages that are semantically equivalent to the = original concat calls but the concat calls were not localizable so I = changed them to something that we'll eventually be able to properly = extract and localize.

There are = probably ways to use concat to produce localizable strings = though.

+ =             &n= bsp;  (message "Operation finished. Packages that are no = longer needed: %d. Type `%s' to remove them"
=             &n= bsp;           &nbs= p;            =           ^ =             &n= bsp;           &nbs= p;            =  ^
=             &n= bsp;           &nbs= p;            =           Double = spacing =             &n= bsp;           &nbs= p;Double spacing

This line is getting = pretty long, perhaps it should be broken up?

I = guess you mean the line of code?


Jean-Christophe Helary
-----------------------------------------------
http://mac4translators.blogspot.com @brandelune


= --Apple-Mail=_778B3876-FDDD-41D8-A284-6C4AD13D9F4C--