From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#70007: [PATCH] native JSON encoder Date: Sat, 24 Aug 2024 21:45:57 +0200 Message-ID: References: <1BF559D1-DB9F-4FEB-90ED-72E0EFD76424@gmail.com> <86wmpphrg7.fsf@gnu.org> <4589243D-C11A-45C1-AF3E-6F4A5BADEB54@gmail.com> <864jcrindg.fsf@gnu.org> <291DD5F1-85B8-4647-A40A-EBBD4C51E253@gmail.com> <8634sbijfx.fsf@gnu.org> <2CF47DA5-A65B-47C4-A28A-6FEE1469BD13@gmail.com> <86cyrdfuai.fsf@gnu.org> <3139C8FE-5C67-4FE3-B940-F449DA73E76C@gmail.com> <86le5zdfbi.fsf@gnu.org> <4C93E902-282D-4408-B449-C8E771B2B3E4@gmail.com> <86cyr7agjo.fsf@gnu.org> <850DEC32-F318-4F3E-BA87-55FC6DC74CD3@gmail.com> <86ikvpnbj5.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22076"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 70007@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 24 21:47:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shwjQ-0005bU-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Aug 2024 21:47:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shwjE-0007iD-0r; Sat, 24 Aug 2024 15:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shwjB-0007hx-OS for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 15:47:13 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shwjB-0007G8-F7 for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 15:47:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=MPSJeUpOlIN0a9DhA19usChVKVZLdIc2esos5+jCKdw=; b=sGX6CTCvjQRqUjBcSO3i5HxAzbmKYznC6NpXdmOlT7u5B8KtQh/drD/d1dA1JMUw29LirgjCzFqCEOCXmpByjZVB+Pn1FH0vyJhVpu4MtIEpL9VMLtZhghDgYhnOTiKPyZF8KGxhw8GY68oxYP10KW8YV1XGRmd2BC57t82TNHHTbWYv8OE6q+jKK0kT7SFU+805EG7QlzlVQQOe9tWV4u9ijAz5aKCUCAJnSRALj7YL6qjsopQ4lSKlwLjmzNIjaFT9sGbKO7onexBuXpLBvG3PoTEM3HSzM6FTMx6R/w6kWfuUhyymLZpEhWCn24DbjN9xAYq2HN0EXaKG0bKYTw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shwjy-00016L-Ap for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2024 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70007-submit@debbugs.gnu.org id=B70007.17245288774222 (code B ref 70007); Sat, 24 Aug 2024 19:48:02 +0000 Original-Received: (at 70007) by debbugs.gnu.org; 24 Aug 2024 19:47:57 +0000 Original-Received: from localhost ([127.0.0.1]:41935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shwjs-000162-R4 for submit@debbugs.gnu.org; Sat, 24 Aug 2024 15:47:57 -0400 Original-Received: from mail-lf1-f49.google.com ([209.85.167.49]:48414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shwjq-00015i-SH for 70007@debbugs.gnu.org; Sat, 24 Aug 2024 15:47:55 -0400 Original-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-533488ffaddso3970188e87.1 for <70007@debbugs.gnu.org>; Sat, 24 Aug 2024 12:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724528760; x=1725133560; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=MPSJeUpOlIN0a9DhA19usChVKVZLdIc2esos5+jCKdw=; b=A8lwKNRKp5eHGEYYuSF9KkeQQFN9xmKUWlj44M9+6WLgnJCjib5vrF70wNmUwPFr1R 53J1MRuObf6tvuOzLJytpkvvDbCl++F5P0mxc5ePnAQOrEDCXA00XDszTXyZBHrJo/zA qpYCSi84rjW6DVQfzYF/hMcmWCu1oFXn4IPz5fRGQkERI0xprnCva8Hin0qOddOpxDAj rzbBokxZqc2ndRufGT1gGCwuf2XRtJAie/zCeVr2zgCeHcvkk1XWRYTgqjPnu7WlzVDP qX76wp7Q35I9jQhccfxqLJ7q8vq8b1c8anhSrAtL/GLgT+r1+g1/fokxHS1hEfL1y5lm GCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724528760; x=1725133560; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MPSJeUpOlIN0a9DhA19usChVKVZLdIc2esos5+jCKdw=; b=n5jdbq1AmGTep+G8vbHTOhXrvRkNmUxgg0q0h1+HJJw6TFTIzJKtdjNSr8LZrDMXOz GXZuuQZrmu6FDEyGiVPiaf/UDcrYhIsAS557ylElvlYQnupRNIwGi3MjIxCmBk/zJxLy 0AgO+GlFf1GH91+0jmbv3Wa0WrK9187OuEsfju9Gp43oIClYASPBM/gc4sjrWYg81qwc YddqMmGSkCxZwJ16pOoqjEgrozJTkSAw4NJaoraqwmOmYimLkpqSPanuhRAkOmiMFcic 3nnCspZoWpSdDw0ErzQYQB5ED0S6BTk8XmSAvAGH8DFt8uEJfrc2/IvDEntFDaajzKC6 2X7g== X-Forwarded-Encrypted: i=1; AJvYcCViMx43NE9QF0cSWZiv07oiDufhjaPnDG73RcEhvA7JpAunMzZXCSocRkvtXdWpTmhfDfH31g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxNHjpbH1+XHEsbUPoXXM84aO8vlMKCut+Pw3zwKnCT5ZZzqNfN wISpnhWatt5oCsJpztM3VGR2GywL19wEG5pAzpwq1kN0HSJ5adao X-Google-Smtp-Source: AGHT+IEgn0BeDoJC4oWGGksSv7yFkgf5exwdPOirXSOaVZFS3uMcc3OprmZQGq5Bp9kkvVXmuxOz7A== X-Received: by 2002:a05:6512:2342:b0:52e:9b68:d2da with SMTP id 2adb3069b0e04-5343875fe4cmr4023424e87.9.1724528759335; Sat, 24 Aug 2024 12:45:59 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5334ea29321sm934168e87.25.2024.08.24.12.45.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Aug 2024 12:45:59 -0700 (PDT) In-Reply-To: <86ikvpnbj5.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290698 Archived-At: 24 aug. 2024 kl. 18.14 skrev Eli Zaretskii : > We are very late in the release process to make such changes without > reservations. We should have discussed this much earlier, but that's > water under the bridge. Yes, sorry about not following this through in time. But here we are. > Since this could potentially (albeit unlikely) break someone's code, > I'm okay with making this change, but with a twist: let's have a > variable which could be let-bound around the call to json-serialize, > to make the result a multibyte string instead of the default unibyte. > This is so if someone comes back crying that we broke his/her code, > they could have an easy fire escape. Sure, but it's a bit annoying to saddle us with some baggage that we = never expect to be actually used. And for that matter, it's no easier to bind a variable around the call = than putting a call to `decode-coding-string` around it, is it? We could = describe that in NEWS. The null option is to do nothing and stick to what we have now. It's not = a terrible choice either. > P.S. Of course, the fact that the result is a unibyte string should be > mentioned in the doc string. Yes, definitely.