From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65113: Emacs-29 and master csharp-mode with broken treesit Date: Mon, 07 Aug 2023 07:46:05 +0200 Message-ID: References: <83fs4wp4hc.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1375"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65113@debbugs.gnu.org To: Eli Zaretskii , J M , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 07 07:47:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSt5I-00009M-Do for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Aug 2023 07:47:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSt59-00019m-F2; Mon, 07 Aug 2023 01:47:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSt56-00019M-N7 for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 01:47:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSt54-0002rN-UY for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 01:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSt54-00023X-IE for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 01:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Aug 2023 05:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65113 X-GNU-PR-Package: emacs Original-Received: via spool by 65113-submit@debbugs.gnu.org id=B65113.16913871757837 (code B ref 65113); Mon, 07 Aug 2023 05:47:02 +0000 Original-Received: (at 65113) by debbugs.gnu.org; 7 Aug 2023 05:46:15 +0000 Original-Received: from localhost ([127.0.0.1]:60349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSt4J-00022L-Co for submit@debbugs.gnu.org; Mon, 07 Aug 2023 01:46:15 -0400 Original-Received: from out-99.mta0.migadu.com ([2001:41d0:1004:224b::63]:15345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSt4E-000227-88 for 65113@debbugs.gnu.org; Mon, 07 Aug 2023 01:46:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1691387168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyc5yr7lITtI+vOf1tWR2Rv4/3FUQtszjsuvscPWyvg=; b=zVzgC2z3T2UXkhYcXsnfAJk79+FzkuvM/q8kWctatItY7tW5odYSJFAZE0nYdhb85sTQh9 r3ZxGtExBQPLtv+w9ra0rLGxKH2mr5tWAhhsc17SQ//3MbY5x1Eyaw2bPyjphiSvoPF3V0 2iNum7ccup7oHV9wBGI0ALiQwL0HK1Ml5KvjWk9DyxZILTkwNmE/ScCVF000Spym/lByyi 5sKFMTqF9EFFoB48FSSPGdsS2IqonLLrMsYS+0o2VIpInik/UldiknqUVXcFKVF4fbt6nQ sXBhnWvU1b3tnlHOdvYHiiWDYgL/5BqzZB0TkQug+hWm9kMCF3eApqJhBZtPHA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <83fs4wp4hc.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266872 Archived-At: On 6 August 2023 17:36:47 CEST, Eli Zaretskii wrote: >> From: J M >> Date: Sun, 6 Aug 2023 16:03:45 +0100 >>=20 >> Treesit is broken for csharp-mode in the latest version in master and e= macs-29 and therefore does not provide syntax highlighting=2E =EF=BF=BC >>=20 >> The latest grammar repository (https://github=2Ecom/tree-sitter/tree-si= tter-c-sharp) has removed the keyword void_keyword=2E >>=20 >> Please see attached the patch to resolve the issue=2E > >Thanks, but your patch will not work with the older version of the >grammar library, right? Is it possible to make a patch that will work >with both? Wed cannot rely on users having the latest grammar >versions, so a backward-compatible change is much more preferable=2E We've had some similar patches lately that you can use for inspiration=2E Thanks, Theo