From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Harald Hanche-Olsen <hanche@math.ntnu.no>
Cc: 12447@debbugs.gnu.org
Subject: bug#12447: 24.1.50; Stuck in garbage collection on OS X
Date: Sat, 15 Sep 2012 11:55:55 +0200 [thread overview]
Message-ID: <C8745280-67ED-4B37-A33B-D033FF62ABA5@swipnet.se> (raw)
In-Reply-To: <20120914.230819.731988138196046556.hanche@math.ntnu.no>
Hello.
I think this is probably the same bug as in #12326. I.e. a timer gets added over and over again.
Please consider how to fix the original problem as described in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12326#11 before removing the break statement.
Jan D.
14 sep 2012 kl. 23:08 skrev Harald Hanche-Olsen <hanche@math.ntnu.no>:
> This concerns emacs built with --with-ns from trunk on OS X.
>
> To start with the symptom: Emacs seems to freeze, and spends a lot of
> CPU time. Taking a sample with Activity monitor appears to indicate a
> very deeply nested mark_object calls; from this I conclude that the
> problem appears to happen in GC.
>
> How to trigger the symptom: I always got it by trying to send an email
> message with a large attachment. My mail client of choice is Mew, but
> I suspect that any activity triggering garbage collection will also
> trigger the bug.
>
> After bisecting, I come to the conclusion that this revision is to
> blame:
>
> revno: 109470
> committer: Jan D. <jan.h.d@swipnet.se>
> branch nick: trunk
> timestamp: Mon 2012-08-06 18:09:02 +0200
> message:
> * keyboard.c (timer_check_2): Add break so timer_check returns next timeout.
>
> That revision only adds a single line of code. I also find that the
> bug disappears if I patch the current tip of trunk (revision 110013)
> as follows, which undoes revision 109470:
>
> === modified file 'src/keyboard.c'
> --- src/keyboard.c 2012-09-13 02:21:28 +0000
> +++ src/keyboard.c 2012-09-14 19:12:15 +0000
> @@ -4484,7 +4484,6 @@
> }
>
> nexttime = make_emacs_time (0, 0);
> - break;
> }
> else
> /* When we encounter a timer that is still waiting,
>
>
> I suppose the break was added for a good reason, so this is probably
> not the right thing. But it does cure the present problem.
>
> (This bug is also discussed on the emacs-devel list, in the thread
> titled "Emacs seems awfully unstable on OS X lately".)
>
> There seems to be a second bug, introduced later, that causes crashes
> (as opposed to hangs). I mention this because the second bug could
> interfere with attempts to work on this one. I will endeavour to track
> down the other bug as well.
>
> - Harald
next prev parent reply other threads:[~2012-09-15 9:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 21:08 bug#12447: 24.1.50; Stuck in garbage collection on OS X Harald Hanche-Olsen
2012-09-15 9:55 ` Jan Djärv [this message]
2012-09-15 11:07 ` Harald Hanche-Olsen
2012-09-15 12:31 ` Eli Zaretskii
2012-09-15 13:19 ` Harald Hanche-Olsen
2012-09-15 13:56 ` Eli Zaretskii
2012-09-15 14:23 ` Harald Hanche-Olsen
2012-09-15 14:37 ` Eli Zaretskii
2012-09-15 18:59 ` Jan Djärv
2012-09-16 9:15 ` Dmitry Gutov
2012-09-16 10:31 ` Eli Zaretskii
2012-09-16 10:44 ` Dmitry Gutov
2012-09-16 11:53 ` Eli Zaretskii
2012-09-16 12:07 ` Dmitry Gutov
2012-09-16 12:39 ` Eli Zaretskii
2012-09-16 13:25 ` Dmitry Gutov
2012-09-16 13:47 ` Eli Zaretskii
2012-09-16 14:25 ` Dmitry Gutov
2012-09-16 14:54 ` Eli Zaretskii
2012-09-16 15:56 ` Dmitry Gutov
2012-09-18 15:05 ` Eli Zaretskii
2012-09-18 17:29 ` Jan Djärv
2012-09-18 20:08 ` Eli Zaretskii
2012-09-19 0:27 ` Dmitry Gutov
2012-09-19 2:54 ` Eli Zaretskii
2012-09-19 7:41 ` Harald Hanche-Olsen
2012-09-19 15:21 ` Eli Zaretskii
2012-09-19 9:54 ` Dmitry Gutov
2012-09-19 15:24 ` Eli Zaretskii
2012-09-19 16:21 ` Dmitry Gutov
2012-09-19 16:38 ` Eli Zaretskii
2012-09-19 18:29 ` Dmitry Gutov
2012-09-20 4:04 ` Chong Yidong
2012-09-20 16:01 ` Eli Zaretskii
2012-09-21 3:31 ` Chong Yidong
2012-09-21 7:14 ` Eli Zaretskii
2012-09-21 9:09 ` Chong Yidong
2012-09-21 9:54 ` Eli Zaretskii
2012-09-21 14:26 ` Chong Yidong
2012-09-22 13:18 ` Eli Zaretskii
2012-09-21 10:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8745280-67ED-4B37-A33B-D033FF62ABA5@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=12447@debbugs.gnu.org \
--cc=hanche@math.ntnu.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.