From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: Low redisplay performance (23 regression) Date: Thu, 30 Apr 2009 08:44:23 -0400 Message-ID: References: <4870CC42-A08E-4BE9-B566-0F4DA7AB0B74@gmail.com> <878wlj228q.fsf@freebits.de> <87r5zb4auv.fsf@thinkpad.tsdh.de> <878wli4tp6.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: multipart/signed; boundary=Apple-Mail-32-795258488; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1241095522 5396 80.91.229.12 (30 Apr 2009 12:45:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Apr 2009 12:45:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 30 14:45:13 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LzVdH-0007p7-Vv for ged-emacs-devel@m.gmane.org; Thu, 30 Apr 2009 14:44:56 +0200 Original-Received: from localhost ([127.0.0.1]:47721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzVdH-0003jk-CW for ged-emacs-devel@m.gmane.org; Thu, 30 Apr 2009 08:44:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzVcu-0003UW-Kz for emacs-devel@gnu.org; Thu, 30 Apr 2009 08:44:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzVcp-0003OO-H8 for emacs-devel@gnu.org; Thu, 30 Apr 2009 08:44:31 -0400 Original-Received: from [199.232.76.173] (port=46066 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzVcp-0003O5-AQ for emacs-devel@gnu.org; Thu, 30 Apr 2009 08:44:27 -0400 Original-Received: from mail-qy0-f116.google.com ([209.85.221.116]:61275) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzVco-0001Cd-RX for emacs-devel@gnu.org; Thu, 30 Apr 2009 08:44:27 -0400 Original-Received: by qyk14 with SMTP id 14so3432172qyk.14 for ; Thu, 30 Apr 2009 05:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=NXDk3E3fmWYMBCa594NeZ3ISdJUfmtoOauniJ8sS5Kw=; b=S/L5yNK42qzr2WjfnC1XkiAXTGgxsZOOZiIEk2sTCdStiuOoK0nhJR8K2Op9qYgGhU gx53OygVkHU3QJA+kur6MDptpSOzMFT9uK+vY573h41IGTkxxczQ7Y9FzvTLd7wuZ/X6 ILgM1fCQSpcv50rviRbcT67YLd7OH/eUyYct8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=TcRY/GN/KThcEQfqzFlb9cg6aA3S/ekPZ1raxY+GSUvkfW8JQydUCiXg8iP74UOrEN NzrUFb+/Zz01cRsKVSIAc6NecTtiuufgLiIPvg1K9Jy2DNQV1+wDUfLTgpntaC6c0tp+ foIeQk8fhlLH3bvno1DPAI3sqV0Pv3NsZvCn0= Original-Received: by 10.224.29.2 with SMTP id o2mr1730005qac.102.1241095466400; Thu, 30 Apr 2009 05:44:26 -0700 (PDT) Original-Received: from scarlett.local (pool-71-126-40-195.pitbpa.east.verizon.net [71.126.40.195]) by mx.google.com with ESMTPS id 26sm3894023qwa.46.2009.04.30.05.44.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 30 Apr 2009 05:44:25 -0700 (PDT) In-Reply-To: <878wli4tp6.fsf@cyd.mit.edu> X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110575 Archived-At: --Apple-Mail-32-795258488 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On Apr 30, 2009, at 1:05 AM, Chong Yidong wrote: > On further investigation, I found that the problem can be solved > with a > relatively safe change to handle_face_prop, so that it tells > face_at_buffer_position what the base face id is rather than having > face_at_buffer_position recalculate it each time the redisplay loop > wants to display the next face (!). I've checked in the fix. Thanks. Kudos to you and Yamamoto Mitsuharu for finding these problems. In the case that I documented, I see a big speedup, so that's good. I still see other performance problems. This one is easier to reproduce, I hope: Emacs -Q open file (e.g., src/emacs.c) (setq redisplay-dont-pause t) Scroll down page-wise using PgDown [about 3 seconds] C-x 5 2, move frame to the right so that they're side-by-side Switch back to first frame Home, then scroll down page-wise using PgDown [about 5 seconds} It seems to me that this slow-down happens when the same buffer is shown in another frame, but not if another buffer is shown. --Apple-Mail-32-795258488 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICED6shx13jEDrq0eL8FRq5ykwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTAyMDgwMVoXDTA5MTIwOTAyMDgw MVowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDOdo6kAwlkBxUb8dj4saMbYg4SVng8CUePFn3cjjWrakBTbUVa4Z0n wlUxr7AitEeKhBy5nGhu96+jKUPrCwYNRCZ0l2ovvuGq4z1m1nZ5/c8WvFlVhieuxXMUfmb/O7D3 IojoX6iS8n5MNNU2IWNNT/AD3vOl6DKgOtOw4J9y+QIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAIjI8yEW wkiEfA9PMgpjnD6KyCXT0iZjHhW2PkR53yZZLUoTboHnKgsFwYp/gzzIL8J5cvZaRUyMUzXDufPP dRmxxCs2jXXLDD/8bvdvOuMzqgYoFA73fAfsC8S6qUL1PayZ90J8CZHNhDwqWqOA56T+DdKUegJT sqoHKh6OnypTMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA+rIcdd4xA66tH i/BUaucpMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA5MDQzMDEyNDQyM1owIwYJKoZIhvcNAQkEMRYEFJL9PnOUBZYUZ2AnYDPkJjnocSXz MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQPqyHHXeMQOurR4vwVGrnKTCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQPqyHHXeMQOurR4vwVGrnKTANBgkqhkiG9w0B AQEFAASBgGtXU/xKtTxaXew+89Bs/kKOHDP3MgLrvIfUmalbndYiSNPHRE44N6sG1OwCT1ZIu17B 6xcY3u/WwukKAcM7nwgk1ZBtnCuj9jiTRVR662m19/1XNAhMfb6U0Kts2cgVP/l0BL+X54ssUqZP fs6pmi0aTN/cz3TH4tOW0dkg72dBAAAAAAAA --Apple-Mail-32-795258488--