Bootstrap fails.

Bootstrap fails.

[Lute Kamstra]

Hi Miles,

This change broke bootstrapping for me.

2005-06-17  Miles Bader  <miles@gnu.org>

	* mh-customize.el (mh-folder-body, mh-folder-cur-msg)
	(mh-folder-cur-msg-number, mh-folder-date, mh-folder-followup)
	(mh-folder-msg-number, mh-folder-refiled, mh-folder-subject)
	(mh-folder-tick, mh-folder-to, mh-index-folder)
	(mh-letter-header-field, mh-show-cc, mh-show-date)
	(mh-show-header, mh-show-pgg-good, mh-show-pgg-unknown)
	(mh-show-pgg-bad, mh-show-signature, mh-show-to, mh-show-from)
	(mh-show-xface, mh-speedbar-folder, mh-speedbar-selected-folder)
	(mh-speedbar-folder-with-unseen-messages)
	(mh-speedbar-selected-folder-with-unseen-messages)
	(mh-folder-msg-number, mh-folder-subject, mh-folder-followup)
	(mh-folder-subject): Remove "-face" suffix from face names.
	(mh-folder-body, mh-folder-cur-msg, mh-folder-cur-msg-number)
	(mh-folder-date-face, mh-folder-followup-face)
	(mh-folder-msg-number-face, mh-folder-refiled-face)
	(mh-folder-subject-face, mh-folder-tick-face, mh-folder-to-face)
	(mh-index-folder-face, mh-letter-header-field-face)
	(mh-show-cc-face, mh-show-date-face, mh-show-header-face)
	(mh-show-pgg-good-face, mh-show-pgg-unknown-face)
	(mh-show-pgg-bad-face, mh-show-signature-face, mh-show-to-face)
	(mh-show-from-face, mh-show-xface-face, mh-speedbar-folder-face)
	(mh-speedbar-selected-folder-face)
	(mh-speedbar-folder-with-unseen-messages-face)
	(mh-speedbar-selected-folder-with-unseen-messages-face): 
	New backward-compatibility aliases for renamed faces.
	(mh-folder-body-face, mh-folder-cur-msg-face)
	(mh-folder-cur-msg-number-face, mh-folder-date-face)
	(mh-folder-followup-face, mh-folder-msg-number-face)
	(mh-folder-deleted-face, mh-folder-refiled-face)
	(mh-folder-subject-face, mh-folder-address-face)
	(mh-folder-scan-format-face, mh-folder-to-face)
	(mh-index-folder-face, mh-show-cc-face, mh-show-date-face)
	(mh-show-header-face, mh-show-pgg-good-face)
	(mh-show-pgg-unknown-face, mh-show-pgg-bad-face)
	(mh-show-to-face, mh-show-from-face, mh-show-subject-face)
	(mh-speedbar-folder-with-unseen-messages)
	(mh-speedbar-selected-folder-with-unseen-messages): 
	Use renamed MH-E faces.

The patch below gets bootstrap working again.  Can you confirm that
it's the right fix?

I tried to find information on the face-alias property, but couldn't
find anything.  It should probably be documented in the Lisp Manual.

Lute.


Index: lisp/mh-e/mh-customize.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mh-e/mh-customize.el,v
retrieving revision 1.14
diff -c -r1.14 mh-customize.el
*** lisp/mh-e/mh-customize.el	17 Jun 2005 01:29:30 -0000	1.14
--- lisp/mh-e/mh-customize.el	17 Jun 2005 08:48:46 -0000
***************
*** 2156,2164 ****
    "Face used to highlight body text in MH-Folder buffers."
    :group 'mh-folder-faces)
  ;; backward-compatibility alias
! (put 'mh-folder-body 'face-alias 'mh-folder-body)
! ;; backward-compatibility alias
! (put ''mh-folder-body-face 'face-alias ''mh-folder-body)
  
  (defvar mh-folder-cur-msg-face 'mh-folder-cur-msg
    "Face used for the current message line in MH-Folder buffers.")
--- 2156,2162 ----
    "Face used to highlight body text in MH-Folder buffers."
    :group 'mh-folder-faces)
  ;; backward-compatibility alias
! (put 'mh-folder-body-face 'face-alias 'mh-folder-body)
  
  (defvar mh-folder-cur-msg-face 'mh-folder-cur-msg
    "Face used for the current message line in MH-Folder buffers.")
***************
*** 2175,2183 ****
    "Face used for the current message line in MH-Folder buffers."
    :group 'mh-folder-faces)
  ;; backward-compatibility alias
! (put 'mh-folder-cur-msg 'face-alias 'mh-folder-cur-msg)
! ;; backward-compatibility alias
! (put ''mh-folder-cur-msg-face 'face-alias ''mh-folder-cur-msg)
  
  (defvar mh-folder-cur-msg-number-face 'mh-folder-cur-msg-number
    "Face used to highlight the current message in MH-Folder buffers.")
--- 2173,2179 ----
    "Face used for the current message line in MH-Folder buffers."
    :group 'mh-folder-faces)
  ;; backward-compatibility alias
! (put 'mh-folder-cur-msg-face 'face-alias 'mh-folder-cur-msg)
  
  (defvar mh-folder-cur-msg-number-face 'mh-folder-cur-msg-number
    "Face used to highlight the current message in MH-Folder buffers.")
***************
*** 2191,2199 ****
    "Face used to highlight the current message in MH-Folder buffers."
    :group 'mh-folder-faces)
  ;; backward-compatibility alias
! (put 'mh-folder-cur-msg-number 'face-alias 'mh-folder-cur-msg-number)
! ;; backward-compatibility alias
! (put ''mh-folder-cur-msg-number-face 'face-alias ''mh-folder-cur-msg-number)
  
  (defvar mh-folder-date-face 'mh-folder-date
    "Face used to highlight the date in MH-Folder buffers.")
--- 2187,2193 ----
    "Face used to highlight the current message in MH-Folder buffers."
    :group 'mh-folder-faces)
  ;; backward-compatibility alias
! (put 'mh-folder-cur-msg-number-face 'face-alias 'mh-folder-cur-msg-number)
  
  (defvar mh-folder-date-face 'mh-folder-date
    "Face used to highlight the date in MH-Folder buffers.")

Re: Bootstrap fails.

[Miles Bader]

> The patch below gets bootstrap working again.  Can you confirm that
> it's the right fix?

Yes that looks correct.

Thanks,

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: Bootstrap fails.

[Lute Kamstra]

Miles Bader <snogglethorpe@gmail.com> writes:

>> The patch below gets bootstrap working again.  Can you confirm that
>> it's the right fix?
>
> Yes that looks correct.

Committed,

  Lute.

Re: Bootstrap fails.

[Miles Bader]

BTW, I don't have net access from home, so I won't be able to reply
over the weekend.  If you see any more errors like that, just fix 'em
however looks best.

-Miles
-- 
Do not taunt Happy Fun Ball.

bootstrap fails

[Katsumi Yamaoka]

>>>>> Alan Mackenzie wrote:

> Log message:
> 	* progmodes/cc-vars.el (c-constant-symbol): New function which supersedes
> 	c-const-symbol.  During a customize-.. call it enables an element of
> 	(e.g.) c-hanging-braces alist to have its name displayed, even when the
> 	default value of c-h-b etc. doesn't include the elemnt.  Replace uses of
> 	the old function by the new.

By this change Emacs bootstrap fails.  The `c-constant-symbol'
function seems to have to be surrounded by `eval-and-compile'.

Regards,

Bootstrap fails

[Jan Djärv]

Hello. 

Compiling ../../current/lisp/gnus/gnus-picon.el

In toplevel form:
../../current/lisp/gnus/gnus-icalendar.el:317:1:Error: Invalid function: (--dolist-tail-- ad-advice-classes)
make[3]: *** [gnus/gnus-icalendar.elc] Error 1

      Jan D. 

Re: Bootstrap fails

[Paul Eggert]

I saw that too.  Looks like it was the
recent cl-symbol-macrolet change.  Please see:

http://bugs.gnu.org/15814#37