From: Eli Zaretskii <eliz@gnu.org>
To: Paul Rankin <hello@paulwrankin.com>
Cc: 28855@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property
Date: Tue, 17 Oct 2017 07:04:54 +0300 [thread overview]
Message-ID: <C721FF78-BF79-4CF8-AD1B-D8740E3C0F22@gnu.org> (raw)
In-Reply-To: <83a80qfq70.fsf@gnu.org>
On October 17, 2017 5:44:51 AM GMT+03:00, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Paul Rankin <hello@paulwrankin.com>
> > Cc: Dmitry Gutov <dgutov@yandex.ru>, 28855@debbugs.gnu.org
> > Date: Tue, 17 Oct 2017 10:47:11 +1000
> >
> > On Tue, 17 Oct 2017, at 02:05 AM, Eli Zaretskii wrote:
> > > Right, :align-to still counts from the window edge, even when line
> > > numbers are displayed, whereas you expected it to count from the
> end
> > > of the line-number display.
> >
> > linum-mode.el (in 26.x) manages to display line numbers without
> interfering, so it’s really just about display-line-numbers-mode.
>
> Yes, of course. linum-mode displays the numbers in the display
> margin, and keeping off the margins was an explicit design goal of
> display-line-numbers-mode.
>
> > > When this was briefly discussed during development, we decided not
> to
> > > change the reported window dimensions and geometry, including
> those of
> > > the text area, to account for the screen estate taken by the
> > > line-number display. But maybe :align-to should be an exception,
> when
> > > used to align buffer text (as opposed to header-line or
> mode-line)?
> > > Though I'm bothered whether some users of :align-to may not want
> this
> > > automatic offset. :align-to is a very popular feature; does
> anyone
> > > know or imagine why a Lisp program would NOT like such an offset?
> >
> > Citing other discussions is not really relevant, if there’s a
> problem there’s a problem. User expectation is if a user writes codes
> following the Elisp manual, the expectation is that it should continue
> to work. In this case, using :align-to should align to its specified
> value.
>
> :align-to does align to its value, it just doesn't currently update it
> to account for the space taken by line numbers.
>
> It's clear that the change I have in mind will solve your specific
> problem, I just want to hear from others whether it could harm
> something.
Btw, in case it wasn't clear: a solution for this is already available --
use line-number-display-width when computing the value of :align-to.
Like tabulated-list-mode already does.
I'm just trying to establish if a more convenient solution could be possible.
next prev parent reply other threads:[~2017-10-17 4:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 3:38 bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property Paul Rankin
2017-10-16 16:05 ` Eli Zaretskii
2017-10-17 0:47 ` Paul Rankin
2017-10-17 2:44 ` Eli Zaretskii
2017-10-17 4:04 ` Eli Zaretskii [this message]
2017-10-17 4:32 ` Paul Rankin
2017-10-17 5:49 ` Eli Zaretskii
2017-10-17 7:17 ` Paul Rankin
2017-10-18 9:29 ` Dmitry Gutov
2017-10-18 16:47 ` Eli Zaretskii
2017-10-18 17:44 ` martin rudalics
2017-10-18 17:55 ` Eli Zaretskii
2017-10-20 9:40 ` Eli Zaretskii
2017-10-18 18:05 ` Eli Zaretskii
2017-10-18 18:34 ` martin rudalics
2017-10-18 18:44 ` Eli Zaretskii
2017-10-18 23:58 ` Alex
2017-10-19 3:26 ` Eli Zaretskii
2017-10-19 5:54 ` Alex
2017-10-20 7:03 ` Eli Zaretskii
2017-10-18 22:52 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C721FF78-BF79-4CF8-AD1B-D8740E3C0F22@gnu.org \
--to=eliz@gnu.org \
--cc=28855@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=hello@paulwrankin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.