Re: [babel][PATCHES] ob-R patches for review

[Rainer M Krug <r.m.krug@gmail.com>]

Envoyé de mon iPhone

> Le 8 mai 2014 à 04:26, Charles Berry <ccberry@ucsd.edu> a écrit :
> 
> Eric Schulte <schulte.eric <at> gmail.com> writes:
> 
>> 
>> Rainer M Krug <Rainer <at> krugs.de> writes:
>> 
>>> Hi
>>> 
>>> Attached please find seven patches for review to implement the storing
>>> of org variables in their own environment and to make the org-issued R
>>> code look nicer in the R session.
>>> 
>>> Thanks,
>>> 
>>> Rainer
>> 
>> Hi Rainer,
>> 
>> Thanks for these patches.  I don't have the R experience to review or
>> maintain them, but I'm happy to apply them.
>> 
>> I missed some previous discussion in this thread.  Are these patches
>> ready to be applied as is?
> 
> 
> IMO, the patches hard coded behaviors that would better be customizable
> and optional. 

I'll give feedback tomorrow and let you know about customization of the name of the environment. The general behavior of storing the variables in an environment should not be customizable as it is

1) safer then the behavior of storing each variable separately
2) no changes for the user are introduced 

Cheers

Rainer

> 
> Rainer and I had some back and forth about this -- see the thread.
> 
> Best,
> 
> Chuck
> 
> 
>